fix: Filter nested elements by visibility when publishing pages

When publishing a page, only visible top-level elements were being
filtered. Nested elements were copied regardless of their public status,
which meant hidden nested elements would appear on the published version.

This adds a publishable_only option to DuplicateElement that filters nested
elements through the repository's visible method, ensuring only public
nested elements are copied to the published version.

Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>

Author: tvdeyen

app/models/alchemy/page/publisher.rb

@@ -30,7 +30,7 @@ def publish!(public_on:)
             ActiveRecord::Base.no_touching do
               Element.acts_as_list_no_update do
                 repository.visible.not_nested.each.with_index(1) do |element, position|
-                  Alchemy::DuplicateElement.new(element, repository: repository).call(
+                  Alchemy::DuplicateElement.new(element, repository: repository, publishable_only: true).call(
                     page_version_id: version.id,
                     position: position
                   )

app/services/alchemy/duplicate_element.rb

@@ -13,11 +13,12 @@ class DuplicateElement
       "updater_id"
     ].freeze
 
-    attr_reader :source_element, :repository
+    attr_reader :source_element, :repository, :publishable_only
 
-    def initialize(source_element, repository: source_element.page_version.element_repository)
+    def initialize(source_element, repository: source_element.page_version.element_repository, publishable_only: false)
       @source_element = source_element
       @repository = repository
+      @publishable_only = publishable_only
     end
 
     def call(differences = {})
@@ -35,9 +36,10 @@ def call(differences = {})
       new_element.save!
 
       nested_elements = repository.children_of(source_element)
+      nested_elements = nested_elements.visible if publishable_only
       Element.acts_as_list_no_update do
         nested_elements.each.with_index(1) do |nested_element, position|
-          self.class.new(nested_element, repository: repository).call(
+          self.class.new(nested_element, repository: repository, publishable_only: publishable_only).call(
             parent_element: new_element,
             page_version: new_element.page_version,
             position: position

spec/models/alchemy/page/publisher_spec.rb

@@ -124,6 +124,28 @@
       end
     end
 
+    context "with nested elements" do
+      let(:page) { create(:alchemy_page) }
+
+      let!(:parent_element) do
+        create(:alchemy_element, page_version: page.draft_version, public: true)
+      end
+
+      let!(:visible_nested) do
+        create(:alchemy_element, parent_element: parent_element, page_version: page.draft_version, public: true)
+      end
+
+      let!(:hidden_nested) do
+        create(:alchemy_element, parent_element: parent_element, page_version: page.draft_version, public: false)
+      end
+
+      it "copies only visible nested elements to public version" do
+        publish
+        published_parent = page.reload.public_version.elements.first
+        expect(published_parent.all_nested_elements).to all(be_public)
+      end
+    end
+
     context "in parallel" do
       before do
         # another publisher - instance created a mutex entry and locked the page

spec/services/alchemy/duplicate_element_spec.rb

@@ -70,5 +70,25 @@
         end
       end
     end
+
+    context "with publishable_only option" do
+      let(:element) { create(:alchemy_element) }
+
+      let!(:visible_nested) do
+        create(:alchemy_element, parent_element: element, page_version: element.page_version, public: true)
+      end
+
+      let!(:hidden_nested) do
+        create(:alchemy_element, parent_element: element, page_version: element.page_version, public: false)
+      end
+
+      subject do
+        described_class.new(element, publishable_only: true).call(differences)
+      end
+
+      it "only copies visible nested elements" do
+        expect(subject.all_nested_elements).to all(be_public)
+      end
+    end
   end
 end