Skip to content

Commit 7af8957

Browse files
authored
Merge pull request #135 from AliSoftware/hotfix/swift2.3-api-diff
Hotfix - swift2.3 api diff
2 parents bdf4477 + 6b68bea commit 7af8957

4 files changed

Lines changed: 16 additions & 9 deletions

File tree

CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
11
# CHANGELOG
22

3+
## 5.0.4
4+
5+
#### Fixed
6+
7+
* Fixed broken compatibility for Swift 2.3 API in `resolve(tag:arguments:)` method.
8+
[#135](https://github.com/AliSoftware/Dip/issues/135), [@ilyapuchka](https://github.com/ilyapuchka)
9+
310
## 5.0.3
411

512
* Added Swift 2.3 compatibility. `swift2.3` brunch is no longer maintained.

Dip.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Pod::Spec.new do |s|
22
s.name = "Dip"
3-
s.version = "5.0.3"
3+
s.version = "5.0.4"
44
s.summary = "Dependency Injection for Swift made easy."
55

66
s.description = <<-DESC

Dip/Dip.xcodeproj/project.pbxproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -427,7 +427,7 @@
427427
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
428428
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
429429
COPY_PHASE_STRIP = NO;
430-
CURRENT_PROJECT_VERSION = 5.0.3;
430+
CURRENT_PROJECT_VERSION = 5.0.4;
431431
DEBUG_INFORMATION_FORMAT = dwarf;
432432
ENABLE_STRICT_OBJC_MSGSEND = YES;
433433
ENABLE_TESTABILITY = YES;
@@ -482,7 +482,7 @@
482482
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
483483
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
484484
COPY_PHASE_STRIP = NO;
485-
CURRENT_PROJECT_VERSION = 5.0.3;
485+
CURRENT_PROJECT_VERSION = 5.0.4;
486486
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
487487
ENABLE_NS_ASSERTIONS = NO;
488488
ENABLE_STRICT_OBJC_MSGSEND = YES;

Sources/RuntimeArguments_swift2.swift

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@
157157

158158
- seealso: `register(_:tag:factory:)`, `resolve(tag:builder:)`
159159
*/
160-
public func resolve<T, A>(tag: DependencyTagConvertible? = nil, arguments arg1: A) throws -> T {
160+
public func resolve<T, A>(tag tag: DependencyTagConvertible? = nil, arguments arg1: A) throws -> T {
161161
return try resolve(tag: tag) { factory in try factory(arg1) }
162162
}
163163

@@ -174,7 +174,7 @@
174174
}
175175

176176
/// - seealso: `resolve(tag:arguments:)`
177-
public func resolve<T, A, B>(tag: DependencyTagConvertible? = nil, arguments arg1: A, _ arg2: B) throws -> T {
177+
public func resolve<T, A, B>(tag tag: DependencyTagConvertible? = nil, arguments arg1: A, _ arg2: B) throws -> T {
178178
return try resolve(tag: tag) { factory in try factory(arg1, arg2) }
179179
}
180180

@@ -191,7 +191,7 @@
191191
}
192192

193193
/// - seealso: `resolve(tag:arguments:)`
194-
public func resolve<T, A, B, C>(tag: DependencyTagConvertible? = nil, arguments arg1: A, _ arg2: B, _ arg3: C) throws -> T {
194+
public func resolve<T, A, B, C>(tag tag: DependencyTagConvertible? = nil, arguments arg1: A, _ arg2: B, _ arg3: C) throws -> T {
195195
return try resolve(tag: tag) { factory in try factory(arg1, arg2, arg3) }
196196
}
197197

@@ -208,7 +208,7 @@
208208
}
209209

210210
/// - seealso: `resolve(tag:arguments:)`
211-
public func resolve<T, A, B, C, D>(tag: DependencyTagConvertible? = nil, arguments arg1: A, _ arg2: B, _ arg3: C, _ arg4: D) throws -> T {
211+
public func resolve<T, A, B, C, D>(tag tag: DependencyTagConvertible? = nil, arguments arg1: A, _ arg2: B, _ arg3: C, _ arg4: D) throws -> T {
212212
return try resolve(tag: tag) { factory in try factory(arg1, arg2, arg3, arg4) }
213213
}
214214

@@ -225,7 +225,7 @@
225225
}
226226

227227
/// - seealso: `resolve(tag:arguments:)`
228-
public func resolve<T, A, B, C, D, E>(tag: DependencyTagConvertible? = nil, arguments arg1: A, _ arg2: B, _ arg3: C, _ arg4: D, _ arg5: E) throws -> T {
228+
public func resolve<T, A, B, C, D, E>(tag tag: DependencyTagConvertible? = nil, arguments arg1: A, _ arg2: B, _ arg3: C, _ arg4: D, _ arg5: E) throws -> T {
229229
return try resolve(tag: tag) { factory in try factory(arg1, arg2, arg3, arg4, arg5) }
230230
}
231231

@@ -242,7 +242,7 @@
242242
}
243243

244244
/// - seealso: `resolve(tag:arguments:)`
245-
public func resolve<T, A, B, C, D, E, F>(tag: DependencyTagConvertible? = nil, arguments arg1: A, _ arg2: B, _ arg3: C, _ arg4: D, _ arg5: E, _ arg6: F) throws -> T {
245+
public func resolve<T, A, B, C, D, E, F>(tag tag: DependencyTagConvertible? = nil, arguments arg1: A, _ arg2: B, _ arg3: C, _ arg4: D, _ arg5: E, _ arg6: F) throws -> T {
246246
return try resolve(tag: tag) { factory in try factory(arg1, arg2, arg3, arg4, arg5, arg6) }
247247
}
248248

0 commit comments

Comments
 (0)