fix(google-api): address PR review comments for validation and API compliance

Resolves review threads from PR #552:

Google client improvements:
- Add fieldMask validation to postComputeRoutes and postComputeRouteMatrix
- Remove unnecessary Content-Type header from GET requests (getGeocode,
  getReverseGeocode, getTimezone)
- Add dimension validation to getPlacePhoto - require maxWidthPx or maxHeightPx
  per Google Places Photo API requirements

Test updates:
- Add dimension parameters to getPlacePhoto tests
- Add test for missing dimension validation error
- Fix postNearbySearch test body order expectation

Author: BjornMelin

src/lib/google/__tests__/client.test.ts

@@ -281,6 +281,7 @@ describe("Google API Client", () => {
     it("should construct correct URL with photo name", async () => {
       await getPlacePhoto({
         apiKey: "test-key",
+        maxWidthPx: 400,
         photoName: "places/ABC123/photos/XYZ789",
       });
 
@@ -325,10 +326,20 @@ describe("Google API Client", () => {
       await expect(
         getPlacePhoto({
           apiKey: "test-key",
+          maxWidthPx: 400,
           photoName: "invalid-photo-name",
         })
       ).rejects.toThrow("Invalid photoName");
     });
+
+    it("should throw error when no dimension parameter provided", async () => {
+      await expect(
+        getPlacePhoto({
+          apiKey: "test-key",
+          photoName: "places/ABC123/photos/XYZ789",
+        })
+      ).rejects.toThrow("Either maxWidthPx or maxHeightPx must be provided");
+    });
   });
 
   describe("postNearbySearch", () => {
@@ -355,14 +366,14 @@ describe("Google API Client", () => {
         expect.objectContaining({
           // Body order matches implementation: locationRestriction, maxResultCount, then includedTypes (added conditionally)
           body: JSON.stringify({
-            includedTypes: ["restaurant", "cafe"],
             locationRestriction: {
               circle: {
                 center: { latitude: 40.7128, longitude: -74.006 },
                 radius: 2000,
               },
             },
             maxResultCount: 15,
+            includedTypes: ["restaurant", "cafe"],
           }),
           method: "POST",
         })
@@ -451,6 +462,7 @@ describe("Google API Client", () => {
     it("should include skipHttpRedirect parameter when true", async () => {
       await getPlacePhoto({
         apiKey: "test-key",
+        maxWidthPx: 400,
         photoName: "places/ABC123/photos/XYZ789",
         skipHttpRedirect: true,
       });
@@ -471,6 +483,7 @@ describe("Google API Client", () => {
     it("should not include skipHttpRedirect when not provided", async () => {
       await getPlacePhoto({
         apiKey: "test-key",
+        maxWidthPx: 400,
         photoName: "places/ABC123/photos/XYZ789",
       });
 

src/lib/google/client.ts

@@ -198,6 +198,10 @@ type ComputeRoutesParams = {
 export async function postComputeRoutes(
   params: ComputeRoutesParams
 ): Promise<Response> {
+  if (!params.fieldMask || params.fieldMask.trim().length === 0) {
+    throw new Error("fieldMask is required for computeRoutes");
+  }
+
   return await retryWithBackoff(
     () =>
       fetch("https://routes.googleapis.com/directions/v2:computeRoutes", {
@@ -235,6 +239,10 @@ type ComputeRouteMatrixParams = {
 export async function postComputeRouteMatrix(
   params: ComputeRouteMatrixParams
 ): Promise<Response> {
+  if (!params.fieldMask || params.fieldMask.trim().length === 0) {
+    throw new Error("fieldMask is required for computeRouteMatrix");
+  }
+
   return await retryWithBackoff(
     () =>
       fetch("https://routes.googleapis.com/distanceMatrix/v2:computeRouteMatrix", {
@@ -282,14 +290,11 @@ export async function getGeocode(params: GeocodeParams): Promise<Response> {
   url.searchParams.set("address", trimmedAddress);
   url.searchParams.set("key", params.apiKey);
 
-  return await retryWithBackoff(
-    () =>
-      fetch(url.toString(), {
-        headers: { "Content-Type": "application/json" },
-        method: "GET",
-      }),
-    { attempts: 3, baseDelayMs: 200, maxDelayMs: 1_000 }
-  );
+  return await retryWithBackoff(() => fetch(url.toString(), { method: "GET" }), {
+    attempts: 3,
+    baseDelayMs: 200,
+    maxDelayMs: 1_000,
+  });
 }
 
 /**
@@ -320,14 +325,11 @@ export async function getReverseGeocode(
   url.searchParams.set("latlng", `${params.lat},${params.lng}`);
   url.searchParams.set("key", params.apiKey);
 
-  return await retryWithBackoff(
-    () =>
-      fetch(url.toString(), {
-        headers: { "Content-Type": "application/json" },
-        method: "GET",
-      }),
-    { attempts: 3, baseDelayMs: 200, maxDelayMs: 1_000 }
-  );
+  return await retryWithBackoff(() => fetch(url.toString(), { method: "GET" }), {
+    attempts: 3,
+    baseDelayMs: 200,
+    maxDelayMs: 1_000,
+  });
 }
 
 // === Legacy Timezone API ===
@@ -364,14 +366,11 @@ export async function getTimezone(params: TimezoneParams): Promise<Response> {
   );
   url.searchParams.set("key", params.apiKey);
 
-  return await retryWithBackoff(
-    () =>
-      fetch(url.toString(), {
-        headers: { "Content-Type": "application/json" },
-        method: "GET",
-      }),
-    { attempts: 3, baseDelayMs: 200, maxDelayMs: 1_000 }
-  );
+  return await retryWithBackoff(() => fetch(url.toString(), { method: "GET" }), {
+    attempts: 3,
+    baseDelayMs: 200,
+    maxDelayMs: 1_000,
+  });
 }
 
 // === Places Photo API ===
@@ -407,6 +406,11 @@ export async function getPlacePhoto(params: PlacePhotoParams): Promise<Response>
     );
   }
 
+  // Google Places Photo API requires at least one dimension parameter
+  if (params.maxWidthPx === undefined && params.maxHeightPx === undefined) {
+    throw new Error("Either maxWidthPx or maxHeightPx must be provided");
+  }
+
   // Validate photo dimensions if provided
   const maxDimension = 2048;
   if (params.maxWidthPx !== undefined) {