Merged
Conversation
hsiehjack
force-pushed
the
issue-2140
branch
from
d1f507d to
409ec4a
Compare
Contributor
|
@hsiehjack please use the existing config ( |
hsiehjack
force-pushed
the
issue-2140
branch
from
409ec4a to
3ff9cb6
Compare
Contributor
|
@hsiehjack Are you planning the make the change? It would be good to have your PR. |
Contributor
Author
|
@daiyam I made the changes already. Looks like there was a build fail. I will have to take a look at what happen. |
Contributor
|
Any updates on this? |
hsiehjack
force-pushed
the
issue-2140
branch
2 times, most recently
from
6f3417f to
bdd03c4
Compare
Contributor
Author
|
Sorry for the long wait. This is ready for review. |
Contributor
|
@hsiehjack It looks like there are more conflicts. Could you resolve these, then we'll get this approved asap? |
Contributor
Author
|
@Flexo013 conflict fixed. |
Member
|
I'll review this tomorrow! |
Member
|
Sorry I've been insanely busy recently... I'll try to test it tonight or tomorrow. No more delaying I promise..! 🙏 |
Member
|
Confirmed that it's working well on macOS. I'm testing on WIndows now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2140