Skip to content

Conversation

@ehhc
Copy link
Contributor

@ehhc ehhc commented Jul 5, 2019

Debounce deletion of un-referenced attachments --> don't fixes but mitigates the problems of #3103

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Jul 6, 2019
@ZeroX-DG
Copy link
Member

ZeroX-DG commented Jul 6, 2019

@Rokt33r What do you think about this solution? Is there a better way to deal with this?

Copy link
Member

@Rokt33r Rokt33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. :) I think it is kind of the best. @ZeroX-DG

But the console message looks broken. Could you fix it? @ehhc

Deleting unneeded stupid log-message
@Rokt33r Rokt33r removed the awaiting review ❇️ Pull request is awaiting a review. label Jul 10, 2019
@Rokt33r Rokt33r added this to the v0.12.0 milestone Jul 10, 2019
@Rokt33r Rokt33r merged commit cb7ac77 into BoostIO:master Jul 10, 2019
@ehhc ehhc deleted the debounce_removing_unreferrenced_attachments branch July 10, 2019 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants