Skip to content

Commit ba7b610

Browse files
BrentOzarBrentOzar
committed
#3818 sp_Blitz skip gcloud_cloudsqladmin
Working on #3818.
1 parent a79a725 commit ba7b610

1 file changed

Lines changed: 25 additions & 25 deletions

File tree

‎sp_Blitz.sql‎

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -570,7 +570,7 @@ AS
570570
SELECT
571571
DB_NAME(d.database_id)
572572
FROM sys.databases AS d
573-
WHERE LOWER(d.name) IN ('dbatools', 'dbadmin', 'dbmaintenance', 'rdsadmin')
573+
WHERE LOWER(d.name) IN ('dbatools', 'dbadmin', 'dbmaintenance', 'gcloud_cloudsqladmin', 'rdsadmin')
574574
OPTION(RECOMPILE);
575575

576576
/*Skip checks for database where we don't have read permissions*/
@@ -4918,12 +4918,12 @@ AS
49184918
SET @StringToExecute = 'INSERT INTO #BlitzResults (CheckID, DatabaseName, Priority, FindingsGroup, Finding, URL, Details)
49194919
SELECT ' + CAST(@CurrentCheckID AS NVARCHAR(200)) + ', d.[name], ' + CAST(@CurrentPriority AS NVARCHAR(200)) + ', ''Non-Default Database Config'', ''' + @CurrentFinding + ''',''' + @CurrentURL + ''',''' + COALESCE(@CurrentDetails, 'This database setting is not the default.') + '''
49204920
FROM sys.databases d
4921-
WHERE d.database_id > 4 AND DB_NAME(d.database_id) != ''rdsadmin'' AND d.state = 0 AND (d.[' + @CurrentName + '] NOT IN (0, 60) OR d.[' + @CurrentName + '] IS NULL) OPTION (RECOMPILE);';
4921+
WHERE d.database_id > 4 AND DB_NAME(d.database_id) NOT IN (''gcloud_cloudsqladmin'',''rdsadmin'') AND d.state = 0 AND (d.[' + @CurrentName + '] NOT IN (0, 60) OR d.[' + @CurrentName + '] IS NULL) OPTION (RECOMPILE);';
49224922
ELSE
49234923
SET @StringToExecute = 'INSERT INTO #BlitzResults (CheckID, DatabaseName, Priority, FindingsGroup, Finding, URL, Details)
49244924
SELECT ' + CAST(@CurrentCheckID AS NVARCHAR(200)) + ', d.[name], ' + CAST(@CurrentPriority AS NVARCHAR(200)) + ', ''Non-Default Database Config'', ''' + @CurrentFinding + ''',''' + @CurrentURL + ''',''' + COALESCE(@CurrentDetails, 'This database setting is not the default.') + '''
49254925
FROM sys.databases d
4926-
WHERE d.database_id > 4 AND DB_NAME(d.database_id) != ''rdsadmin'' AND d.state = 0 AND (d.[' + @CurrentName + '] <> ' + @CurrentDefaultValue + ' OR d.[' + @CurrentName + '] IS NULL) OPTION (RECOMPILE);';
4926+
WHERE d.database_id > 4 AND DB_NAME(d.database_id) NOT IN (''gcloud_cloudsqladmin'',''rdsadmin'') AND d.state = 0 AND (d.[' + @CurrentName + '] <> ' + @CurrentDefaultValue + ' OR d.[' + @CurrentName + '] IS NULL) OPTION (RECOMPILE);';
49274927

49284928
IF @Debug = 2 AND @StringToExecute IS NOT NULL PRINT @StringToExecute;
49294929
IF @Debug = 2 AND @StringToExecute IS NULL PRINT '@StringToExecute has gone NULL, for some reason.';
@@ -6947,7 +6947,7 @@ IF @ProductVersionMajor >= 10
69476947
''https://www.brentozar.com/go/querystore'',
69486948
(''The new SQL Server 2016 Query Store feature has not been enabled on this database.'')
69496949
FROM [?].sys.database_query_store_options WHERE desired_state = 0
6950-
AND ''?'' NOT IN (''master'', ''model'', ''msdb'', ''rdsadmin'', ''tempdb'', ''DWConfiguration'', ''DWDiagnostics'', ''DWQueue'', ''ReportServer'', ''ReportServerTempDB'') OPTION (RECOMPILE)';
6950+
AND ''?'' NOT IN (''master'', ''model'', ''msdb'', ''rdsadmin'', ''tempdb'', ''DWConfiguration'', ''DWDiagnostics'', ''DWQueue'', ''ReportServer'', ''ReportServerTempDB'', ''gcloud_cloudsqladmin'') OPTION (RECOMPILE)';
69516951
END;
69526952

69536953
IF NOT EXISTS ( SELECT 1
@@ -6979,7 +6979,7 @@ IF @ProductVersionMajor >= 10
69796979
FROM [?].sys.database_query_store_options
69806980
WHERE desired_state <> 0
69816981
AND wait_stats_capture_mode = 0
6982-
AND ''?'' != ''rdsadmin''
6982+
AND ''?'' NOT IN (''gcloud_cloudsqladmin'', ''rdsadmin'')
69836983
OPTION (RECOMPILE)';
69846984
END;
69856985

@@ -7011,7 +7011,7 @@ IF @ProductVersionMajor >= 10
70117011
FROM [?].sys.database_query_store_options
70127012
WHERE desired_state <> 0
70137013
AND actual_state <> 2
7014-
AND ''?'' != ''rdsadmin''
7014+
AND ''?'' NOT IN (''gcloud_cloudsqladmin'', ''rdsadmin'')
70157015
OPTION (RECOMPILE)';
70167016
END;
70177017

@@ -7043,7 +7043,7 @@ IF @ProductVersionMajor >= 10
70437043
FROM [?].sys.database_query_store_options
70447044
WHERE desired_state <> 0
70457045
AND desired_state <> actual_state
7046-
AND ''?'' != ''rdsadmin''
7046+
AND ''?'' NOT IN (''gcloud_cloudsqladmin'', ''rdsadmin'')
70477047
OPTION (RECOMPILE)';
70487048
END;
70497049

@@ -7079,7 +7079,7 @@ IF @ProductVersionMajor >= 10
70797079
FROM [?].sys.database_query_store_options
70807080
WHERE desired_state <> 0 /* No point in checking this if Query Store is off. */
70817081
AND query_capture_mode_desc <> ''AUTO''
7082-
AND ''?'' != ''rdsadmin''
7082+
AND ''?'' NOT IN (''gcloud_cloudsqladmin'', ''rdsadmin'')
70837083
OPTION (RECOMPILE)';
70847084
END;
70857085

@@ -7167,7 +7167,7 @@ IF @ProductVersionMajor >= 10
71677167
(''SQL 2016 RTM has a bug involving dumps that happen every time Query Store cleanup jobs run. This is fixed in CU1 and later: https://sqlserverupdates.com/sql-server-2016-updates/'')
71687168
FROM sys.databases AS d
71697169
WHERE d.is_query_store_on = 1
7170-
AND d.name != ''rdsadmin''
7170+
AND d.name NOT IN (''gcloud_cloudsqladmin'', ''rdsadmin'')
71717171
OPTION (RECOMPILE);';
71727172

71737173
IF @Debug = 2 AND @StringToExecute IS NOT NULL PRINT @StringToExecute;
@@ -7204,7 +7204,7 @@ IF @ProductVersionMajor >= 10
72047204
FROM [?].sys.database_query_store_options dqso
72057205
join master.sys.databases D on D.name = N''?''
72067206
WHERE ((dqso.actual_state = 0 AND D.is_query_store_on = 1) OR (dqso.actual_state <> 0 AND D.is_query_store_on = 0))
7207-
AND ''?'' NOT IN (''master'', ''model'', ''msdb'', ''rdsadmin'', ''tempdb'', ''DWConfiguration'', ''DWDiagnostics'', ''DWQueue'', ''ReportServer'', ''ReportServerTempDB'') OPTION (RECOMPILE)';
7207+
AND ''?'' NOT IN (''master'', ''model'', ''msdb'', ''rdsadmin'', ''tempdb'', ''DWConfiguration'', ''DWDiagnostics'', ''DWQueue'', ''ReportServer'', ''ReportServerTempDB'', ''gcloud_cloudsqladmin'') OPTION (RECOMPILE)';
72087208
END;
72097209

72107210
IF NOT EXISTS ( SELECT 1
@@ -7232,7 +7232,7 @@ IF @ProductVersionMajor >= 10
72327232
''https://www.brentozar.com/go/manylogs'',
72337233
(''The ['' + DB_NAME() + ''] database has multiple log files on the '' + LEFT(physical_name, 1) + '' drive. This is not a performance booster because log file access is sequential, not parallel.'')
72347234
FROM [?].sys.database_files WHERE type_desc = ''LOG''
7235-
AND ''?'' NOT IN (''rdsadmin'',''tempdb'')
7235+
AND ''?'' NOT IN (''gcloud_cloudsqladmin'',''rdsadmin'',''tempdb'')
72367236
GROUP BY LEFT(physical_name, 1)
72377237
HAVING COUNT(*) > 1
72387238
AND SUM(size) < 268435456 OPTION (RECOMPILE);';
@@ -7264,7 +7264,7 @@ IF @ProductVersionMajor >= 10
72647264
(''The ['' + DB_NAME() + ''] database has multiple data files in one filegroup, but they are not all set up to grow in identical amounts. This can lead to uneven file activity inside the filegroup.'')
72657265
FROM [?].sys.database_files
72667266
WHERE type_desc = ''ROWS''
7267-
AND ''?'' != ''rdsadmin''
7267+
AND ''?'' NOT IN (''gcloud_cloudsqladmin'', ''rdsadmin'')
72687268
GROUP BY data_space_id
72697269
HAVING COUNT(DISTINCT growth) > 1 OR COUNT(DISTINCT is_percent_growth) > 1 OPTION (RECOMPILE);';
72707270
END;
@@ -7294,7 +7294,7 @@ IF @ProductVersionMajor >= 10
72947294
''The ['' + DB_NAME() + ''] database file '' + f.physical_name + '' has grown to '' + CONVERT(NVARCHAR(20), CONVERT(NUMERIC(38, 2), (f.size / 128.) / 1024.)) + '' GB, and is using percent filegrowth settings. This can lead to slow performance during growths if Instant File Initialization is not enabled.''
72957295
FROM [?].sys.database_files f
72967296
WHERE is_percent_growth = 1 and size > 128000
7297-
AND ''?'' != ''rdsadmin''
7297+
AND ''?'' NOT IN (''gcloud_cloudsqladmin'', ''rdsadmin'')
72987298
OPTION (RECOMPILE);';
72997299
END;
73007300

@@ -7324,7 +7324,7 @@ IF @ProductVersionMajor >= 10
73247324
''The ['' + DB_NAME() + ''] database file '' + f.physical_name + '' is using 1MB filegrowth settings, but it has grown to '' + CAST((CAST(f.size AS BIGINT) * 8 / 1000000) AS NVARCHAR(10)) + '' GB. Time to up the growth amount.''
73257325
FROM [?].sys.database_files f
73267326
WHERE is_percent_growth = 0 and growth=128 and size > 128000
7327-
AND ''?'' != ''rdsadmin''
7327+
AND ''?'' NOT IN (''gcloud_cloudsqladmin'', ''rdsadmin'')
73287328
OPTION (RECOMPILE);';
73297329
END;
73307330

@@ -7356,7 +7356,7 @@ IF @ProductVersionMajor >= 10
73567356
''https://www.brentozar.com/go/ee'',
73577357
(''The ['' + DB_NAME() + ''] database is using '' + feature_name + ''. If this database is restored onto a Standard Edition server, the restore will fail on versions prior to 2016 SP1.'')
73587358
FROM [?].sys.dm_db_persisted_sku_features
7359-
WHERE ''?'' != ''rdsadmin''
7359+
WHERE ''?'' NOT IN (''gcloud_cloudsqladmin'', ''rdsadmin'')
73607360
OPTION (RECOMPILE);';
73617361
END;
73627362
END;
@@ -7416,7 +7416,7 @@ IF @ProductVersionMajor >= 10
74167416
(''['' + DB_NAME() + ''] has MSreplication_objects tables in it, indicating it is a replication subscriber.'')
74177417
FROM [?].sys.tables
74187418
WHERE name = ''MSreplication_objects''
7419-
AND ''?'' NOT IN (''master'', ''rdsadmin'')
7419+
AND ''?'' NOT IN (''gcloud_cloudsqladmin'', ''master'', ''rdsadmin'')
74207420
OPTION (RECOMPILE)';
74217421
END;
74227422

@@ -7447,7 +7447,7 @@ IF @ProductVersionMajor >= 10
74477447
FROM [?].sys.triggers t INNER JOIN [?].sys.objects o ON t.parent_id = o.object_id
74487448
INNER JOIN [?].sys.schemas s ON o.schema_id = s.schema_id
74497449
WHERE t.is_ms_shipped = 0
7450-
AND ''?'' NOT IN (''rdsadmin'', ''ReportServer'')
7450+
AND ''?'' NOT IN (''gcloud_cloudsqladmin'', ''rdsadmin'', ''ReportServer'')
74517451
HAVING SUM(1) > 0 OPTION (RECOMPILE)';
74527452
END;
74537453

@@ -7478,7 +7478,7 @@ IF @ProductVersionMajor >= 10
74787478
''https://www.brentozar.com/go/misguided'',
74797479
(''The ['' + DB_NAME() + ''] database has plan guides that are no longer valid, so the queries involved may be failing silently.'')
74807480
FROM [?].sys.plan_guides g CROSS APPLY fn_validate_plan_guide(g.plan_guide_id)
7481-
WHERE ''?'' != ''rdsadmin''
7481+
WHERE ''?'' NOT IN (''gcloud_cloudsqladmin'', ''rdsadmin'')
74827482
OPTION (RECOMPILE)';
74837483
END;
74847484

@@ -7508,7 +7508,7 @@ IF @ProductVersionMajor >= 10
75087508
(''The index ['' + DB_NAME() + ''].['' + s.name + ''].['' + o.name + ''].['' + i.name + ''] is a leftover hypothetical index from the Index Tuning Wizard or Database Tuning Advisor. This index is not actually helping performance and should be removed.'')
75097509
from [?].sys.indexes i INNER JOIN [?].sys.objects o ON i.object_id = o.object_id INNER JOIN [?].sys.schemas s ON o.schema_id = s.schema_id
75107510
WHERE i.is_hypothetical = 1
7511-
AND ''?'' != ''rdsadmin''
7511+
AND ''?'' NOT IN (''gcloud_cloudsqladmin'', ''rdsadmin'')
75127512
OPTION (RECOMPILE);';
75137513
END;
75147514

@@ -7566,7 +7566,7 @@ IF @ProductVersionMajor >= 10
75667566
(''The ['' + DB_NAME() + ''] database has foreign keys that were probably disabled, data was changed, and then the key was enabled again. Simply enabling the key is not enough for the optimizer to use this key - we have to alter the table using the WITH CHECK CHECK CONSTRAINT parameter.'')
75677567
from [?].sys.foreign_keys i INNER JOIN [?].sys.objects o ON i.parent_object_id = o.object_id INNER JOIN [?].sys.schemas s ON o.schema_id = s.schema_id
75687568
WHERE i.is_not_trusted = 1 AND i.is_not_for_replication = 0 AND i.is_disabled = 0 AND ''?''
7569-
NOT IN (''master'', ''model'', ''msdb'', ''rdsadmin'', ''ReportServer'', ''ReportServerTempDB'')
7569+
NOT IN (''gcloud_cloudsqladmin'', ''master'', ''model'', ''msdb'', ''rdsadmin'', ''ReportServer'', ''ReportServerTempDB'')
75707570
OPTION (RECOMPILE);';
75717571
END;
75727572

@@ -8056,7 +8056,7 @@ EXEC dbo.sp_MSforeachdb 'USE [?]; SET TRANSACTION ISOLATION LEVEL READ UNCOMMITT
80568056
LEFT OUTER JOIN #DatabaseScopedConfigurationDefaults def ON dsc.configuration_id = def.configuration_id AND (cast(dsc.value as nvarchar(100)) = cast(def.default_value as nvarchar(100)) OR dsc.value IS NULL) AND (dsc.value_for_secondary = def.default_value_for_secondary OR dsc.value_for_secondary IS NULL)
80578057
LEFT OUTER JOIN #SkipChecks sk ON (sk.CheckID IS NULL OR def.CheckID = sk.CheckID) AND (sk.DatabaseName IS NULL OR sk.DatabaseName = DB_NAME())
80588058
WHERE def.configuration_id IS NULL AND sk.CheckID IS NULL
8059-
AND ''?'' != ''rdsadmin''
8059+
AND ''?'' NOT IN (''gcloud_cloudsqladmin'', ''rdsadmin'')
80608060
ORDER BY 1
80618061
OPTION (RECOMPILE);';
80628062
END;
@@ -8092,7 +8092,7 @@ EXEC dbo.sp_MSforeachdb 'USE [?]; SET TRANSACTION ISOLATION LEVEL READ UNCOMMITT
80928092
+ '' See sys.database_automatic_tuning_options for more details.'' AS Details
80938093
FROM sys.database_automatic_tuning_options dato
80948094
WHERE dato.desired_state IS NOT NULL AND dato.desired_state <> 2
8095-
AND ''?'' != ''rdsadmin''
8095+
AND ''?'' NOT IN (''gcloud_cloudsqladmin'', ''rdsadmin'')
80968096
;';
80978097
END; --of Check 275.
80988098

@@ -8130,7 +8130,7 @@ EXEC dbo.sp_MSforeachdb 'USE [?]; SET TRANSACTION ISOLATION LEVEL READ UNCOMMITT
81308130
OR sm.uses_quoted_identifier <> 1
81318131
)
81328132
AND o.is_ms_shipped = 0
8133-
AND ''?'' != ''rdsadmin''
8133+
AND ''?'' NOT IN (''gcloud_cloudsqladmin'', ''rdsadmin'')
81348134
HAVING COUNT(1) > 0;';
81358135
END; --of Check 218.
81368136

@@ -8163,7 +8163,7 @@ EXEC dbo.sp_MSforeachdb 'USE [?]; SET TRANSACTION ISOLATION LEVEL READ UNCOMMITT
81638163
FROM sys.index_resumable_operations iro
81648164
JOIN sys.objects o ON iro.[object_id] = o.[object_id]
81658165
WHERE iro.state <> 0
8166-
AND ''?'' != ''rdsadmin''
8166+
AND ''?'' NOT IN (''gcloud_cloudsqladmin'', ''rdsadmin'')
81678167
;';
81688168
END; --of Check 225.
81698169

@@ -8198,7 +8198,7 @@ EXEC dbo.sp_MSforeachdb 'USE [?]; SET TRANSACTION ISOLATION LEVEL READ UNCOMMITT
81988198
-- WHERE o.is_ms_shipped = 0 AND o.type_desc = ''USER_TABLE''
81998199
-- AND h.object_id IS NULL
82008200
-- AND 0 < (SELECT SUM(row_count) FROM sys.dm_db_partition_stats ps WHERE ps.object_id = o.object_id)
8201-
-- AND ''?'' NOT IN (''master'', ''model'', ''msdb'', ''rdsadmin'', ''tempdb'')
8201+
-- AND ''?'' NOT IN (''gcloud_cloudsqladmin'', ''master'', ''model'', ''msdb'', ''rdsadmin'', ''tempdb'')
82028202
-- HAVING COUNT(DISTINCT o.object_id) > 0;';
82038203
--END; --of Check 220.
82048204

0 commit comments

Comments
 (0)