Skip to content

Commit 7775a83

Browse files
fix: use full path to conda env (#64)
* fix: use full path to conda env * chore: update CHANGELOG.md * test: update tests for new biowulf conda activate * test: forgotten conda activate
1 parent c5ffed5 commit 7775a83

4 files changed

Lines changed: 8 additions & 4 deletions

File tree

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## Tools development version
2+
3+
- fix `ccbr_tools install`: use the full path to the conda env on biowulf. (#64, @kelly-sovacool)
4+
15
## Tools 0.3.1
26

37
- Bug fixes in `ccbr_tools install`:

src/ccbr_tools/pipeline/hpc.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ class Biowulf(Cluster):
7070
GROUP = "CCBR_Pipeliner"
7171
PIPELINES_HOME = pathlib.Path("/data/CCBR_Pipeliner/Pipelines")
7272
TOOLS_HOME = pathlib.Path("/data/CCBR_Pipeliner/Tools")
73-
CONDA_ACTIVATE = '. "/data/CCBR_Pipeliner/db/PipeDB/Conda/etc/profile.d/conda.sh" && conda activate py311'
73+
CONDA_ACTIVATE = "conda activate /data/CCBR_Pipeliner/db/PipeDB/Conda/envs/py311"
7474

7575
def __init__(self):
7676
super().__init__()

tests/test_pipeline_hpc.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ def test_hpc_biowulf():
1414
"<class 'ccbr_tools.pipeline.hpc.Biowulf'>({'name': 'biowulf'"
1515
),
1616
hpc.CONDA_ACTIVATE
17-
== '. "/data/CCBR_Pipeliner/db/PipeDB/Conda/etc/profile.d/conda.sh" && conda activate py311',
17+
== "conda activate /data/CCBR_Pipeliner/db/PipeDB/Conda/envs/py311",
1818
]
1919
)
2020

tests/test_software.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ def test_install():
4242
)
4343
assert (
4444
result
45-
== """. "/data/CCBR_Pipeliner/db/PipeDB/Conda/etc/profile.d/conda.sh" && conda activate py311
45+
== """conda activate /data/CCBR_Pipeliner/db/PipeDB/Conda/envs/py311
4646
pip install git+https://github.com/CCBR/CHAMPAGNE.git@v0.3.0 -t /data/CCBR_Pipeliner/Pipelines/CHAMPAGNE/.v0.3.0
4747
chmod -R a+rX /data/CCBR_Pipeliner/Pipelines/CHAMPAGNE/.v0.3.0
4848
chown -R :CCBR_Pipeliner /data/CCBR_Pipeliner/Pipelines/CHAMPAGNE/.v0.3.0
@@ -63,7 +63,7 @@ def test_install_dev():
6363
)
6464
assert (
6565
result
66-
== """. "/data/CCBR_Pipeliner/db/PipeDB/Conda/etc/profile.d/conda.sh" && conda activate py311
66+
== """conda activate /data/CCBR_Pipeliner/db/PipeDB/Conda/envs/py311
6767
pip install git+https://github.com/CCBR/CHAMPAGNE.git@main -t /data/CCBR_Pipeliner/Pipelines/CHAMPAGNE/.v0.3.0-dev
6868
chmod -R a+rX /data/CCBR_Pipeliner/Pipelines/CHAMPAGNE/.v0.3.0-dev
6969
chown -R :CCBR_Pipeliner /data/CCBR_Pipeliner/Pipelines/CHAMPAGNE/.v0.3.0-dev

0 commit comments

Comments
 (0)