testing

Author: pvelesko

README.md

@@ -36,10 +36,9 @@ The following libraries have been ported and should work on any platform:
 ## Applications
 
 chipStar has so far been tested using the following applications:
-- [libCEED]()
-- [GAMESS]
-- [HcBench]
-- TODO
+- [libCEED](https://github.com/CHIP-SPV/libCEED) Our fork includes some workarounds. 
+- [GAMESS](https://www.msg.chem.iastate.edu/gamess/) Source code is not public.
+- [HcBench](https://github.com/zjin-lcf/HeCBench) CUDA Benchmarks. 
 
 ## Getting Started
 

scripts/check.py

@@ -170,4 +170,4 @@ def run_tests(num_tries):
 if "0 tests failed" in res:
     exit(0)
 else:
-    exit(1)
+    exit(1)

src/backend/OpenCL/CHIPBackendOpenCL.cc

@@ -753,6 +753,7 @@ bool CHIPEventOpenCL::wait() {
 }
 
 bool CHIPEventOpenCL::updateFinishStatus(bool ThrowErrorIfNotReady) {
+  logTrace("CHIPEventOpenCL::updateFinishStatus()");
   if (ThrowErrorIfNotReady && this->ClEvent == nullptr)
     CHIPERR_LOG_AND_THROW("OpenCL has not been initialized cl_event is null",
                           hipErrorNotReady);
@@ -1088,6 +1089,7 @@ struct HipStreamCallbackData {
   void *UserData;
   hipStreamCallback_t Callback;
   std::shared_ptr<chipstar::Event> CallbackFinishEvent;
+  std::shared_ptr<chipstar::Event> CallbackCompleted;
 };
 
 void CL_CALLBACK pfn_notify(cl_event Event, cl_int CommandExecStatus,
@@ -1105,7 +1107,7 @@ void CL_CALLBACK pfn_notify(cl_event Event, cl_int CommandExecStatus,
         CL_COMPLETE);
       CHIPERR_CHECK_LOG_AND_THROW_TABLE(clSetUserEventStatus);
   }
-  // delete Cbo;
+  delete Cbo;
 }
 
 void CHIPQueueOpenCL::MemMap(const chipstar::AllocationInfo *AllocInfo,
@@ -1219,10 +1221,10 @@ void CHIPQueueOpenCL::addCallback(hipStreamCallback_t Callback,
   // finishing the user CB's execution.
 
   HipStreamCallbackData *Cb = new HipStreamCallbackData{
-      this, hipSuccess, UserData, Callback, CallbackEvent};
+      this, hipSuccess, UserData, Callback, CallbackEvent, nullptr};
 
   std::vector<std::shared_ptr<chipstar::Event>> WaitForEventsCBB{CallbackEvent};
-  auto CallbackCompleted = enqueueBarrier(WaitForEventsCBB);
+  Cb->CallbackCompleted = enqueueBarrier(WaitForEventsCBB);
 
   // We know that the callback won't be yet launched since it's depending
   // on the barrier which waits for the user event.
@@ -1232,7 +1234,7 @@ void CHIPQueueOpenCL::addCallback(hipStreamCallback_t Callback,
       CL_COMPLETE, pfn_notify, Cb);
   CHIPERR_CHECK_LOG_AND_THROW_TABLE(clSetEventCallback);
 
-  updateLastEvent(CallbackCompleted);
+  updateLastEvent(Cb->CallbackCompleted);
 
   // Now the CB can start executing in the background:
   clSetUserEventStatus(
@@ -1241,7 +1243,7 @@ void CHIPQueueOpenCL::addCallback(hipStreamCallback_t Callback,
   CHIPERR_CHECK_LOG_AND_THROW_TABLE(clSetUserEventStatus);
 
   return;
-};
+}
 
 std::shared_ptr<chipstar::Event> CHIPQueueOpenCL::enqueueMarkerImpl() {
   std::shared_ptr<chipstar::Event> MarkerEvent =
@@ -1409,8 +1411,7 @@ CHIPQueueOpenCL::~CHIPQueueOpenCL() {
   logTrace("~CHIPQueueOpenCL() {}", (void *)this);
 }
 
-std::shared_ptr<chipstar::Event>
-CHIPQueueOpenCL::memCopyAsyncImpl(void *Dst, const void *Src, size_t Size,
+std::shared_ptr<chipstar::Event> CHIPQueueOpenCL::memCopyAsyncImpl(void *Dst, const void *Src, size_t Size,
                                   hipMemcpyKind Kind) {
   std::shared_ptr<chipstar::Event> Event =
       static_cast<CHIPBackendOpenCL *>(Backend)->createEventShared(