Skip to content

Commit 6ae546b

Browse files
committed
fix closing worker pipes
1 parent 1f5c9e8 commit 6ae546b

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

runtime/task.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -883,21 +883,24 @@ func (t *Task) Run(ctx context.Context, task *runnerv1.Task, runnerWorker []stri
883883
src, _ := json.Marshal(jmessage)
884884
jobExecCtx := ctx
885885

886-
worker = exec.CommandContext(reportingCtx, runnerWorker[0], runnerWorker[1:]...)
886+
worker = exec.Command(runnerWorker[0], runnerWorker[1:]...)
887887
// ignore CTRL+C
888888
worker.SysProcAttr = getSysProcAttr()
889889
in, err := worker.StdinPipe()
890890
if err != nil {
891891
return err
892892
}
893+
defer in.Close()
893894
er, err := worker.StderrPipe()
894895
if err != nil {
895896
return err
896897
}
898+
defer er.Close()
897899
out, err := worker.StdoutPipe()
898900
if err != nil {
899901
return err
900902
}
903+
defer out.Close()
901904
err = worker.Start()
902905
if err != nil {
903906
return err

0 commit comments

Comments
 (0)