Skip to content

Commit b861c7b

Browse files
serenaabbott11retmanski
authored andcommitted
Remove the divs around the list items to fix the footer accessibility issues
1 parent 464eca3 commit b861c7b

1 file changed

Lines changed: 18 additions & 26 deletions

File tree

app/views/shared/_dfe_footer.html.erb

Lines changed: 18 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -7,32 +7,24 @@
77
<div class="govuk-footer__meta-item govuk-footer__meta-item--grow">
88
<h2 class="govuk-visually-hidden"><%= t(".support_links") %></h2>
99
<ul class="govuk-footer__inline-list">
10-
<div class="govuk-grid-row">
11-
<div class="govuk-grid-column-two-thirds">
12-
<li class="govuk-footer__inline-list-item">
13-
<a class="govuk-footer__link" href="/procurement-support"><%= t(".procurement_help") %></a>
14-
</li>
15-
<li class="govuk-footer__inline-list-item">
16-
<%= privacy_link(class: "govuk-footer__link") %>
17-
</li>
18-
<li class="govuk-footer__inline-list-item">
19-
<a class="govuk-footer__link" href="/cookie_preferences"><%= t(".cookies") %></a>
20-
</li>
21-
</div>
22-
</div>
23-
<div class="govuk-grid-row">
24-
<div class="govuk-grid-column-two-thirds">
25-
<li class="govuk-footer__inline-list-item">
26-
<%= accessibility_link(class: "govuk-footer__link") %>
27-
</li>
28-
<li class="govuk-footer__inline-list-item">
29-
<a class="govuk-footer__link" href="/terms-and-conditions"><%= t(".terms_and_conditions") %></a>
30-
</li>
31-
<li class="govuk-footer__inline-list-item">
32-
<a class="govuk-footer__link" href="<%=customer_satisfaction_survey_url("footer_link") %>"><%= t(".feedback") %></a>
33-
</li>
34-
</div>
35-
</div>
10+
<li class="govuk-footer__inline-list-item">
11+
<a class="govuk-footer__link" href="/procurement-support"><%= t(".procurement_help") %></a>
12+
</li>
13+
<li class="govuk-footer__inline-list-item">
14+
<%= privacy_link(class: "govuk-footer__link") %>
15+
</li>
16+
<li class="govuk-footer__inline-list-item">
17+
<a class="govuk-footer__link" href="/cookie_preferences"><%= t(".cookies") %></a>
18+
</li>
19+
<li class="govuk-footer__inline-list-item">
20+
<%= accessibility_link(class: "govuk-footer__link") %>
21+
</li>
22+
<li class="govuk-footer__inline-list-item">
23+
<a class="govuk-footer__link" href="/terms-and-conditions"><%= t(".terms_and_conditions") %></a>
24+
</li>
25+
<li class="govuk-footer__inline-list-item">
26+
<a class="govuk-footer__link" href="<%=customer_satisfaction_survey_url("footer_link") %>"><%= t(".feedback") %></a>
27+
</li>
3628
</ul>
3729
<svg aria-hidden="true" focusable="false" class="govuk-footer__licence-logo" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 483.2 195.7" height="17" width="41">
3830
<path fill="currentColor" d="M421.5 142.8V.1l-50.7 32.3v161.1h112.4v-50.7zm-122.3-9.6A47.12 47.12 0 0 1 221 97.8c0-26 21.1-47.1 47.1-47.1 16.7 0 31.4 8.7 39.7 21.8l42.7-27.2A97.63 97.63 0 0 0 268.1 0c-36.5 0-68.3 20.1-85.1 49.7A98 98 0 0 0 97.8 0C43.9 0 0 43.9 0 97.8s43.9 97.8 97.8 97.8c36.5 0 68.3-20.1 85.1-49.7a97.76 97.76 0 0 0 149.6 25.4l19.4 22.2h3v-87.8h-80l24.3 27.5zM97.8 145c-26 0-47.1-21.1-47.1-47.1s21.1-47.1 47.1-47.1 47.2 21 47.2 47S123.8 145 97.8 145"></path>

0 commit comments

Comments
 (0)