Skip to content

Commit 4c5c689

Browse files
authored
Merge pull request #8467 from cserf/Fix_setmetadata
fix: RucioFileCatalogClient.setMetadata returns empty result on success
2 parents c42c992 + a9a8adb commit 4c5c689

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

src/DIRAC/Resources/Catalog/RucioFileCatalogClient.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -751,7 +751,9 @@ def setMetadataBulk(self, pathMetadataDict):
751751
"""Add metadata for the given paths"""
752752
resDict = {"Successful": {}, "Failed": {}}
753753
dids = []
754+
paths = []
754755
for path, metadataDict in pathMetadataDict.items():
756+
paths.append(path)
755757
try:
756758
did = self.__getDidsFromLfn(path)
757759
did["meta"] = metadataDict
@@ -760,8 +762,10 @@ def setMetadataBulk(self, pathMetadataDict):
760762
return S_ERROR(str(err))
761763
try:
762764
self.client.set_dids_metadata_bulk(dids=dids, recursive=False)
765+
resDict["Successful"] = {path: True for path in paths}
763766
except Exception as err:
764-
return S_ERROR(str(err))
767+
resDict["Failed"] = {path: str(err) for path in paths}
768+
return S_ERROR(resDict)
765769
return S_OK(resDict)
766770

767771
@checkCatalogArguments

0 commit comments

Comments
 (0)