Skip to content

Commit 322342b

Browse files
authored
Merge pull request #2173 from DLR-AMR/remove-document-todos
Improvement: Remove some more todo notes and correct usage of forest in cmesh example header
2 parents 341f3e9 + 46cae1a commit 322342b

14 files changed

+18
-37
lines changed

src/t8_cmesh/t8_cmesh_examples.h

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ t8_cmesh_new_empty (sc_MPI_Comm comm, const int do_partition, const int dimensio
7777
t8_cmesh_t
7878
t8_cmesh_new_from_class (t8_eclass_t eclass, sc_MPI_Comm comm);
7979

80-
/** Construct a hypercube forest from one primitive tree class.
80+
/** Construct a hypercube cmesh from one primitive tree class.
8181
* \param [in] eclass This element class determines the dimension and
8282
* the number of trees needed to construct a cube.
8383
* \param [in] comm The mpi communicator to be used.
@@ -92,7 +92,7 @@ t8_cmesh_new_from_class (t8_eclass_t eclass, sc_MPI_Comm comm);
9292
t8_cmesh_t
9393
t8_cmesh_new_hypercube (t8_eclass_t eclass, sc_MPI_Comm comm, int do_bcast, int do_partition, int periodic);
9494

95-
/** Construct a hypercube forest from one primitive tree class.
95+
/** Construct a hypercube cmesh from one primitive tree class.
9696
* \param [in] eclass This element class determines the dimension of the cube.
9797
* \param [in] comm The mpi communicator to be used.
9898
* \param [in] boundary The vertices, that define the hypercube boundary.
@@ -131,7 +131,7 @@ t8_cmesh_t
131131
t8_cmesh_new_hypercube_pad (const t8_eclass_t eclass, sc_MPI_Comm comm, const double *boundary, t8_locidx_t polygons_x,
132132
t8_locidx_t polygons_y, t8_locidx_t polygons_z, const int use_axis_aligned);
133133

134-
/** Construct a hypercube forest from one primitive tree class.
134+
/** Construct a hypercube cmesh from one primitive tree class.
135135
* \param [in] eclass This element class determines the dimension of the cube.
136136
* \param [in] comm The mpi communicator to be used.
137137
* \param [in] boundary The vertices, that define the hypercube boundary.
@@ -190,7 +190,7 @@ t8_cmesh_new_hypercube_hybrid (sc_MPI_Comm comm, int do_partition, int periodic)
190190
* Hypercube?
191191
* TODO: redundant, remove.
192192
* \param [in] comm The mpi communicator to use.
193-
* \param [in] dim The dimension of the forest, 1, 2 or 3.
193+
* \param [in] dim The dimension of the cmesh, 1, 2 or 3.
194194
* \return A valid cmesh, as if _init and _commit had been called.
195195
*/
196196
t8_cmesh_t
@@ -228,14 +228,14 @@ t8_cmesh_new_periodic_line_more_trees (sc_MPI_Comm comm);
228228
t8_cmesh_t
229229
t8_cmesh_new_bigmesh (t8_eclass_t eclass, int num_trees, sc_MPI_Comm comm);
230230

231-
/** Construct a forest of three connected askew lines
231+
/** Construct a cmesh of three connected askew lines
232232
* \param [in] comm The mpi communicator to use.
233233
* \return A valid cmesh, as if _init and _commit had been called.
234234
*/
235235
t8_cmesh_t
236236
t8_cmesh_new_line_zigzag (sc_MPI_Comm comm);
237237

238-
/** Construct a forest of num_of_prisms connected prism, all with one edge in 0,
238+
/** Construct a cmesh of num_of_prisms connected prism, all with one edge in 0,
239239
* except for num_of_prisms = 2, then the return is the hypercube mesh
240240
* \param [in] comm The mpi communicator to use.
241241
* \param [in] num_of_prisms The number of prisms to be used.
@@ -256,14 +256,14 @@ t8_cmesh_new_prism_deformed (sc_MPI_Comm comm);
256256
t8_cmesh_t
257257
t8_cmesh_new_pyramid_deformed (sc_MPI_Comm comm);
258258

259-
/** Construct a forest of six connected noncannoical oriented prisms
259+
/** Construct a cmesh of six connected noncannoical oriented prisms
260260
* \param [in] comm The mpi communicator to use.
261261
* \return A valid cmesh, as if _init and _commit had been called.
262262
*/
263263
t8_cmesh_t
264264
t8_cmesh_new_prism_cake_funny_oriented (sc_MPI_Comm comm);
265265

266-
/** Construct a forest of six connected noncannoical oriented prisms
266+
/** Construct a cmesh of six connected noncannoical oriented prisms
267267
* \param [in] comm The mpi communicator to use.
268268
* \return A valid cmesh, as if _init and _commit had been called.
269269
*/

src/t8_cmesh/t8_cmesh_geometry.hxx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222

2323
/** \file t8_cmesh_geometry.hxx
2424
* Internal functions that we need for the cmesh geometry.
25-
* TODO: document this file
2625
*/
2726

2827
#ifndef T8_CMESH_GEOMETRY_H

src/t8_cmesh/t8_cmesh_internal/t8_cmesh_commit.cxx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,7 @@
2121
*/
2222

2323
/** \file t8_cmesh_commit.cxx
24-
*
25-
* TODO: document this file
24+
* Functionality to commit a cmesh.
2625
*/
2726

2827
#include <t8_data/t8_shmem.h>

src/t8_cmesh/t8_cmesh_internal/t8_cmesh_copy.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,7 @@
2121
*/
2222

2323
/** \file t8_cmesh_copy.c
24-
*
25-
* TODO: document this file
24+
* Functionality to copy a cmesh.
2625
*/
2726

2827
#include <t8_data/t8_shmem.h>

src/t8_cmesh/t8_cmesh_internal/t8_cmesh_copy.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,7 @@
2121
*/
2222

2323
/** \file t8_cmesh_copy.h
24-
*
25-
* TODO: document this file
24+
* Function to copy a cmesh.
2625
*/
2726

2827
#ifndef T8_CMESH_COPY_H

src/t8_cmesh/t8_cmesh_internal/t8_cmesh_offset.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@
2121
*/
2222

2323
/** \file t8_cmesh_offset.c
24-
*
25-
* TODO: document this file
24+
* Implementation of functions that deal with
25+
* the cmesh partition offset.
2626
*/
2727

2828
#include "t8_cmesh_offset.h"

src/t8_cmesh/t8_cmesh_internal/t8_cmesh_offset.h

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,8 @@
2121
*/
2222

2323
/** \file t8_cmesh_offset.h
24-
*
25-
* In this file we collect function that deal with
24+
* In this file we collect functions that deal with
2625
* the cmesh partition offset.
27-
*
28-
* TODO: document this file
2926
*/
3027

3128
#ifndef T8_CMESH_OFFSET_H

src/t8_cmesh/t8_cmesh_internal/t8_cmesh_partition.cxx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,7 @@
2121
*/
2222

2323
/** \file t8_cmesh_partition.cxx
24-
*
25-
* TODO: document this file
24+
* Implementation of functionality related to the partitioning of a cmesh.
2625
*/
2726

2827
#include <cstring>

src/t8_cmesh/t8_cmesh_internal/t8_cmesh_partition.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,7 @@
2121
*/
2222

2323
/** \file t8_cmesh_partition.h
24-
*
25-
* TODO: document this file
24+
* Functionality related to the partitioning of a cmesh.
2625
*/
2726

2827
#ifndef T8_CMESH_PARTITION_H

src/t8_cmesh/t8_cmesh_internal/t8_cmesh_trees.cxx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,7 @@
2121
*/
2222

2323
/** \file t8_cmesh_trees.cxx
24-
*
25-
* TODO: document this file
24+
* Interface for the data layout of the coarse trees.
2625
*/
2726

2827
#include <vector>

0 commit comments

Comments
 (0)