Skip to content

Commit 4fbdf2c

Browse files
committed
Skip lying resolvers instead of just warning about them
1 parent c4879a2 commit 4fbdf2c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

dnscrypt-proxy/serversInfo.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -706,7 +706,7 @@ func fetchDoHServerInfo(proxy *Proxy, name string, stamp stamps.ServerStamp, isN
706706
return ServerInfo{}, err
707707
}
708708
if msg.Rcode != dns.RcodeNameError {
709-
dlog.Criticalf("[%s] may be a lying resolver", name)
709+
return ServerInfo{}, fmt.Errorf("[%s] may be a lying resolver -- skipping", name)
710710
}
711711
protocol := tls.NegotiatedProtocol
712712
if len(protocol) == 0 {
@@ -869,7 +869,7 @@ func _fetchODoHTargetInfo(proxy *Proxy, name string, stamp stamps.ServerStamp, i
869869
return ServerInfo{}, err
870870
}
871871
if msg.Rcode != dns.RcodeNameError {
872-
dlog.Criticalf("[%s] may be a lying resolver", name)
872+
return ServerInfo{}, fmt.Errorf("[%s] may be a lying resolver -- skipping", name)
873873
}
874874
protocol := "http"
875875
tlsVersion := uint16(0)

0 commit comments

Comments
 (0)