Skip to content

Commit 1ebe279

Browse files
authored
Merge pull request #30 from Taritsyn/master
Added a `net471` and `netstandard2.0` targets
2 parents a38d332 + 4a6a6d1 commit 1ebe279

5 files changed

Lines changed: 14 additions & 20 deletions

File tree

global.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"projects": [ "src", "test" ],
33
"sdk": {
4-
"version": "1.0.0"
4+
"version": "2.0.0"
55
}
66
}

src/JSPool.Example.Console/JSPool.Example.Console.csproj

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFrameworks>net451;netcoreapp1.0</TargetFrameworks>
4+
<TargetFrameworks>net451;net471;netcoreapp1.0;netcoreapp2.0</TargetFrameworks>
55
<AssemblyName>JSPool.Example.Console</AssemblyName>
66
<OutputType>Exe</OutputType>
77
<PackageId>JSPool.Example.Console</PackageId>
@@ -26,15 +26,13 @@
2626
<PackageReference Include="JavaScriptEngineSwitcher.Core" Version="3.0.0-beta4" />
2727
</ItemGroup>
2828

29-
<ItemGroup Condition=" '$(TargetFramework)' == 'net451' ">
29+
<ItemGroup Condition=" '$(TargetFramework)' == 'net451' Or '$(TargetFramework)' == 'net471' ">
3030
<PackageReference Include="JavaScriptEngineSwitcher.V8" Version="3.0.0-beta4" />
3131
<PackageReference Include="JavaScriptEngineSwitcher.V8.Native.win-x64" Version="3.0.0-beta3" />
3232
<PackageReference Include="JavaScriptEngineSwitcher.V8.Native.win-x86" Version="3.0.0-beta3" />
33-
<Reference Include="System" />
34-
<Reference Include="Microsoft.CSharp" />
3533
</ItemGroup>
3634

37-
<ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp1.0' ">
35+
<ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp1.0' Or '$(TargetFramework)' == 'netcoreapp2.0' ">
3836
<PackageReference Include="JavaScriptEngineSwitcher.ChakraCore" Version="3.0.0-beta5" />
3937
<PackageReference Include="JavaScriptEngineSwitcher.ChakraCore.Native.linux-x64" Version="3.0.0-beta3" />
4038
<PackageReference Include="JavaScriptEngineSwitcher.ChakraCore.Native.osx-x64" Version="3.0.0-beta3" />

src/JSPool.Example.Console/Program.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
using System;
99
using JavaScriptEngineSwitcher.Core;
1010

11-
#if NETCOREAPP1_0
11+
#if NETCOREAPP1_0 || NETCOREAPP2_0
1212
using JavaScriptEngineSwitcher.ChakraCore;
1313
#else
1414
using JavaScriptEngineSwitcher.V8;
@@ -23,7 +23,7 @@ static void Main(string[] args)
2323
// Configure JavaScriptEngineSwitcher. Generally V8 is preferred, however
2424
// it's currently not supported on .NET Core.
2525
IJsEngineSwitcher engineSwitcher = JsEngineSwitcher.Current;
26-
#if NETCOREAPP1_0
26+
#if NETCOREAPP1_0 || NETCOREAPP2_0
2727
engineSwitcher.EngineFactories.AddChakraCore();
2828
engineSwitcher.DefaultEngineName = ChakraCoreJsEngine.EngineName;
2929
#else

src/JSPool/JSPool.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ See https://dan.cx/projects/jspool for usage instructions.</Description>
77
<Copyright>Daniel Lo Nigro</Copyright>
88
<PackageIconUrl>https://stuff.dan.cx/images/projects/jspool-logo-256.png</PackageIconUrl>
99
<VersionPrefix>3.0.1</VersionPrefix>
10-
<TargetFrameworks>net40-client;net451;netstandard1.3</TargetFrameworks>
10+
<TargetFrameworks>net40-client;net451;net471;netstandard1.3;netstandard2.0</TargetFrameworks>
1111
<GenerateDocumentationFile>true</GenerateDocumentationFile>
1212
<AssemblyName>JSPool</AssemblyName>
1313
<AssemblyOriginatorKeyFile>../key.snk</AssemblyOriginatorKeyFile>
Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFramework>net452</TargetFramework>
4+
<TargetFrameworks>net452;net471;netcoreapp1.0;netcoreapp2.0</TargetFrameworks>
55
<DebugType>portable</DebugType>
66
<AssemblyName>JSPool.Tests</AssemblyName>
77
<PackageId>JSPool.Tests</PackageId>
8+
<RuntimeFrameworkVersion Condition=" '$(TargetFramework)' == 'netcoreapp1.0' ">1.0.4</RuntimeFrameworkVersion>
89
<GenerateRuntimeConfigurationFiles>true</GenerateRuntimeConfigurationFiles>
910
<GenerateAssemblyTitleAttribute>false</GenerateAssemblyTitleAttribute>
1011
<GenerateAssemblyDescriptionAttribute>false</GenerateAssemblyDescriptionAttribute>
@@ -19,16 +20,11 @@
1920
</ItemGroup>
2021

2122
<ItemGroup>
22-
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.0.0-preview-20170106-08" />
23-
<PackageReference Include="Moq" Version="4.5.21" />
24-
<PackageReference Include="xunit" Version="2.3.0-beta2-build3683" />
25-
<PackageReference Include="xunit.runner.visualstudio" Version="2.3.0-beta2-build1317" />
26-
<DotNetCliToolReference Include="dotnet-xunit" Version="2.3.0-beta1-build3642" />
27-
</ItemGroup>
28-
29-
<ItemGroup Condition=" '$(TargetFramework)' == 'net451' ">
30-
<Reference Include="System" />
31-
<Reference Include="Microsoft.CSharp" />
23+
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.7.2" />
24+
<PackageReference Include="Moq" Version="4.8.3" />
25+
<PackageReference Include="xunit" Version="2.3.1" />
26+
<PackageReference Include="xunit.runner.visualstudio" Version="2.3.1" />
27+
<DotNetCliToolReference Include="dotnet-xunit" Version="2.3.1" />
3228
</ItemGroup>
3329

3430
</Project>

0 commit comments

Comments
 (0)