Merge pull request #278 from DecSmith42/fix/remove-bad-methods

feat(workflows): simplify artifact handling and remove redundant tasks

Author: DecSmith42

.devops/workflows/Test_Devops_Build.yml

@@ -277,42 +277,6 @@ jobs:
           artifact: DecSm.Atom.Tool-windows-latest
           path: "$(Build.ArtifactStagingDirectory)/DecSm.Atom.Tool"
 
-      - task: DownloadPipelineArtifact@2
-        displayName: DecSm.Atom.Tool
-        inputs:
-          artifact: DecSm.Atom.Tool-windows-11-arm
-          path: "$(Build.ArtifactStagingDirectory)/DecSm.Atom.Tool"
-      
-      - task: DownloadPipelineArtifact@2
-        displayName: DecSm.Atom.Tool
-        inputs:
-          artifact: DecSm.Atom.Tool-ubuntu-latest
-          path: "$(Build.ArtifactStagingDirectory)/DecSm.Atom.Tool"
-      
-      - task: DownloadPipelineArtifact@2
-        displayName: DecSm.Atom.Tool
-        inputs:
-          artifact: DecSm.Atom.Tool-ubuntu-24.04-arm
-          path: "$(Build.ArtifactStagingDirectory)/DecSm.Atom.Tool"
-      
-      - task: DownloadPipelineArtifact@2
-        displayName: DecSm.Atom.Tool
-        inputs:
-          artifact: DecSm.Atom.Tool-macos-15-intel
-          path: "$(Build.ArtifactStagingDirectory)/DecSm.Atom.Tool"
-      
-      - task: DownloadPipelineArtifact@2
-        displayName: DecSm.Atom.Tool
-        inputs:
-          artifact: DecSm.Atom.Tool-macos-latest
-          path: "$(Build.ArtifactStagingDirectory)/DecSm.Atom.Tool"
-      
-      - task: DownloadPipelineArtifact@2
-        displayName: DecSm.Atom.Tool
-        inputs:
-          artifact: DecSm.Atom.Tool-windows-latest
-          path: "$(Build.ArtifactStagingDirectory)/DecSm.Atom.Tool"
-      
       - task: DownloadPipelineArtifact@2
         displayName: DecSm.Atom.Tool
         inputs:

DecSm.Atom.Tests/ApiSurfaceTests/PublicApiSurfaceTests.VerifyPublicApiSurface.verified.txt

@@ -451,12 +451,6 @@
       {
         Name: ConsumesArtifacts
       },
-      {
-        Name: ConsumesNoArtifacts
-      },
-      {
-        Name: ConsumesNoVariables
-      },
       {
         Name: ConsumesVariable
       },
@@ -514,12 +508,6 @@
       {
         Name: ProducesArtifacts
       },
-      {
-        Name: ProducesNoArtifacts
-      },
-      {
-        Name: ProducesNoVariables
-      },
       {
         Name: ProducesVariable
       },

DecSm.Atom/Build/Definition/TargetDefinition.cs

@@ -298,17 +298,6 @@ public TargetDefinition ProducesArtifacts(IEnumerable<string> artifactName, stri
         return this;
     }
 
-    /// <summary>
-    ///     Clears all produced artifacts for the current target, ensuring it does not produce any artifacts.
-    /// </summary>
-    /// <returns>The current <see cref="TargetDefinition" /> for fluent chaining.</returns>
-    public TargetDefinition ProducesNoArtifacts()
-    {
-        ProducedArtifacts.Clear();
-
-        return this;
-    }
-
     /// <summary>
     ///     Declares an artifact that this target consumes.
     /// </summary>
@@ -377,17 +366,6 @@ public TargetDefinition ConsumesArtifacts(
         return this;
     }
 
-    /// <summary>
-    ///     Clears all consumed artifacts for the current target, ensuring it does not depend on any external artifacts.
-    /// </summary>
-    /// <returns>The current <see cref="TargetDefinition" /> for fluent chaining.</returns>
-    public TargetDefinition ConsumesNoArtifacts()
-    {
-        ConsumedArtifacts.Clear();
-
-        return this;
-    }
-
     /// <summary>
     ///     Declares a variable that this target produces.
     /// </summary>
@@ -403,17 +381,6 @@ public TargetDefinition ProducesVariable(string variableName)
         return this;
     }
 
-    /// <summary>
-    ///     Clears all produced variables for the current target, ensuring it does not produce any variables.
-    /// </summary>
-    /// <returns>The current <see cref="TargetDefinition" /> for fluent chaining.</returns>
-    public TargetDefinition ProducesNoVariables()
-    {
-        ProducedVariables.Clear();
-
-        return this;
-    }
-
     /// <summary>
     ///     Declares a variable that this target consumes.
     /// </summary>
@@ -426,15 +393,4 @@ public TargetDefinition ConsumesVariable(string targetName, string outputName)
 
         return this;
     }
-
-    /// <summary>
-    ///     Clears all consumed variables for the current target, ensuring it does not depend on any external variables.
-    /// </summary>
-    /// <returns>The current <see cref="TargetDefinition" /> for fluent chaining.</returns>
-    public TargetDefinition ConsumesNoVariables()
-    {
-        ConsumedVariables.Clear();
-
-        return this;
-    }
 }

_atom/Targets/IDeployTargets.cs

@@ -37,9 +37,14 @@ await PushPackageToNuget(
 
     Target PushToNugetDevops =>
         d => d
-            .Extends<IDeployTargets>(x => x.PushToNuget)
-            .ConsumesNoArtifacts()
-            .ConsumesArtifact(nameof(IBuildTargets.PackTool), Projects.DecSm_Atom_Tool.Name, DevopsPlatformNames);
+            .DescribedAs("Pushes the packages to Nuget")
+            .RequiresParam(nameof(NugetFeed))
+            .RequiresParam(nameof(NugetApiKey))
+            .ConsumesVariable(nameof(SetupBuildInfo), nameof(BuildId))
+            .ConsumesArtifacts(nameof(IBuildTargets.PackProjects), IBuildTargets.ProjectsToPack)
+            .ConsumesArtifact(nameof(IBuildTargets.PackTool), Projects.DecSm_Atom_Tool.Name, DevopsPlatformNames)
+            .DependsOn(nameof(ITestTargets.TestProjects))
+            .Executes(() => Logger.LogInformation("Simulating push to Nuget feed"));
 
     Target PushToRelease =>
         d => d