Skip to content

Commit fb78f44

Browse files
committed
feat(helm): Valkey: use dedicated service account
1 parent ed981c9 commit fb78f44

File tree

4 files changed

+27
-2
lines changed

4 files changed

+27
-2
lines changed

helm/defectdojo/Chart.yaml

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,4 +34,16 @@ dependencies:
3434
# description: Critical bug
3535
annotations:
3636
artifacthub.io/prerelease: "true"
37-
artifacthub.io/changes: "- kind: changed\n description: Update valkey Docker tag from 0.13.0 to v0.15.0 (_/defect_/Chart.yaml)\n- kind: changed\n description: chore(deps)_ update valkey _ tag from 0.15.0 to v0.15.1 (_/defect_/chart.yaml)\n- kind: changed\n description: chore(deps)_ update gcr.io/cloudsql__/gce_proxy _ tag from 1.37.11 to v1.37.12 (_/defect_/values.yaml)\n- kind: changed\n description: Update valkey Docker tag from 0.15.1 to v0.15.2 (_/defect_/Chart.yaml)\n- kind: changed\n description: Update valkey Docker tag from 0.15.2 to v0.15.3 (_/defect_/Chart.yaml)\n"
37+
artifacthub.io/changes: |
38+
- kind: changed
39+
description: Update valkey Docker tag from 0.13.0 to v0.15.0 (_/defect_/Chart.yaml)
40+
- kind: changed
41+
description: chore(deps)_ update valkey _ tag from 0.15.0 to v0.15.1 (_/defect_/chart.yaml)
42+
- kind: changed
43+
description: chore(deps)_ update gcr.io/cloudsql__/gce_proxy _ tag from 1.37.11 to v1.37.12 (_/defect_/values.yaml)
44+
- kind: changed
45+
description: Update valkey Docker tag from 0.15.1 to v0.15.2 (_/defect_/Chart.yaml)
46+
- kind: changed
47+
description: Update valkey Docker tag from 0.15.2 to v0.15.3 (_/defect_/Chart.yaml)
48+
- kind: added
49+
description: Valkey: use dedicated service account

helm/defectdojo/README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -767,9 +767,10 @@ A Helm chart for Kubernetes to install DefectDojo
767767
| tests.unitTests.resources.requests.cpu | string | `"100m"` | |
768768
| tests.unitTests.resources.requests.memory | string | `"128Mi"` | |
769769
| trackConfig | string | `"disabled"` | Track configuration (trackConfig): will automatically respin application pods in case of config changes detection can be: 1. disabled (default) 2. enabled, enables tracking configuration changes based on SHA256 |
770-
| valkey | object | `{"auth":{"existingSecret":"defectdojo-valkey-specific","existingSecretPasswordKey":"valkey-password","password":""},"enabled":true,"sentinel":{"enabled":false},"service":{"port":6379},"tls":{"enabled":false}}` | For more advance options check the bitnami chart documentation: https://artifacthub.io/packages/helm/cloudpirates-valkey/valkey |
770+
| valkey | object | `{"auth":{"existingSecret":"defectdojo-valkey-specific","existingSecretPasswordKey":"valkey-password","password":""},"enabled":true,"sentinel":{"enabled":false},"service":{"port":6379},"serviceAccount":{"create":true},"tls":{"enabled":false}}` | For more advance options check the bitnami chart documentation: https://artifacthub.io/packages/helm/cloudpirates-valkey/valkey |
771771
| valkey.enabled | bool | `true` | To use an external instance, switch enabled to `false` and set the address in `redisServer` below |
772772
| valkey.service | object | `{"port":6379}` | To use a different port for Redis (default: 6379) |
773+
| valkey.serviceAccount.create | bool | `true` | Autocreate dedicated service account (as part of the best practice) |
773774
| valkey.tls.enabled | bool | `false` | If TLS is enabled, the Redis broker will use the redis:// and optionally mount the certificates from an existing secret. |
774775
| valkeyParams | string | `""` | Parameters attached to the valkey connection string, defaults to "ssl_cert_reqs=optional" if `valkey.tls.enabled` |
775776

helm/defectdojo/values.schema.json

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1500,6 +1500,15 @@
15001500
}
15011501
}
15021502
},
1503+
"serviceAccount": {
1504+
"type": "object",
1505+
"properties": {
1506+
"create": {
1507+
"description": "Autocreate dedicated service account (as part of the best practice)",
1508+
"type": "boolean"
1509+
}
1510+
}
1511+
},
15031512
"tls": {
15041513
"type": "object",
15051514
"properties": {

helm/defectdojo/values.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -652,6 +652,9 @@ valkey:
652652
# certFilename: tls.crt
653653
# certKeyFilename: tls.key
654654
# certCAFilename: ca.crt
655+
serviceAccount:
656+
# -- Autocreate dedicated service account (as part of the best practice)
657+
create: true
655658

656659
# -- To add extra variables not predefined by helm config it is possible to define in extraConfigs block, e.g. below:
657660
# NOTE Do not store any kind of sensitive information inside of it

0 commit comments

Comments
 (0)