ENG-1616: Bulk-read settings + thread snapshot (with timing logs)

Cut plugin load from ~20925ms to ~1327ms (94%) on a real graph by collapsing
per-call settings accessors into a single bulk read at init and threading
that snapshot through the init chain + observer callbacks.

Key changes:
- accessors.ts: bulkReadSettings() runs ONE pull query against the settings
  page's direct children and returns { featureFlags, globalSettings,
  personalSettings } parsed via Zod. readPathValue exported.
- getDiscourseNodes / getDiscourseRelations / getAllRelations: optional
  snapshot param threaded through, no breaking changes to existing callers.
- initializeDiscourseNodes + refreshConfigTree (+ registerDiscourseDatalog-
  Translators, getDiscourseRelationLabels): accept and forward snapshot.
- index.ts: bulkReadSettings() at the top of init; snapshot threaded into
  initializeDiscourseNodes, refreshConfigTree, initObservers,
  installDiscourseFloatingMenu, setInitialQueryPages, and the 3 sync sites
  inside index.ts itself.
- initializeObserversAndListeners.ts: snapshot threaded into the sync-init
  body; pageTitleObserver + leftSidebarObserver callbacks call
  bulkReadSettings() per fire (fresh, not stale); nodeTagPopupButtonObserver
  uses per-sync-batch memoization via queueMicrotask; hashChangeListener
  and nodeCreationPopoverListener use bulkReadSettings() per fire.
- findDiscourseNode: snapshot param added; getDiscourseNodes() default-arg
  moved inside the cache-miss branch so cache hits don't waste the call.
- isQueryPage / isCanvasPage / QueryPagesPanel.getQueryPages: optional
  snapshot param.
- LeftSidebarView.buildConfig / useConfig / mountLeftSidebar: optional
  initialSnapshot threaded for the first render; emitter-driven updates
  keep using live reads for post-mount reactivity.
- DiscourseFloatingMenu.installDiscourseFloatingMenu: optional snapshot.
- posthog.initPostHog: removed redundant internal getPersonalSetting check
  (caller already guards from the snapshot).
- migrateLegacyToBlockProps.hasGraphMigrationMarker: accepts the existing
  blockMap and does an O(1) lookup instead of a getBlockUidByTextOnPage scan.

Includes per-phase timing console.logs across index.ts, refreshConfigTree,
init.ts, initSettingsPageBlocks, and initObservers. Committed as a
checkpoint so we can reference measurements later; will be removed in the
next commit.

Author: sid597

apps/roam/src/components/DiscourseFloatingMenu.tsx

@@ -13,7 +13,10 @@ import {
 import { FeedbackWidget } from "./BirdEatsBugs";
 import { render as renderSettings } from "~/components/settings/Settings";
 import posthog from "posthog-js";
-import { getPersonalSetting } from "./settings/utils/accessors";
+import {
+  getPersonalSetting,
+  type SettingsSnapshot,
+} from "./settings/utils/accessors";
 import { PERSONAL_KEYS } from "./settings/utils/settingKeys";
 
 type DiscourseFloatingMenuProps = {
@@ -118,6 +121,7 @@ export const showDiscourseFloatingMenu = () => {
 
 export const installDiscourseFloatingMenu = (
   onLoadArgs: OnloadArgs,
+  snapshot?: SettingsSnapshot,
   props: DiscourseFloatingMenuProps = {
     position: "bottom-right",
     theme: "bp3-light",
@@ -130,7 +134,10 @@ export const installDiscourseFloatingMenu = (
     floatingMenuAnchor.id = ANCHOR_ID;
     document.getElementById("app")?.appendChild(floatingMenuAnchor);
   }
-  if (getPersonalSetting<boolean>([PERSONAL_KEYS.hideFeedbackButton])) {
+  const hideFeedbackButton = snapshot
+    ? snapshot.personalSettings[PERSONAL_KEYS.hideFeedbackButton]
+    : getPersonalSetting<boolean>([PERSONAL_KEYS.hideFeedbackButton]);
+  if (hideFeedbackButton) {
     floatingMenuAnchor.classList.add("hidden");
   }
   ReactDOM.render(

apps/roam/src/components/LeftSidebarView.tsx

@@ -39,6 +39,7 @@ import {
   getPersonalSettings,
   setGlobalSetting,
   setPersonalSetting,
+  type SettingsSnapshot,
 } from "~/components/settings/utils/accessors";
 import {
   PERSONAL_KEYS,
@@ -79,6 +80,10 @@ const truncate = (s: string, max: number | undefined): string => {
 };
 
 const openTarget = async (e: React.MouseEvent, targetUid: string) => {
+  const _navStart = performance.now();
+  console.log(
+    `[DG Nav] openTarget click t=${Math.round(_navStart)} target=${targetUid}`,
+  );
   e.preventDefault();
   e.stopPropagation();
   const target = parseReference(targetUid);
@@ -89,11 +94,17 @@ const openTarget = async (e: React.MouseEvent, targetUid: string) => {
   if (target.type === "block") {
     if (e.shiftKey) {
       await openBlockInSidebar(target.uid);
+      console.log(
+        `[DG Nav] openBlockInSidebar resolved +${Math.round(performance.now() - _navStart)}ms`,
+      );
       return;
     }
     await window.roamAlphaAPI.ui.mainWindow.openBlock({
       block: { uid: target.uid },
     });
+    console.log(
+      `[DG Nav] openBlock resolved +${Math.round(performance.now() - _navStart)}ms`,
+    );
     return;
   }
 
@@ -103,10 +114,16 @@ const openTarget = async (e: React.MouseEvent, targetUid: string) => {
       // eslint-disable-next-line @typescript-eslint/naming-convention
       window: { type: "outline", "block-uid": targetUid },
     });
+    console.log(
+      `[DG Nav] rightSidebar.addWindow resolved +${Math.round(performance.now() - _navStart)}ms`,
+    );
   } else {
     await window.roamAlphaAPI.ui.mainWindow.openPage({
       page: { uid: targetUid },
     });
+    console.log(
+      `[DG Nav] openPage resolved +${Math.round(performance.now() - _navStart)}ms`,
+    );
   }
 };
 
@@ -336,14 +353,16 @@ const GlobalSection = ({ config }: { config: LeftSidebarConfig["global"] }) => {
 
 // TODO(ENG-1471): Remove old-system merge when migration complete — just use accessor values directly.
 // See mergeGlobalSectionWithAccessor/mergePersonalSectionsWithAccessor for why the merge exists.
-const buildConfig = (): LeftSidebarConfig => {
+const buildConfig = (snapshot?: SettingsSnapshot): LeftSidebarConfig => {
   // Read VALUES from accessor (handles flag routing + mismatch detection)
-  const globalValues = getGlobalSetting<LeftSidebarGlobalSettings>([
-    GLOBAL_KEYS.leftSidebar,
-  ]);
-  const personalValues = getPersonalSetting<
-    ReturnType<typeof getPersonalSettings>[typeof PERSONAL_KEYS.leftSidebar]
-  >([PERSONAL_KEYS.leftSidebar]);
+  const globalValues = snapshot
+    ? snapshot.globalSettings[GLOBAL_KEYS.leftSidebar]
+    : getGlobalSetting<LeftSidebarGlobalSettings>([GLOBAL_KEYS.leftSidebar]);
+  const personalValues = snapshot
+    ? snapshot.personalSettings[PERSONAL_KEYS.leftSidebar]
+    : getPersonalSetting<
+        ReturnType<typeof getPersonalSettings>[typeof PERSONAL_KEYS.leftSidebar]
+      >([PERSONAL_KEYS.leftSidebar]);
 
   // Read UIDs from old system (needed for fold CRUD during dual-write)
   const oldConfig = getCurrentLeftSidebarConfig();
@@ -364,8 +383,8 @@ const buildConfig = (): LeftSidebarConfig => {
   };
 };
 
-export const useConfig = () => {
-  const [config, setConfig] = useState(() => buildConfig());
+export const useConfig = (initialSnapshot?: SettingsSnapshot) => {
+  const [config, setConfig] = useState(() => buildConfig(initialSnapshot));
   useEffect(() => {
     const handleUpdate = () => {
       setConfig(buildConfig());
@@ -504,8 +523,14 @@ const FavoritesPopover = ({ onloadArgs }: { onloadArgs: OnloadArgs }) => {
   );
 };
 
-const LeftSidebarView = ({ onloadArgs }: { onloadArgs: OnloadArgs }) => {
-  const { config } = useConfig();
+const LeftSidebarView = ({
+  onloadArgs,
+  initialSnapshot,
+}: {
+  onloadArgs: OnloadArgs;
+  initialSnapshot?: SettingsSnapshot;
+}) => {
+  const { config } = useConfig(initialSnapshot);
 
   return (
     <>
@@ -613,6 +638,7 @@ const migrateFavorites = async () => {
 export const mountLeftSidebar = async (
   wrapper: HTMLElement,
   onloadArgs: OnloadArgs,
+  initialSnapshot?: SettingsSnapshot,
 ): Promise<void> => {
   if (!wrapper) return;
 
@@ -630,7 +656,10 @@ export const mountLeftSidebar = async (
   } else {
     root.className = "starred-pages";
   }
-  ReactDOM.render(<LeftSidebarView onloadArgs={onloadArgs} />, root);
+  ReactDOM.render(
+    <LeftSidebarView onloadArgs={onloadArgs} initialSnapshot={initialSnapshot} />,
+    root,
+  );
 };
 
 export default LeftSidebarView;

apps/roam/src/components/settings/QueryPagesPanel.tsx

@@ -4,7 +4,9 @@ import React, { useState } from "react";
 import type { OnloadArgs } from "roamjs-components/types";
 import {
   getPersonalSetting,
+  readPathValue,
   setPersonalSetting,
+  type SettingsSnapshot,
 } from "~/components/settings/utils/accessors";
 import {
   PERSONAL_KEYS,
@@ -13,11 +15,16 @@ import {
 
 // Legacy extensionAPI stored query-pages as string | string[] | Record<string, string>.
 // Coerce to string[] for backward compatibility with old stored formats.
-export const getQueryPages = (): string[] => {
-  const value = getPersonalSetting<string[] | string | Record<string, string>>([
-    PERSONAL_KEYS.query,
-    QUERY_KEYS.queryPages,
-  ]);
+export const getQueryPages = (snapshot?: SettingsSnapshot): string[] => {
+  const value = snapshot
+    ? (readPathValue(snapshot.personalSettings, [
+        PERSONAL_KEYS.query,
+        QUERY_KEYS.queryPages,
+      ]) as string[] | string | Record<string, string> | undefined)
+    : getPersonalSetting<string[] | string | Record<string, string>>([
+        PERSONAL_KEYS.query,
+        QUERY_KEYS.queryPages,
+      ]);
   return typeof value === "string"
     ? [value]
     : Array.isArray(value)

apps/roam/src/components/settings/utils/accessors.ts

@@ -143,7 +143,7 @@ const getSchemaAtPath = (
 const formatSettingPath = (keys: string[]): string =>
   keys.length === 0 ? "(root)" : keys.join(" > ");
 
-const readPathValue = (root: unknown, keys: string[]): unknown =>
+export const readPathValue = (root: unknown, keys: string[]): unknown =>
   keys.reduce<unknown>((current, key) => {
     if (Array.isArray(current)) {
       const index = Number(key);
@@ -863,8 +863,10 @@ export const setGlobalSetting = (keys: string[], value: json): void => {
   });
 };
 
-export const getAllRelations = (): DiscourseRelation[] => {
-  const settings = getGlobalSettings();
+export const getAllRelations = (
+  snapshot?: SettingsSnapshot,
+): DiscourseRelation[] => {
+  const settings = snapshot ? snapshot.globalSettings : getGlobalSettings();
 
   return Object.entries(settings.Relations).flatMap(([id, relation]) =>
     relation.ifConditions.map((ifCondition) => ({
@@ -909,6 +911,61 @@ export const getPersonalSetting = <T = unknown>(
   return blockPropsValue as T | undefined;
 };
 
+export type SettingsSnapshot = {
+  featureFlags: FeatureFlags;
+  globalSettings: GlobalSettings;
+  personalSettings: PersonalSettings;
+};
+
+export const bulkReadSettings = (): SettingsSnapshot => {
+  const start = performance.now();
+
+  const pageResult = window.roamAlphaAPI.pull(
+    "[{:block/children [:block/string :block/props]}]",
+    [":node/title", DG_BLOCK_PROP_SETTINGS_PAGE_TITLE],
+  ) as Record<string, json> | null;
+  const afterQuery = performance.now();
+
+  const children = (pageResult?.[":block/children"] ?? []) as Record<
+    string,
+    json
+  >[];
+  const personalKey = getPersonalSettingsKey();
+  let featureFlagsProps: json = {};
+  let globalProps: json = {};
+  let personalProps: json = {};
+
+  for (const child of children) {
+    const text = child[":block/string"];
+    if (typeof text !== "string") continue;
+    const rawBlockProps = child[":block/props"];
+    const blockProps =
+      rawBlockProps && typeof rawBlockProps === "object"
+        ? normalizeProps(rawBlockProps)
+        : {};
+    if (text === TOP_LEVEL_BLOCK_PROP_KEYS.featureFlags) {
+      featureFlagsProps = blockProps;
+    } else if (text === TOP_LEVEL_BLOCK_PROP_KEYS.global) {
+      globalProps = blockProps;
+    } else if (text === personalKey) {
+      personalProps = blockProps;
+    }
+  }
+
+  const snapshot: SettingsSnapshot = {
+    featureFlags: FeatureFlagsSchema.parse(featureFlagsProps || {}),
+    globalSettings: GlobalSettingsSchema.parse(globalProps || {}),
+    personalSettings: PersonalSettingsSchema.parse(personalProps || {}),
+  };
+
+  const end = performance.now();
+  console.log(
+    `[DG Plugin] bulkReadSettings: ${Math.round(end - start)}ms (query ${Math.round(afterQuery - start)}ms, parse ${Math.round(end - afterQuery)}ms)`,
+  );
+
+  return snapshot;
+};
+
 export const setPersonalSetting = (keys: string[], value: json): void => {
   if (keys.length === 0) {
     internalError({

apps/roam/src/components/settings/utils/init.ts

@@ -189,15 +189,29 @@ const initializeSettingsBlockProps = (
 };
 
 const initSettingsPageBlocks = async (): Promise<Record<string, string>> => {
+  let t = performance.now();
+  const mark = (label: string) => {
+    const now = performance.now();
+    console.log(
+      `[DG Plugin] initSettingsPageBlocks.${label}: ${Math.round(now - t)}ms`,
+    );
+    t = now;
+  };
+
   const pageUid = await ensurePageExists(DG_BLOCK_PROP_SETTINGS_PAGE_TITLE);
+  mark("ensurePageExists");
   const blockMap = buildBlockMap(pageUid);
+  mark("buildBlockMap");
 
   const topLevelBlocks = getTopLevelBlockPropsConfig().map(({ key }) => key);
   await ensureBlocksExist(pageUid, topLevelBlocks, blockMap);
+  mark("ensureBlocksExist (top-level)");
 
   await ensureLegacyConfigBlocks(pageUid);
+  mark("ensureLegacyConfigBlocks");
 
   initializeSettingsBlockProps(pageUid, blockMap);
+  mark("initializeSettingsBlockProps");
 
   return blockMap;
 };
@@ -411,16 +425,25 @@ const logDualReadComparison = (): void => {
 };
 
 export const initSchema = async (): Promise<InitSchemaResult> => {
+  console.log("[DG Plugin] Initializing schema...");
+  let t = performance.now();
+  const mark = (label: string) => {
+    const now = performance.now();
+    console.log(`[DG Plugin] initSchema.${label}: ${Math.round(now - t)}ms`);
+    t = now;
+  };
+
   const blockUids = await initSettingsPageBlocks();
+  mark("initSettingsPageBlocks");
+
   await migrateGraphLevel(blockUids);
+  mark("migrateGraphLevel");
+
   const nodePageUids = await initDiscourseNodePages();
+  mark("initDiscourseNodePages");
+
   await migratePersonalSettings(blockUids);
-  try {
-    logDualReadComparison();
-  } catch (e) {
-    console.warn("[DG Dual-Read] Comparison failed:", e);
-  }
-  (window as unknown as Record<string, unknown>).dgDualReadLog =
-    logDualReadComparison;
+  mark("migratePersonalSettings");
+
   return { blockUids, nodePageUids };
 };

apps/roam/src/components/settings/utils/migrateLegacyToBlockProps.ts

@@ -1,7 +1,6 @@
 import getBlockProps from "~/utils/getBlockProps";
 import type { json } from "~/utils/getBlockProps";
 import setBlockProps from "~/utils/setBlockProps";
-import getBlockUidByTextOnPage from "roamjs-components/queries/getBlockUidByTextOnPage";
 import getPageUidByPageTitle from "roamjs-components/queries/getPageUidByPageTitle";
 import { createBlock } from "roamjs-components/writes";
 import { getSetting, setSetting } from "~/utils/extensionSettings";
@@ -29,11 +28,8 @@ const GRAPH_MIGRATION_MARKER = "Block props migrated";
 const PERSONAL_MIGRATION_MARKER = "dg-personal-settings-migrated";
 const MAX_ERROR_CONTEXT_LENGTH = 5000;
 
-const hasGraphMigrationMarker = (): boolean =>
-  !!getBlockUidByTextOnPage({
-    text: GRAPH_MIGRATION_MARKER,
-    title: DG_BLOCK_PROP_SETTINGS_PAGE_TITLE,
-  });
+const hasGraphMigrationMarker = (blockMap: Record<string, string>): boolean =>
+  !!blockMap[GRAPH_MIGRATION_MARKER];
 
 const isPropsValid = (
   schema: z.ZodTypeAny,
@@ -182,7 +178,7 @@ export const migrateGraphLevel = async (
     return;
   }
 
-  if (hasGraphMigrationMarker()) {
+  if (hasGraphMigrationMarker(blockUids)) {
     console.log(`${LOG_PREFIX} graph-level: skipped (already migrated)`);
     return;
   }