Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

Cherry pick fixes develop#682

Merged
larryk85 merged 8 commits into
developfrom
cherry_pick_fixes_develop
Sep 27, 2019
Merged

Cherry pick fixes develop#682
larryk85 merged 8 commits into
developfrom
cherry_pick_fixes_develop

Conversation

@larryk85
Copy link
Copy Markdown
Contributor

Change Description

Cherry-pick fixes from release/1.6.x to develop

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

`add_struct` enforces parsing its base as struct, and it causes segfault
when inheriting from the std types. This patch mitigates this issue
by allowing add_struct to call add_type for its base, but generated ABI is
still not usable, because chain::abi_serializer requires struct base to
be struct type. There is a workaround fix making it work by trick, but
ultimately it needs consensus upgrade.

#541
@larryk85 larryk85 requested a review from arhag September 27, 2019 21:18
@larryk85 larryk85 merged commit 72cbc2b into develop Sep 27, 2019
@larryk85 larryk85 deleted the cherry_pick_fixes_develop branch September 27, 2019 23:04
rise-worlds pushed a commit to potato-coin/eosio.cdt that referenced this pull request Jul 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants