remove dependency on servlet API (use case where not needed) (#776)

* remove dependency on servlet API for a specif use case where not needed

* fix typo in unit test

Author: Joseph Witthuhn

src/main/java/org/owasp/esapi/logging/appender/ServerInfoSupplier.java

@@ -51,9 +51,11 @@ public ServerInfoSupplier(String logName) {
     public String get() {
         // log server, port, app name, module name -- server:80/app/module
         StringBuilder appInfo = new StringBuilder();
-        HttpServletRequest request = ESAPI.currentRequest();
-        if (request != null && logServerIP) {
-            appInfo.append(request.getLocalAddr()).append(":").append(request.getLocalPort());
+        if (logServerIP) {
+            HttpServletRequest request = ESAPI.currentRequest();
+            if (request != null) {
+                appInfo.append(request.getLocalAddr()).append(":").append(request.getLocalPort());
+            }
         }
         if (logAppName) {
             appInfo.append("/").append(applicationName);

src/test/java/org/owasp/esapi/logging/appender/ServerInfoSupplierTest.java

@@ -25,14 +25,14 @@ public class ServerInfoSupplierTest {
     private HttpServletRequest request;
 
     @Before
-    public void buildStaticMocks() throws Exception {
+    public void buildStaticMocks() {
         request = mock(HttpServletRequest.class);
         mockStatic(ESAPI.class);
-        when(ESAPI.class, "currentRequest").thenReturn(request);
     }
 
     @Test
-    public void verifyFullOutput() {
+    public void verifyFullOutput() throws Exception {
+        when(ESAPI.class, "currentRequest").thenReturn(request);
         when(request.getLocalAddr()).thenReturn("LOCAL_ADDR");
         when(request.getLocalPort()).thenReturn(99999);
 
@@ -57,7 +57,8 @@ public void verifyOutputNullRequest() throws Exception {
     }
 
     @Test
-    public void verifyOutputNoAppName() {
+    public void verifyOutputNoAppName() throws Exception {
+        when(ESAPI.class, "currentRequest").thenReturn(request);
         when(request.getLocalAddr()).thenReturn("LOCAL_ADDR");
         when(request.getLocalPort()).thenReturn(99999);
 
@@ -70,7 +71,8 @@ public void verifyOutputNoAppName() {
     }
 
     @Test
-    public void verifyOutputNullAppName() {
+    public void verifyOutputNullAppName() throws Exception {
+        when(ESAPI.class, "currentRequest").thenReturn(request);
         when(request.getLocalAddr()).thenReturn("LOCAL_ADDR");
         when(request.getLocalPort()).thenReturn(99999);