Add function to apply conversion rules to generated markdown links#55
Add function to apply conversion rules to generated markdown links#55nusbaume merged 3 commits intoESCOMP:mainfrom
Conversation
nusbaume
requested review from
cacraigucar,
climbfuji,
grantfirl and
mkavulich
|
Please note that these test failures should be fixed once PR #52 has been accepted and merged (both into main and my branch). |
mkavulich
left a comment
mkavulich
left a comment
There was a problem hiding this comment.
Looks good! Just had one question.
| link_str = text_str.strip() | ||
|
|
||
| #Next, make sure all text is lowercase: | ||
| link_str = link_str.lower() |
There was a problem hiding this comment.
Is this check necessary? It appears as if the old links with capital letters still work in the web view, but maybe there's another markdown reader where it doesn't work?
There was a problem hiding this comment.
That's a good question! After doing some experimentation it looks like at least my web browser (Chrome) is able to use a URL with uppercase text correctly, but I think "under the hood" the actual link is still all lowercase. You can see this if you go to to one of the section heads in the markdown document itself and then click on the the little chain symbol that pops up next to it.
So, I am happy to remove this text conversion if that is preferred by you or others, but I personally think keeping everything lowercase will be the safest option in the long run. Of course please let me know if you disagree!
There was a problem hiding this comment.
It's fine to leave the check in, I was just curious if it was causing issues.
mkavulich
added
the
needs discussion
nusbaume
removed
the
needs discussion
|
@mkavulich I removed the "needs discussion" label on this PR because I think you meant to add it to PR #56 instead based off of my memory of Monday's framework meeting discussions. However, if I am wrong here then feel free to add the label back. Thanks! |
|
@nusbaume Yes, you're right I applied the label to the wrong PR. Thanks for fixing that! |
3 participants
This PR adds a function to apply header text conversion rules when generating internal markdown document links.
Fixes #54