Skip to content

Commit 82403f6

Browse files
committed
Revert "refactor: update createResultQuery to utilize TResult generic and improve type extraction from Result"
This reverts commit 8cf582b.
1 parent f728f4d commit 82403f6

1 file changed

Lines changed: 18 additions & 17 deletions

File tree

packages/svelte-query/src/createQuery.ts

Lines changed: 18 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,24 @@
1-
import { isErr } from '@epicenterhq/result';
2-
import { QueryObserver, skipToken } from '@tanstack/query-core';
3-
import { createBaseQuery } from './createBaseQuery.svelte.js';
1+
import { isErr } from '@epicenterhq/result'
2+
import { QueryObserver, skipToken } from '@tanstack/query-core'
3+
import { createBaseQuery } from './createBaseQuery.svelte.js'
4+
import type { Result } from '@epicenterhq/result'
45
import type {
56
DefaultError,
67
QueryClient,
78
QueryFunction,
89
QueryKey,
910
SkipToken,
10-
} from '@tanstack/query-core';
11-
import type { ExtractErrFromResult, ExtractOkFromResult, Result } from '@epicenterhq/result';
12-
import type {
13-
DefinedInitialDataOptions,
14-
UndefinedInitialDataOptions,
15-
} from './queryOptions.js';
11+
} from '@tanstack/query-core'
1612
import type {
1713
Accessor,
1814
CreateQueryOptions,
1915
CreateQueryResult,
2016
DefinedCreateQueryResult,
21-
} from './types.js';
17+
} from './types.js'
18+
import type {
19+
DefinedInitialDataOptions,
20+
UndefinedInitialDataOptions,
21+
} from './queryOptions.js'
2222

2323
export function createQuery<
2424
TQueryFnData = unknown,
@@ -62,23 +62,24 @@ export function createQuery(
6262
}
6363

6464
export function createResultQuery<
65-
TResult extends Result<unknown, unknown> = Result<unknown, DefaultError>,
66-
TData = ExtractOkFromResult<TResult>,
65+
TQueryFnData = unknown,
66+
TError = DefaultError,
67+
TData = TQueryFnData,
6768
TQueryKey extends QueryKey = QueryKey,
6869
>(
6970
options: Accessor<
7071
Omit<
71-
CreateQueryOptions<ExtractOkFromResult<TResult>, ExtractErrFromResult<TResult>, TData, TQueryKey>,
72+
CreateQueryOptions<TQueryFnData, TError, TData, TQueryKey>,
7273
'queryFn'
7374
> & {
7475
queryFn?:
75-
| QueryFunction<TResult, TQueryKey>
76+
| QueryFunction<Result<TQueryFnData, TError>, TQueryKey>
7677
| SkipToken
7778
}
7879
>,
7980
queryClient?: Accessor<QueryClient>,
8081
) {
81-
return createQuery<ExtractOkFromResult<TResult>, ExtractErrFromResult<TResult>, TData, TQueryKey>(() => {
82+
return createQuery<TQueryFnData, TError, TData, TQueryKey>(() => {
8283
const { queryFn, ...optionValues } = options()
8384
if (queryFn === undefined || queryFn === skipToken) {
8485
return { ...optionValues, queryFn }
@@ -87,8 +88,8 @@ export function createResultQuery<
8788
...optionValues,
8889
queryFn: async (...args) => {
8990
const result = await queryFn(...args)
90-
if (isErr(result)) throw result.error as ExtractErrFromResult<TResult>
91-
return result.data as ExtractOkFromResult<TResult>
91+
if (isErr(result)) throw result.error
92+
return result.data
9293
},
9394
}
9495
}, queryClient)

0 commit comments

Comments
 (0)