Support comma as decimal separator in odometer input

normalizeOdometerText now converts commas to periods so both "."
and "," work as decimal input in any locale. When this produces
multiple decimal points (from group separators that became dots),
only the last dot is kept as the decimal separator. This preserves
correct handling of German "1.234,5" → "1234.5" and English
"1,234.5" → "1234.5" while also allowing English "123,4" → "123.4".

Co-authored-by: Chavda Sachin <ChavdaSachin@users.noreply.github.com>

Author: MelvinBot

src/libs/DistanceRequestUtils.ts

@@ -474,15 +474,24 @@ function isDistanceAmountWithinLimit(distance: number, rate: number): boolean {
  * Normalize odometer text by standardizing locale digits and stripping all
  * non-numeric characters except the decimal point. fromLocaleDigit converts
  * each locale character to its standard equivalent (e.g. German ',' → '.'
- * for decimal, German '.' → ',' for group separator), then we keep only
- * digits and the standard decimal point.
+ * for decimal, German '.' → ',' for group separator). Commas are then
+ * treated as decimal separators so both "." and "," work as decimal input
+ * in any locale. If this produces multiple decimal points (from group
+ * separators that became dots), only the last dot is kept as the decimal.
+ * Finally we keep only digits and the standard decimal point.
  */
 function normalizeOdometerText(text: string, fromLocaleDigit: (char: string) => string): string {
     const standardized = replaceAllDigits(text, fromLocaleDigit);
-    const stripped = standardized.replaceAll(/[^0-9.]/g, '');
+    // Treat commas as decimal separators so both "." and "," work as decimal input
+    const withCommasAsDecimals = standardized.replaceAll(',', '.');
+    const stripped = withCommasAsDecimals.replaceAll(/[^0-9.]/g, '');
+    // If multiple decimal points exist (e.g. from group separators that became
+    // dots), keep only the last one as the actual decimal separator.
+    const dotParts = stripped.split('.');
+    const consolidated = dotParts.length > 2 ? dotParts.slice(0, -1).join('') + '.' + (dotParts.at(-1) ?? '') : stripped;
     // Remove redundant leading zeroes (e.g. "007" → "7", "000" → "0") but
     // keep a single zero before a decimal point (e.g. "0.5" stays "0.5").
-    return stripped.replace(/^0+(?=\d)/, '');
+    return consolidated.replace(/^0+(?=\d)/, '');
 }
 
 export default {

tests/unit/OdometerNormalizationTest.ts

@@ -9,8 +9,8 @@ describe('normalizeOdometerText', () => {
             expect(DistanceRequestUtils.normalizeOdometerText('1,5', germanFromLocaleDigit)).toBe('1.5');
         });
 
-        it("German '1.5' (fifteen, dot is group separator) normalizes to '15'", () => {
-            expect(DistanceRequestUtils.normalizeOdometerText('1.5', germanFromLocaleDigit)).toBe('15');
+        it("German '1.5' (dot now treated as decimal) normalizes to '1.5'", () => {
+            expect(DistanceRequestUtils.normalizeOdometerText('1.5', germanFromLocaleDigit)).toBe('1.5');
         });
 
         it("German '1.234,5' (1234.5) normalizes to '1234.5'", () => {
@@ -38,6 +38,28 @@ describe('normalizeOdometerText', () => {
         });
     });
 
+    describe('comma as decimal separator', () => {
+        const englishFromLocaleDigit = (char: string) => fromLocaleDigit('en', char);
+        const germanFromLocaleDigit = (char: string) => fromLocaleDigit('de', char);
+
+        it("English '123,4' (comma as decimal) normalizes to '123.4'", () => {
+            expect(DistanceRequestUtils.normalizeOdometerText('123,4', englishFromLocaleDigit)).toBe('123.4');
+        });
+
+        it("English '1,234.5' (comma as group with dot decimal) normalizes to '1234.5'", () => {
+            expect(DistanceRequestUtils.normalizeOdometerText('1,234.5', englishFromLocaleDigit)).toBe('1234.5');
+        });
+
+        it("German '1.234,5' (dot-group, comma-decimal) normalizes to '1234.5'", () => {
+            expect(DistanceRequestUtils.normalizeOdometerText('1.234,5', germanFromLocaleDigit)).toBe('1234.5');
+        });
+
+        it("plain comma only: ',5' normalizes to '.5'", () => {
+            const identity = (char: string) => char;
+            expect(DistanceRequestUtils.normalizeOdometerText(',5', identity)).toBe('.5');
+        });
+    });
+
     describe('leading zeroes', () => {
         const identity = (char: string) => char;