Manual expense flow UI refactor r1 by ChavdaSachin · Pull Request #83695 · Expensify/App

ChavdaSachin · 2026-02-27T14:14:50Z

Explanation of Change

Fixed Issues

$ #82586
PROPOSAL:

Tests

Same as QA.

Verify that no errors appear in the JS console

Offline tests

Same as QA.

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Test using Expensifail account.

Open the App.
Clock FAB -> Manual.
Complete the steps to reach the confirmation page.
Verify confirmation page has inline text input for the field Amount.
Verify amount is editable.
Verify currency select button and the currency picker are working as expected.
Clear the amount value and click create expense, Verify Field required error is visible.
On small screens: Verify sign flip button is visible and working as expected.
Enter an amount value and click create expense, Verify IOU created is of correct value.
Repeat Step 3-9 for Track Distance -> Map /Manual/Odometer

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-03-16.at.5.30.47.PM.mov

Android: mWeb Chrome

iOS: Native

Uploading Screen Recording 2026-03-16 at 5.37.10 PM.mov…

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-03-16.at.5.23.27.PM.mov

melvin-bot · 2026-03-09T04:23:55Z

@ShridharGoel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ChavdaSachin · 2026-03-09T04:31:29Z

Could someone please trigger an ad-hoc build and request applause for testing?

This PR implemented inline input for IOU field - Amount, on IOU confirmation page.

cc. @JmillsExpensify @puneetlath

ChavdaSachin · 2026-03-09T04:34:57Z

ps. I'd recommit everything with meaningful messages once the component is confirmed to be working as expected.

trjExpensify · 2026-03-09T15:13:29Z

@ChavdaSachin can you fix that conflict?

github-actions · 2026-03-09T17:19:46Z

🚧 @puneetlath has triggered a test Expensify/App build. You can view the workflow run here.

ChavdaSachin · 2026-03-10T16:28:00Z

Applause was asked to test this PR right?

ShridharGoel · 2026-03-10T18:15:27Z

Screen.Recording.2026-03-10.at.11.44.53.PM.mov

ShridharGoel · 2026-03-10T18:16:58Z

@ChavdaSachin Can you add the description and testing steps and also mention that this only handles the amount field?

ChavdaSachin · 2026-03-10T18:38:22Z

@ChavdaSachin Can you add the description and testing steps and also mention that this only handles the amount field?

Sure.

@ShridharGoel for the recording video you posted, is there any bug you want to highlight?
As I see it working as expected.

ShridharGoel · 2026-03-10T18:41:46Z

for the recording video you posted, is there any bug you want to highlight?

No, it was just for showing the flow so that others can have a look since screenshots/videos were not there in the description.

puneetlath · 2026-03-10T18:48:20Z

Applause was asked to test this PR right?

Not that I'm aware of. Given that this is behind a beta, can we ask them to test on staging? Or do you think there's some risk in spite of the beta?

JmillsExpensify · 2026-03-10T22:56:53Z

How do I get on the beta for this PR?

ChavdaSachin · 2026-03-11T16:34:19Z

@JmillsExpensify you could run following command in console

Onyx.merge('betas', ['newManualExpenseFlow']);

To open console: press f12 button in browser, and find the console tab from the navbar of newly opened browser tools section

ChavdaSachin · 2026-03-11T16:37:17Z

Not that I'm aware of. Given that this is behind a beta, can we ask them to test on staging? Or do you think there's some risk in spite of the beta?

Then please ask them to test, as this PR would tough some core functions as well, which may have side effects.

And just to make sure - @puneetlath the expensifail accounts by default have beta key 'all' added right?

JmillsExpensify · 2026-03-11T23:23:54Z

Thanks! It's not working for me though.

ShridharGoel · 2026-03-12T01:44:16Z

Thanks! It's not working for me though.

Are you doing it on 83695.pr-testing.expensify.com ?

ChavdaSachin · 2026-03-23T00:51:59Z

Changes are up, ready for review.

cc. @ShridharGoel @puneetlath

puneetlath · 2026-03-23T15:08:08Z

@ShridharGoel can you please prioritize another round of review today?

ShridharGoel · 2026-03-23T17:22:01Z

Bug: Expense can be created without any amount instead of showing an error, after the amount is cleared in the inline field. This is because the draft amount is not cleared in handleAmountChange().

Screen.Recording.2026-03-23.at.10.50.47.PM.mov

ChavdaSachin · 2026-03-23T20:19:25Z

@ShridharGoel good catch, this bug would be handled in the final PR, if I would patch it up now it's highly likely we might not need those changes during final phase and end up reverting.

ShridharGoel · 2026-03-24T14:33:14Z

Would it be good to add "NoQA" here and get it tested once the whole feature is done?

puneetlath · 2026-03-24T14:36:04Z

Yes, I think that makes sense.

puneetlath

Two super minor comments. Can we address and merge today?

src/components/MoneyRequestConfirmationListFooter.tsx

ChavdaSachin · 2026-03-24T17:01:25Z

@puneetlath I did not add the GH comment link to the code. As To Do list on the parent issue should be self sufficient for the future references.

Ready to merge.

github-actions · 2026-03-24T17:55:14Z

🚧 @puneetlath has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-24T18:00:29Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83695.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-b05f115-55a46af-7db938231a0f59ee3d50848d99e6874f888a1e76/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-b05f115-55a46af-fb1389cfddb6fb506430e1d76f0ac286e8f55fd9/index.html

Web 🕸️
https://83695.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-24T18:03:38Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-03-25T16:39:00Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.3.44-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

nlemma · 2026-03-25T18:14:47Z

Deploy Blocker #86342 was identified to be related to this PR.

jponikarchuk · 2026-03-25T18:25:22Z

Deploy Blocker #86343 was identified to be related to this PR.

jponikarchuk · 2026-03-25T18:30:44Z

This PR failing because of the issue #86343
This issue is reproducible in: Web

PR Expensify#83695 added isNewManualExpenseFlowEnabled guards that suppressed the amount from the Create/Track button text, but the Split button was not modified — causing an inconsistency where Split shows the amount but Create does not. Remove the isNewManualExpenseFlowEnabled conditions from the button text logic so the Create button always shows the amount (e.g. "Create $500.00 expense") regardless of the flow, consistent with the Split button behavior. Fixes Expensify#86342

OSBotify · 2026-03-25T18:51:15Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.3.47-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

jponikarchuk · 2026-03-26T05:19:44Z

Deploy Blocker #86394 was identified to be related to this PR.

ShridharGoel · 2026-03-26T12:35:29Z

We didn't add NoQA here? #83695 (comment)

OSBotify · 2026-03-26T14:16:36Z

🚀 Deployed to production by https://github.com/grgia in version: 9.3.48-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

ChavdaSachin added 2 commits February 27, 2026 18:23

Add beta

58451eb

replace amount pushROw with inline input

bc70131

melvin-bot bot assigned ChavdaSachin Feb 27, 2026

IOU confirmation - amount - replace push row with inline input

88fa1f4

ChavdaSachin marked this pull request as ready for review March 9, 2026 04:23

ChavdaSachin requested review from a team as code owners March 9, 2026 04:23

melvin-bot bot requested review from JmillsExpensify and ShridharGoel and removed request for a team March 9, 2026 04:23

melvin-bot bot removed the request for review from a team March 9, 2026 04:23

merge main

f0320cd

This comment has been minimized.

Sign in to view

Add support for other expense types

b0982e0

ShridharGoel approved these changes Mar 23, 2026

View reviewed changes

melvin-bot bot requested a review from puneetlath March 23, 2026 21:23

puneetlath reviewed Mar 24, 2026

View reviewed changes

src/components/MoneyRequestConfirmationListFooter.tsx Show resolved Hide resolved

src/components/MoneyRequestConfirmationListFooter.tsx Show resolved Hide resolved

puneetlath approved these changes Mar 24, 2026

View reviewed changes

puneetlath merged commit b05f115 into Expensify:main Mar 24, 2026
39 checks passed

OSBotify mentioned this pull request Mar 25, 2026

Deploy Checklist: New Expensify 2026-03-25 #86329

Closed

71 tasks

This was referenced Mar 25, 2026

Create button does not show amount in workspace expense, but shows amount when splitting #86342

Open

Replace push rows with inline text inputs in manual expense create/edit flow #82586

Open

jponikarchuk mentioned this pull request Mar 25, 2026

Expense - Expense created with an empty amount field #86343

Open

7 tasks

lanitochka17 mentioned this pull request Mar 25, 2026

Split expense - Expense cannot be split despite having amount on amount field #86351

Open

7 tasks

jponikarchuk mentioned this pull request Mar 26, 2026

Android & iOS - Expense - Amount field shows flip button on confirm page #86394

Open

7 tasks

Conversation

ChavdaSachin commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 9, 2026

Uh oh!

ChavdaSachin commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ChavdaSachin commented Mar 9, 2026

Uh oh!

trjExpensify commented Mar 9, 2026

Uh oh!

github-actions bot commented Mar 9, 2026

Uh oh!

This comment has been minimized.

ChavdaSachin commented Mar 10, 2026

Uh oh!

ShridharGoel commented Mar 10, 2026

Uh oh!

ShridharGoel commented Mar 10, 2026

Uh oh!

ChavdaSachin commented Mar 10, 2026

Uh oh!

ShridharGoel commented Mar 10, 2026

Uh oh!

puneetlath commented Mar 10, 2026

Uh oh!

JmillsExpensify commented Mar 10, 2026

Uh oh!

ChavdaSachin commented Mar 11, 2026

Uh oh!

ChavdaSachin commented Mar 11, 2026

Uh oh!

JmillsExpensify commented Mar 11, 2026

Uh oh!

ShridharGoel commented Mar 12, 2026

Uh oh!

ChavdaSachin commented Mar 23, 2026

Uh oh!

puneetlath commented Mar 23, 2026

Uh oh!

ShridharGoel commented Mar 23, 2026

Uh oh!

ChavdaSachin commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ShridharGoel commented Mar 24, 2026

Uh oh!

puneetlath commented Mar 24, 2026

Uh oh!

puneetlath left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ChavdaSachin commented Mar 24, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 24, 2026

Uh oh!

github-actions bot commented Mar 24, 2026

Uh oh!

OSBotify commented Mar 24, 2026

Uh oh!

OSBotify commented Mar 25, 2026

Uh oh!

nlemma commented Mar 25, 2026

Uh oh!

jponikarchuk commented Mar 25, 2026

Uh oh!

jponikarchuk commented Mar 25, 2026

Uh oh!

ChavdaSachin commented Feb 27, 2026 •

edited

Loading

ChavdaSachin commented Mar 9, 2026 •

edited

Loading

ChavdaSachin commented Mar 23, 2026 •

edited

Loading