Display a system message explaining report creation for moving unapproved expenses from the original report #78267

sosek108 · 2026-02-26T09:15:40Z

What i did:

modified this if to

Suggested change

if (isActionOfType(parentReportAction, CONST.REPORT.ACTIONS.TYPE.CREATED_REPORT_FOR_UNAPPROVED_TRANSACTIONS)) {

const {originalID} = getOriginalMessage(parentReportAction) ?? {};

const originalReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${originalID}`];

// eslint-disable-next-line @typescript-eslint/no-deprecated -- temporarily disabling rule for deprecated functions out of issue scope

const reportName = getReportName(originalReport);

// eslint-disable-next-line @typescript-eslint/no-deprecated -- temporarily disabling rule for deprecated functions out of issue scope

return getCreatedReportForUnapprovedTransactionsMessage(originalID, reportName, translateLocal);

}

if (isActionOfType(parentReportAction, CONST.REPORT.ACTIONS.TYPE.CREATED_REPORT_FOR_UNAPPROVED_TRANSACTIONS)) {

console.log('SHOW THIS LOG')

return 'Early return to test this'

}

followed test steps from QA

And this code was never executed and name of mentioned action was still correct. Is this code really needed?

@sosek108 It's the report thread name. If you're refactoring it, it will be covered by this test

App/tests/ui/components/HeaderViewTest.tsx

Lines 135 to 136 in 24fd24e

it('should display correct title for report with CREATED_REPORT_FOR_UNAPPROVED_TRANSACTIONS parent action', async () => {

// Given a chat thread with a CREATED_REPORT_FOR_UNAPPROVED_TRANSACTIONS parent action

Screen.Recording.2026-02-26.at.16.34.33.mov

Thanks for confirming

-Original file line number
+Diff line change
@@ Expand Up / @@ -1225,6 +1225,7 @@ const CONST = { @@
                     CARD_ASSIGNED: 'CARDASSIGNED',
                     CHANGE_FIELD: 'CHANGEFIELD', // OldDot Action
                     CHANGE_POLICY: 'CHANGEPOLICY',
+                    CREATED_REPORT_FOR_UNAPPROVED_TRANSACTIONS: 'CREATEDREPORTFORUNAPPROVEDTRANSACTIONS',
                     CHANGE_TYPE: 'CHANGETYPE', // OldDot Action
                     CHRONOS_OOO_LIST: 'CHRONOSOOOLIST',
                     CLOSED: 'CLOSED',
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -21,6 +21,7 @@ import type en from './en'; @@
     import type {
         ChangeFieldParams,
         ConnectionNameParams,
+        CreatedReportForUnapprovedTransactionsParams,
         DelegateRoleParams,
         DeleteActionParams,
         DeleteConfirmationParams,
@@ Expand Down Expand Up / @@ -920,6 +921,8 @@ const translations: TranslationDeepObject<typeof en> = { @@
             asCopilot: 'als Copilot für',
             harvestCreatedExpenseReport: ({reportUrl, reportName}: HarvestCreatedExpenseReportParams) =>
                 `hat diesen Bericht erstellt, um alle Ausgaben aus <a href="${reportUrl}">${reportName}</a> aufzunehmen, die mit der von dir gewählten Frequenz nicht eingereicht werden konnten`,
+            createdReportForUnapprovedTransactions: ({reportUrl, reportName}: CreatedReportForUnapprovedTransactionsParams) =>
+                `hat diesen Bericht für alle zurückgehaltenen Ausgaben aus <a href="${reportUrl}">${reportName}</a> erstellt`,
         },
         mentionSuggestions: {
             hereAlternateText: 'Alle in dieser Unterhaltung benachrichtigen',
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up @@
     import type {
         ChangeFieldParams,
         ConnectionNameParams,
+        CreatedReportForUnapprovedTransactionsParams,
         DelegateRoleParams,
         DeleteActionParams,
         DeleteConfirmationParams,
@@ Expand Down Expand Up / @@ -904,6 +905,8 @@ const translations = { @@
             asCopilot: 'as copilot for',
             harvestCreatedExpenseReport: ({reportUrl, reportName}: HarvestCreatedExpenseReportParams) =>
                 `created this report to hold all expenses from <a href="${reportUrl}">${reportName}</a> that couldn't be submitted on your chosen frequency`,
+            createdReportForUnapprovedTransactions: ({reportUrl, reportName}: CreatedReportForUnapprovedTransactionsParams) =>
+                `created this report for any held expenses from <a href="${reportUrl}">${reportName}</a>`,
         },
         mentionSuggestions: {
             hereAlternateText: 'Notify everyone in this conversation',
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -2,7 +2,14 @@ import {CONST as COMMON_CONST} from 'expensify-common'; @@
     import dedent from '@libs/StringUtils/dedent';
     import CONST from '@src/CONST';
     import type en from './en';
-    import type {HarvestCreatedExpenseReportParams, PaidElsewhereParams, RoutedDueToDEWParams, SplitDateRangeParams, ViolationsRterParams} from './params';
+    import type {
+        CreatedReportForUnapprovedTransactionsParams,
+        HarvestCreatedExpenseReportParams,
+        PaidElsewhereParams,
+        RoutedDueToDEWParams,
+        SplitDateRangeParams,
+        ViolationsRterParams,
+    } from './params';
     import type {TranslationDeepObject} from './types';
     /* eslint-disable max-len */
@@ Expand Down Expand Up / @@ -632,6 +639,8 @@ const translations: TranslationDeepObject<typeof en> = { @@
             asCopilot: 'como copiloto de',
             harvestCreatedExpenseReport: ({reportUrl, reportName}: HarvestCreatedExpenseReportParams) =>
                 `creó este informe para contener todos los gastos de <a href="${reportUrl}">${reportName}</a> que no se pudieron enviar con la frecuencia que elegiste`,
+            createdReportForUnapprovedTransactions: ({reportUrl, reportName}: CreatedReportForUnapprovedTransactionsParams) =>
+                `creó este informe para cualquier gasto retenido de <a href="${reportUrl}">${reportName}</a>`,
         },
         mentionSuggestions: {
             hereAlternateText: 'Notificar a todos en esta conversación',
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -21,6 +21,7 @@ import type en from './en'; @@
     import type {
         ChangeFieldParams,
         ConnectionNameParams,
+        CreatedReportForUnapprovedTransactionsParams,
         DelegateRoleParams,
         DeleteActionParams,
         DeleteConfirmationParams,
@@ Expand Down Expand Up / @@ -923,6 +924,8 @@ const translations: TranslationDeepObject<typeof en> = { @@
             asCopilot: 'en tant que copilote pour',
             harvestCreatedExpenseReport: ({reportUrl, reportName}: HarvestCreatedExpenseReportParams) =>
                 `a créé ce rapport pour regrouper toutes les dépenses de <a href="${reportUrl}">${reportName}</a> qui n'ont pas pu être soumises selon la fréquence que vous avez choisie`,
+            createdReportForUnapprovedTransactions: ({reportUrl, reportName}: CreatedReportForUnapprovedTransactionsParams) =>
+                `a créé ce rapport pour toutes les dépenses en attente depuis <a href="${reportUrl}">${reportName}</a>`,
         },
         mentionSuggestions: {
             hereAlternateText: 'Notifier tout le monde dans cette conversation',
@@ Expand Down @@

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Display a system message explaining report creation for moving unapproved expenses from the original report #78267

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!

Uh oh!

GitHub Actions / Changed files ESLint check

GitHub Actions / Changed files ESLint check

GitHub Actions / Changed files ESLint check

GitHub Actions / Changed files ESLint check

GitHub Actions / Changed files ESLint check

Uh oh!

sosek108 Feb 26, 2026

Uh oh!

hoangzinh Feb 26, 2026

Uh oh!

sosek108 Feb 26, 2026

Uh oh!

Uh oh!

Uh oh!

-Original file line number
+Diff line change
@@ Expand Up / @@ -84,6 +84,11 @@ type HarvestCreatedExpenseReportParams = { @@
         reportName: string;
     };
+    type CreatedReportForUnapprovedTransactionsParams = {
+        reportUrl: string;
+        reportName: string;
+    };
     type MovedTransactionParams = {
         reportUrl: string;
         reportName?: string;
@@ Expand Down Expand Up / @@ -777,6 +782,7 @@ export type { @@
         ReportPolicyNameParams,
         ReportArchiveReasonsInvoiceReceiverPolicyDeletedParams,
         HarvestCreatedExpenseReportParams,
+        CreatedReportForUnapprovedTransactionsParams,
         ReportArchiveReasonsRemovedFromPolicyParams,
         RequestAmountParams,
         MovedTransactionParams,
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -12,6 +12,9 @@ type ApproveMoneyRequestParams = { @@
          * }>
          */
         optimisticHoldReportExpenseActionIDs?: string;
+        /** The optimistic action ID for the report created for unapproved transactions */
+        optimisticCreatedReportForUnapprovedTransactionsActionID?: string;
     };
     export default ApproveMoneyRequestParams;

-Original file line number
+Diff line change
@@ Expand Up / @@ -7,7 +7,7 @@ @@
     import type {ValueOf} from 'type-fest';
     import type {LocaleContextProps, LocalizedTranslate} from '@components/LocaleContextProvider';
     import usePrevious from '@hooks/usePrevious';
     import {isHarvestCreatedExpenseReport, isPolicyExpenseChat} from '@libs/ReportUtils';
     import CONST from '@src/CONST';
     import IntlStore from '@src/languages/IntlStore';
     import type {TranslationPaths} from '@src/languages/types';
@@ Expand Down Expand Up / @@ -66,7 +66,7 @@ @@
     type MemberChangeMessageElement = MessageTextElement | MemberChangeMessageUserMentionElement | MemberChangeMessageRoomReferenceElement;
     let allReportActions: OnyxCollection<ReportActions>;
     Onyx.connect({
         key: ONYXKEYS.COLLECTION.REPORT_ACTIONS,
         waitForCollectionCallback: true,
         callback: (actions) => {
@@ Expand All / @@ -78,7 +78,7 @@ @@
     });
     let allReports: OnyxCollection<Report>;
     Onyx.connect({
         key: ONYXKEYS.COLLECTION.REPORT,
         waitForCollectionCallback: true,
         callback: (value) => {
@@ Expand All / @@ -87,13 +87,13 @@ @@
     });
     let isNetworkOffline = false;
     Onyx.connect({
         key: ONYXKEYS.NETWORK,
         callback: (val) => (isNetworkOffline = val?.isOffline ?? false),
     });
     let deprecatedCurrentUserAccountID: number | undefined;
     Onyx.connect({
         key: ONYXKEYS.SESSION,
         callback: (value) => {
             // When signed out, value is undefined
@@ Expand Down Expand Up / @@ -170,7 +170,10 @@ @@
         }
         // for report actions with this type we get an empty array as message by design
-        if (reportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.REIMBURSEMENT_DIRECTOR_INFORMATION_REQUIRED) {
+        if (
+            reportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.REIMBURSEMENT_DIRECTOR_INFORMATION_REQUIRED ||
+            reportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.CREATED_REPORT_FOR_UNAPPROVED_TRANSACTIONS
+        ) {
             return false;
         }
@@ Expand Down Expand Up / @@ -3314,6 +3317,11 @@ @@
         return translate('reportAction.harvestCreatedExpenseReport', {reportUrl, reportName});
     }
+    function getCreatedReportForUnapprovedTransactionsMessage(reportID: string | undefined, reportName: string, translate: LocalizedTranslate): string {
+        const reportUrl = getReportURLForCurrentContext(reportID);
+        return translate('reportAction.createdReportForUnapprovedTransactions', {reportUrl, reportName});
+    }
     function getDynamicExternalWorkflowRoutedMessage(
         action: OnyxEntry<ReportAction<typeof CONST.REPORT.ACTIONS.TYPE.DYNAMIC_EXTERNAL_WORKFLOW_ROUTED>>,
         translate: LocaleContextProps['translate'],
@@ Expand Down Expand Up / @@ -3728,6 +3736,7 @@ @@
         filterOutDeprecatedReportActions,
         getActionableCardFraudAlertMessage,
         getHarvestCreatedExpenseReportMessage,
+        getCreatedReportForUnapprovedTransactionsMessage,
         isSystemUserMentioned,
         withDEWRoutedActionsArray,
         withDEWRoutedActionsObject,
@@ Expand Down @@

Display a system message explaining report creation for moving unapproved expenses from the original report #78267

Uh oh!

Display a system message explaining report creation for moving unapproved expenses from the original report #78267

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!

Uh oh!

GitHub Actions / Changed files ESLint check

GitHub Actions / Changed files ESLint check

GitHub Actions / Changed files ESLint check

GitHub Actions / Changed files ESLint check

GitHub Actions / Changed files ESLint check

Uh oh!

sosek108 Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

hoangzinh Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

sosek108 Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!