Fixed an issue that could cause unexpected behavior when an instance that inherits from StdValueInstantiator is passed to defaultInstantiator.#521
Merged
Conversation
dinomite
approved these changes
Nov 26, 2021
dinomite
left a comment
dinomite
left a comment
Member
There was a problem hiding this comment.
Looks good to me, would you add yourself a line in the CREDITS-2.x file?
Member
|
I wrote a test for this, so I added the credits line. Merging now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading the comments and the initialization process of the
KotlinValueInstantiator, it looks like thedefaultInstantiatorofKotlinInstantiators.findValueInstantiatorrequiresStdValueInstantiator.On the other hand, this comparison is done with the
isoperator, which means that even if an instance that inheritsStdValueInstantiatoris passed, it will be treated as normal.In this
PR, this problem is fixed by comparing theClass.