Merged
Conversation
…model, since it's a better implementation
…model in the package imports and documentation
…for TPL models derived from super-positioning
4 tasks
Member
Author
|
@LSchueler thanks 😉 |
…it); add AttributeWarning class to warnings
…y now; check var_raw with TPL models; skip pykrige routine default vals
Member
Author
|
Coverage at 92% now! 🎉 |
This was referenced Mar 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates and refactors the covariance models:
rescaleargument and attribute to theCovModelclass to be able to rescale thelen_scale(usefull for unit conversion or rescalinglen_scaleto coincide with theintegral_scalelike it's the case with the Gaussian model)See: [Refactor] prefere "cor" to specify userdefined CovModel #90, Strange number in a variogram function PyKrige#119
len_rescaledattribute to theCovModelclass, which is the rescaledlen_scale:len_rescaled = len_scale / rescaledefault_rescaleto provide default rescale factor (can be overridden)doctestcallscorroutine and make use of therescaleargument (See: [Refactor] prefere "cor" to specify userdefined CovModel #90)HyperSpherical: (Replaces the oldIntersectionmodel) Derived from the intersection of hyper-spheres in arbitrary dimensions. Coincides with the linear model in 1D, the circular model in 2D and the classical spherical model in 3DSuperSpherical: like the HyperSpherical, but the shape parameter derived from dimension can be set by the user. Coincides with the HyperSpherical model by defaultJBessela hole model valid in all dimensions. The shape parameter controls the dimension it was derived from. Fornu=0.5this model coincides with the well knownwavehole model.TPLSimplea simple truncated power law controlled by a shape parameternu. Coincides with the truncated linear model fornu=1CovModelclass is new using a float precision (CovModel._prec=3) to truncate longish output