New Class for Conditioned Spatial Random Fields#130
Merged
MuellerSeb merged 31 commits intodevelopfrom Jan 27, 2021
Merged
Conversation
…variance; doc update
MuellerSeb
added
enhancement
Member
Author
|
@LSchueler this is ready for review. |
LSchueler
requested changes
Jan 26, 2021
Member
There was a problem hiding this comment.
Wow, the SRF class is looking soo much nicer now!
Really nice work!
I suggest to import gstools.field.base.Field to gstools.field. The import in one of the examples looks a but ugly.
I just made a few small remarks in the code. I think after you have addressed we are ready to go!!
LSchueler
approved these changes
Jan 27, 2021
Member
LSchueler
left a comment
LSchueler
left a comment
There was a problem hiding this comment.
:-) Found another typo ;-)
But anyway, here is a big thumbs up!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #128, #126
This PR adds a new class for conditioned random fields
CondSRF.This class replaces the conditioning feature of the SRF class, which was limited to Ordinary and Simple kriging.
CondSRFbehaves similar to theSRFclass, but instead of a covariance model, it takes a kriging class as input. With this kriging class, all conditioning related settings are defined.During refactoring the
RandMethclass, a switch to select the sampling strategy was added.Note
This change breaks backward compatibility, since conditioned random fields are no longer provided by the
SRFclass.