Skip to content

Commit 2518856

Browse files
ludochgae-java-bot
authored andcommitted
Update Java version from 25-ea to 25 in Maven workflow.
PiperOrigin-RevId: 810960169 Change-Id: Ifc85416c2f519e4c1964d21af6229e850951670c
1 parent 97ac08c commit 2518856

File tree

5 files changed

+15
-13
lines changed

5 files changed

+15
-13
lines changed

.github/workflows/maven.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,14 +31,14 @@ jobs:
3131
strategy:
3232
matrix:
3333
os: [ubuntu-latest]
34-
java: [17, 21, 25-ea]
34+
java: [17, 21, 25]
3535
jdk: [temurin]
3636
include:
3737
- java: 17
3838
maven_profile: ""
3939
- java: 21
4040
maven_profile: "-Pjdk21"
41-
- java: 25-ea
41+
- java: 25
4242
maven_profile: "-Pjdk25"
4343
fail-fast: false
4444

@@ -59,7 +59,7 @@ jobs:
5959
run: |
6060
if [[ "${{ matrix.java }}" == "21" ]]; then
6161
echo "JAVA_HOME_21=$JAVA_HOME" >> $GITHUB_ENV
62-
elif [[ "${{ matrix.java }}" == "25-ea" ]]; then
62+
elif [[ "${{ matrix.java }}" == "25" ]]; then
6363
echo "JAVA_HOME_25=$JAVA_HOME" >> $GITHUB_ENV
6464
fi
6565

applications/springboot/pom.xml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
3737
<maven.deploy.skip>true</maven.deploy.skip>
3838
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
39-
<spring.boot.version>2.7.18</spring.boot.version>
39+
<spring.boot.version>3.5.5</spring.boot.version>
4040
<maven.compiler.target>1.8</maven.compiler.target>
4141
<maven.compiler.source>1.8</maven.compiler.source>
4242
</properties>
@@ -63,8 +63,9 @@
6363

6464
<!-- Include Servlet API -->
6565
<dependency>
66-
<groupId>javax.servlet</groupId>
67-
<artifactId>javax.servlet-api</artifactId>
66+
<groupId>jakarta.servlet</groupId>
67+
<artifactId>jakarta.servlet-api</artifactId>
68+
<version>6.1.0</version>
6869
<scope>provided</scope>
6970
</dependency>
7071

applications/springboot/src/main/webapp/WEB-INF/appengine-web.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
<runtime>java17</runtime>
1919
<system-properties>
2020
<property name="java.util.logging.config.file" value="WEB-INF/classes/logging.properties"/>
21+
<property name="appengine.use.jetty121" value="true"/>
2122
</system-properties>
2223
<instance-class>F4</instance-class>
2324
</appengine-web-app>

pom.xml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -236,10 +236,9 @@
236236
<profile>
237237
<id>jdk25</id>
238238
<properties>
239-
<!-- TODO: Update the JDK version to 25 once shader plugin is fixed for 25. -->
240-
<maven.compiler.release>23</maven.compiler.release>
241-
<maven.compiler.source>23</maven.compiler.source>
242-
<maven.compiler.target>23</maven.compiler.target>
239+
<maven.compiler.release>25</maven.compiler.release>
240+
<maven.compiler.source>25</maven.compiler.source>
241+
<maven.compiler.target>25</maven.compiler.target>
243242
</properties>
244243
<build>
245244
<plugins>

runtime/test/src/test/java/com/google/apphosting/runtime/jetty9/SpringBootTest.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,19 +45,19 @@ public void initialize() throws IOException, InterruptedException {
4545
"install",
4646
"appengine:stage",
4747
"-f",
48-
new File(currentDirectory, "../../applications/springboot/pom.xml")
48+
new File(currentDirectory.getParentFile().getParentFile(), "applications/springboot/pom.xml")
4949
.getAbsolutePath())
5050
.start();
5151
List<String> results = readOutput(process.getInputStream());
5252
System.out.println("mvn process output:" + results);
5353
int exitCode = process.waitFor();
5454
assertThat(0).isEqualTo(exitCode);
55-
appRoot = new File(currentDirectory, "../../applications/springboot/target/appengine-staging");
55+
appRoot = new File(currentDirectory.getParentFile().getParentFile(), "applications/springboot/target/appengine-staging");
5656
assertThat(appRoot.isDirectory()).isTrue();
5757
}
5858

5959
public SpringBootTest() {
60-
super("java17", "12.0", "EE8", false);
60+
super("java17", "12.1", "EE11", false);
6161
}
6262

6363
private RuntimeContext<DummyApiServer> runtimeContext() throws IOException, InterruptedException {
@@ -75,6 +75,7 @@ private static List<String> readOutput(InputStream inputStream) throws IOExcepti
7575
@Test
7676
public void testSpringBootCanBoot() throws Exception {
7777
initialize();
78+
Thread.sleep(1000);
7879
try (RuntimeContext<DummyApiServer> runtime = runtimeContext()) {
7980
runtime.executeHttpGet("/", "Hello world - springboot-appengine-standard!", 200);
8081
}

0 commit comments

Comments
 (0)