Merged
Conversation
kgala2
reviewed
Aug 18, 2025
build.sh
Outdated
| MYSQL_PASS | ||
| MYSQL_DB | ||
| MYSQL_IAM_CONNECTION_NAME | ||
| # MYSQL_IAM_CONNECTION_NAME |
Contributor
There was a problem hiding this comment.
can we remove the line instead of commenting it out
Collaborator
There was a problem hiding this comment.
A better version of the function: https://github.com/GoogleCloudPlatform/cloud-sql-go-connector/blob/81ca4d713c1864c93f86493ee0314d96c1099ada/build.sh#L112
Contributor
Author
There was a problem hiding this comment.
Updated based on the env_vars reference from @hessjcg
hessjcg
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix various things in build.sh script
testtobuildto avoid duplication.envrcas env default output file'when exporting the secret in.envrcfile