feat: remove and replace JndiDnsResolve with DnsJavaResolver#2195
Merged
feat: remove and replace JndiDnsResolve with DnsJavaResolver#2195
Conversation
hessjcg
force-pushed
the
feat-removereplace-jndidnsresolver
branch
2 times, most recently
from
953c05e to
e19d4a7
Compare
hessjcg
force-pushed
the
feat-removereplace-jndidnsresolver
branch
from
e19d4a7 to
32d0638
Compare
hessjcg
approved these changes
Sep 29, 2025
| } | ||
|
|
||
| @Test | ||
| public void testResolveTxt_notFound() throws NameNotFoundException { |
Collaborator
There was a problem hiding this comment.
This should throw a "not found" exception, instead of returning an empty list.
hessjcg
approved these changes
Sep 29, 2025
kgala2
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a stacked PR builds on top of #2193
Description:
This is a cleanup, to remove and replace
JndiDnsResolverwithDnsJavaResolver