feat: Use configured DNS name to lookup instance IP address#2244
Merged
feat: Use configured DNS name to lookup instance IP address#2244
Conversation
hessjcg
changed the title
hessjcg
force-pushed
the
gh-2243-instance-dns-lookup
branch
3 times, most recently
from
d94a69c to
afa899f
Compare
panavenue
previously approved these changes
Dec 17, 2025
Comment on lines
+113
to
+114
| @Override | ||
| public List<InetAddress> resolveHost(String hostName) throws UnknownHostException { |
Contributor
There was a problem hiding this comment.
nit: add comment description
hessjcg
force-pushed
the
gh-2243-instance-dns-lookup
branch
2 times, most recently
from
e378737 to
76506fa
Compare
Bug Description When a custom DNS name is used to connect to a Cloud SQL instance, the dialer should first attempt to resolve the custom DNS name to an IP address and use that for the connection. If the lookup fails, the dialer should fall back to using the IP address from the instance metadata. This change modifies the dialer to: Use the configured resolver to look up the host's IP address. Use the IP address from the A record of the custom DNS name if available. Fall back to the IP address from the instance metadata if the A record is not available. See also GoogleCloudPlatform/cloud-sql-go-connector#1053 Fixes: #2243
hessjcg
force-pushed
the
gh-2243-instance-dns-lookup
branch
from
76506fa to
12b8c64
Compare
panavenue
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a custom DNS name is used to connect to a Cloud SQL instance, the dialer should first attempt to resolve the custom DNS name to an IP address and use that for the connection. If the lookup fails, the dialer should fall back to using the IP address from the instance metadata.
This change modifies the dialer to:
Use the configured resolver to look up the host's IP address.
Use the IP address from the A record of the custom DNS name if available.
Fall back to the IP address from the instance metadata if the A record is not available.
See also GoogleCloudPlatform/cloud-sql-go-connector#1053
Fixes: #2243