fix: remove unused import#349
Merged
nifflets merged 2 commits intoGoogleCloudPlatform:mainfrom Nov 13, 2024
glasnt:re-template
Merged
fix: remove unused import#349nifflets merged 2 commits intoGoogleCloudPlatform:mainfrom glasnt:re-template
nifflets merged 2 commits intoGoogleCloudPlatform:mainfrom
glasnt:re-template
Conversation
nifflets
approved these changes
Nov 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed unused import
re.Tfrom _function_registry.pyWhich was deprecated in Python 3.13
Which this package doesn't yet explicitly support, but when creating a PR for this update, I ran into CI issues with Python 3.13 being too new for setup-python cache (which resolved when removing the harden-runner, but then there are larger issues most buildpack-integration tests failing)
Detected in GoogleCloudPlatform/cloud-run-samples#260