Skip to content

Add AssessmentRule resource for contactcenterinsights#16512

Open
scawful wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
scawful:scawful-assessment-rule
Open

Add AssessmentRule resource for contactcenterinsights#16512
scawful wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
scawful:scawful-assessment-rule

Conversation

@scawful
Copy link
Contributor

@scawful scawful commented Feb 24, 2026

Add AssessmentRule resource for contactcenterinsights
https://cloud.google.com/contact-center/insights/docs/reference/rest/v1/projects.locations.assessmentRules

`google_contact_center_insights_assessment_rule`

@github-actions github-actions bot requested a review from NickElliot February 24, 2026 19:29
@github-actions
Copy link

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 1702 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 8 files changed, 1702 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 265 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 226 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_contact_center_insights_assessment_rule (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_contact_center_insights_assessment_rule" "primary" {
  assessment_rule_id = # value needed
  sample_rule {
    conversation_filter = # value needed
    dimension           = # value needed
    sample_row          = # value needed
  }
  schedule_info {
    end_time   = # value needed
    start_time = # value needed
    time_zone  = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 10
Passed tests: 7
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • contactcenterinsights

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleBasicExample
  • TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleFullExample
  • TestAccContactCenterInsightsAssessmentRule_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleBasicExample [Error message] [Debug log]
TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleFullExample [Error message] [Debug log]
TestAccContactCenterInsightsAssessmentRule_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 1702 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 8 files changed, 1702 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 265 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 226 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_contact_center_insights_assessment_rule (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_contact_center_insights_assessment_rule" "primary" {
  assessment_rule_id = # value needed
  sample_rule {
    conversation_filter = # value needed
    dimension           = # value needed
    sample_row          = # value needed
  }
  schedule_info {
    end_time   = # value needed
    start_time = # value needed
    time_zone  = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 10
Passed tests: 7
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • contactcenterinsights

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleBasicExample
  • TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleFullExample
  • TestAccContactCenterInsightsAssessmentRule_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleBasicExample [Error message] [Debug log]
TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleFullExample [Error message] [Debug log]
TestAccContactCenterInsightsAssessmentRule_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 1702 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 8 files changed, 1702 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 265 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 226 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_contact_center_insights_assessment_rule (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_contact_center_insights_assessment_rule" "primary" {
  assessment_rule_id = # value needed
  sample_rule {
    conversation_filter = # value needed
    dimension           = # value needed
    sample_row          = # value needed
  }
  schedule_info {
    end_time   = # value needed
    start_time = # value needed
    time_zone  = # value needed
  }
}

@scawful
Copy link
Contributor Author

scawful commented Feb 24, 2026

I've removed the large OpenAPI JSON file and fixed the HCL quoting issues in the examples and tests. I also added explicit resource IDs to the test configurations.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 10
Passed tests: 7
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • contactcenterinsights

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleBasicExample
  • TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleFullExample
  • TestAccContactCenterInsightsAssessmentRule_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleBasicExample [Error message] [Debug log]
TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleFullExample [Error message] [Debug log]
TestAccContactCenterInsightsAssessmentRule_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 1702 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 8 files changed, 1707 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 265 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 228 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_contact_center_insights_assessment_rule (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_contact_center_insights_assessment_rule" "primary" {
  sample_rule {
    dimension  = # value needed
    sample_row = # value needed
  }
  schedule_info {
    end_time   = # value needed
    start_time = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 1707 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 8 files changed, 1707 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 265 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 228 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_contact_center_insights_assessment_rule (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_contact_center_insights_assessment_rule" "primary" {
  sample_rule {
    dimension  = # value needed
    sample_row = # value needed
  }
  schedule_info {
    end_time   = # value needed
    start_time = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 1707 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 8 files changed, 1707 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 265 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 228 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_contact_center_insights_assessment_rule (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_contact_center_insights_assessment_rule" "primary" {
  sample_rule {
    dimension  = # value needed
    sample_row = # value needed
  }
  schedule_info {
    end_time   = # value needed
    start_time = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 10
Passed tests: 7
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • contactcenterinsights

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleBasicExample
  • TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleFullExample
  • TestAccContactCenterInsightsAssessmentRule_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleBasicExample [Error message] [Debug log]
TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleFullExample [Error message] [Debug log]
TestAccContactCenterInsightsAssessmentRule_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 1707 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 8 files changed, 1703 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 265 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 226 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_contact_center_insights_assessment_rule (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_contact_center_insights_assessment_rule" "primary" {
  sample_rule {
    dimension  = # value needed
    sample_row = # value needed
  }
  schedule_info {
    end_time   = # value needed
    start_time = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 10
Passed tests: 7
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • contactcenterinsights

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleBasicExample
  • TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleFullExample
  • TestAccContactCenterInsightsAssessmentRule_update

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 10
Passed tests: 7
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • contactcenterinsights

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleBasicExample
  • TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleFullExample
  • TestAccContactCenterInsightsAssessmentRule_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 1703 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 8 files changed, 1703 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 265 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 226 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_contact_center_insights_assessment_rule (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_contact_center_insights_assessment_rule" "primary" {
  sample_rule {
    dimension  = # value needed
    sample_row = # value needed
  }
  schedule_info {
    end_time   = # value needed
    start_time = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 1703 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 8 files changed, 1703 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 265 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 226 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_contact_center_insights_assessment_rule (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_contact_center_insights_assessment_rule" "primary" {
  sample_rule {
    dimension  = # value needed
    sample_row = # value needed
  }
  schedule_info {
    end_time   = # value needed
    start_time = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 10
Passed tests: 7
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • contactcenterinsights

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleBasicExample
  • TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleFullExample
  • TestAccContactCenterInsightsAssessmentRule_update

Get to know how VCR tests work

2 similar comments
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 10
Passed tests: 7
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • contactcenterinsights

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleBasicExample
  • TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleFullExample
  • TestAccContactCenterInsightsAssessmentRule_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 10
Passed tests: 7
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • contactcenterinsights

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleBasicExample
  • TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleFullExample
  • TestAccContactCenterInsightsAssessmentRule_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleBasicExample [Error message] [Debug log]
TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleFullExample [Error message] [Debug log]
TestAccContactCenterInsightsAssessmentRule_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleBasicExample [Error message] [Debug log]
TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleFullExample [Error message] [Debug log]
TestAccContactCenterInsightsAssessmentRule_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleBasicExample [Error message] [Debug log]
TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleFullExample [Error message] [Debug log]
TestAccContactCenterInsightsAssessmentRule_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleBasicExample [Error message] [Debug log]
TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleFullExample [Error message] [Debug log]
TestAccContactCenterInsightsAssessmentRule_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1627 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1627 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 265 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 226 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 11
Passed tests: 8
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • contactcenterinsights

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleBasicExample
  • TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleFullExample
  • TestAccContactCenterInsightsAssessmentRule_sampleRow

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccContactCenterInsightsAssessmentRule_sampleRow [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccContactCenterInsightsAssessmentRule_sampleRow [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleBasicExample [Error message] [Debug log]
TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@scawful scawful force-pushed the scawful-assessment-rule branch from 0f0d56f to 52f3e76 Compare March 3, 2026 01:16
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1631 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1631 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 265 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 228 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 11
Passed tests: 8
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • contactcenterinsights

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleBasicExample
  • TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleFullExample
  • TestAccContactCenterInsightsAssessmentRule_sampleRow

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccContactCenterInsightsAssessmentRule_sampleRow [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccContactCenterInsightsAssessmentRule_sampleRow [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleBasicExample [Error message] [Debug log]
TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1631 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1631 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 265 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 228 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 11
Passed tests: 8
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • contactcenterinsights

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleBasicExample
  • TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleFullExample
  • TestAccContactCenterInsightsAssessmentRule_sampleRow

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccContactCenterInsightsAssessmentRule_sampleRow [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccContactCenterInsightsAssessmentRule_sampleRow [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleBasicExample [Error message] [Debug log]
TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1630 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1630 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 265 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 228 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1630 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1630 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 265 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 228 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 11
Passed tests: 8
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • contactcenterinsights

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleBasicExample
  • TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleFullExample
  • TestAccContactCenterInsightsAssessmentRule_sampleRow

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccContactCenterInsightsAssessmentRule_sampleRow [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccContactCenterInsightsAssessmentRule_sampleRow [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleBasicExample [Error message] [Debug log]
TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 11
Passed tests: 8
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • contactcenterinsights

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleBasicExample
  • TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleFullExample
  • TestAccContactCenterInsightsAssessmentRule_sampleRow

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccContactCenterInsightsAssessmentRule_sampleRow [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccContactCenterInsightsAssessmentRule_sampleRow [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleBasicExample [Error message] [Debug log]
TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1632 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1632 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 265 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 228 insertions(+))

@modular-magician
Copy link
Collaborator

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleBasicExample
  • TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleFullExample
  • TestAccContactCenterInsightsAssessmentRule_sampleRow
  • TestAccContactCenterInsightsAssessmentRule_update

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • contactcenterinsights

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1632 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1632 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 265 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 228 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 11
Passed tests: 8
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • contactcenterinsights

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleBasicExample
  • TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleFullExample
  • TestAccContactCenterInsightsAssessmentRule_sampleRow

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccContactCenterInsightsAssessmentRule_sampleRow [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccContactCenterInsightsAssessmentRule_sampleRow [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleBasicExample [Error message] [Debug log]
TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@github-actions
Copy link

github-actions bot commented Mar 3, 2026

@GoogleCloudPlatform/terraform-team @NickElliot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly lgtm other than the test failures
which are failing with the following:

Error: Error when reading or editing ContactCenterInsightsAssessmentRule "projects/ci-test-project-188019/locations/us-central1/assessmentRules/assessment-rule-basic-ioubxdcyv3": googleapi: Error 400: Invalid assessment rule ID assessment-rule-basic-ioubxdcyv3. Should match pattern: ^[A-Za-z0-9]{4,64}$

- name: endTime
type: String
description: |-
End time of the schedule. If not specified, will keep scheduling new
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this field could use a formatting explanation

- name: startTime
type: String
description: |-
Start time of the schedule. If not specified, will start as soon as the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as could this

@github-actions github-actions bot requested a review from NickElliot March 7, 2026 05:44
@scawful scawful force-pushed the scawful-assessment-rule branch from 60bf1af to 9c205cb Compare March 7, 2026 05:48
@scawful
Copy link
Contributor Author

scawful commented Mar 7, 2026

Fixed the assessment_rule_id pattern in examples and tests to be strictly alphanumeric (removed hyphens) to match the backend API validation logic.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1632 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 1632 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 265 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 228 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 11
Passed tests: 8
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • contactcenterinsights

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleBasicExample
  • TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleFullExample
  • TestAccContactCenterInsightsAssessmentRule_sampleRow

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleFullExample [Debug log]
TestAccContactCenterInsightsAssessmentRule_sampleRow [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccContactCenterInsightsAssessmentRule_sampleRow [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccContactCenterInsightsAssessmentRule_contactCenterInsightsAssessmentRuleBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants