Skip to content

tgc-revival: prune enable_private_nodes = false in converted HCL#16632

Merged
zli82016 merged 5 commits intoGoogleCloudPlatform:mainfrom
zli82016:fix-guest-accelerator-test
Mar 6, 2026
Merged

tgc-revival: prune enable_private_nodes = false in converted HCL#16632
zli82016 merged 5 commits intoGoogleCloudPlatform:mainfrom
zli82016:fix-guest-accelerator-test

Conversation

@zli82016
Copy link
Member

@zli82016 zli82016 commented Mar 6, 2026

enable_private_nodes = false and the field not in HCL behaves the same, as this field is in ForceSendFields and the false value is included in the API request when it is not specified in config.

Only convert the field enable_private_nodes when its value is true in CAI asset.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+), 1 deletion(-))

@zli82016 zli82016 force-pushed the fix-guest-accelerator-test branch from cfbff79 to 9120650 Compare March 6, 2026 19:11
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 8 files changed, 5 insertions(+), 640 deletions(-))

@zli82016 zli82016 force-pushed the fix-guest-accelerator-test branch from d9c3dd6 to 830b7a3 Compare March 6, 2026 19:58
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 8 files changed, 5 insertions(+), 640 deletions(-))

@zli82016 zli82016 force-pushed the fix-guest-accelerator-test branch from 830b7a3 to a9ea495 Compare March 6, 2026 21:37
@zli82016 zli82016 changed the title tgc-revival: Fix guest accelerator test tgc-revival: prune enable_private_nodes = false in converted HCL Mar 6, 2026
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 2 files changed, 20 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 2 files changed, 22 insertions(+), 3 deletions(-))

@zli82016 zli82016 marked this pull request as ready for review March 6, 2026 23:12
@zli82016 zli82016 requested a review from trodge March 6, 2026 23:13
@zli82016 zli82016 added this pull request to the merge queue Mar 6, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 490c3c8 Mar 6, 2026
23 checks passed
@zli82016 zli82016 deleted the fix-guest-accelerator-test branch March 6, 2026 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants