Bring Storage samples up to standard.

Author: jmdobry

package.json

@@ -45,7 +45,7 @@
     "check": "yarn check --strict-semver --integrity",
     "lint": "samples lint",
     "generate": "node ./scripts/generate",
-    "pretest": "npm run lint && ./scripts/clean",
+    "pretest": "npm run lint && node ./scripts/clean coverage",
     "unit-test": "ava --verbose -T 30s functions/**/test/**/*.test.js",
     "unit-cover": "nyc --cache npm test && nyc report --reporter=html",
     "system-test": "ava --verbose -T 30s vision/system-test/**/*.test.js",
@@ -55,6 +55,7 @@
   },
   "devDependencies": {
     "@google-cloud/nodejs-repo-tools": "1.4.13",
+    "@google-cloud/storage": "1.1.0",
     "ava": "0.19.1",
     "nyc": "10.3.2",
     "shelljs": "0.7.7"

scripts/clean

@@ -15,4 +15,35 @@
 
 require('shelljs/global');
 
-rm('-rf', 'coverage');
+const storage = require('@google-cloud/storage')();
+
+const args = process.argv.slice(2);
+
+if (!args.length || args[0] === 'coverage') {
+  rm('-rf', 'coverage');
+} else if (args[0] === 'buckets') {
+  const NAME_REG_EXP = /^nodejs-docs-samples-test-[a-z0-9]{8}-[a-z0-9]{4}-[a-z0-9]{4}-[a-z0-9]{4}-[a-z0-9]{12}$/;
+
+  storage
+    .getBuckets()
+    .then(([buckets]) => {
+      let promise = Promise.resolve();
+
+      buckets
+        .filter((bucket) => NAME_REG_EXP.test(bucket.name))
+        .forEach((bucket) => {
+          promise = promise.then(() => {
+            return bucket.deleteFiles()
+              .then(() => bucket.deleteFiles(), console.error)
+              .then(() => {
+                console.log(`Deleting ${bucket.name}`);
+                return bucket.delete();
+              }, console.error)
+              .catch(console.error);
+          });
+        });
+    })
+    .catch((err) => {
+      console.error('ERROR:', err);
+    });
+}

storage/README.md

@@ -110,8 +110,8 @@ __Usage:__ `node encryption.js --help`
 ```
 Commands:
   generate-encryption-key                                   Generate a sample encryption key.
-  upload <bucketName> <srcFileName> <destFileName> <key>    Encrypts and uploads a file.
-  download <bucketName> <srcFileName> <destFileName> <key>  Decrypts and downloads a file.
+  upload <bucketName> <srcFilename> <destFilename> <key>    Encrypts and uploads a file.
+  download <bucketName> <srcFilename> <destFilename> <key>  Decrypts and downloads a file.
   rotate <bucketName> <fileName> <oldkey> <newKey>          Rotates encryption keys for a file.
 
 Options: