feat: replaced cloudsql with alloydb#165
Merged
Merged
Conversation
yliaog
requested review from
a team,
apeabody,
erictune,
gtsorbo and
sleighton2022
as code owners
yliaog
force-pushed
the
db
branch
4 times, most recently
from
a2e56c4 to
7e77bd5
Compare
Collaborator
|
The CI tests passed, this just has a lint error for an unused variable: https://github.com/GoogleCloudPlatform/terraform-google-enterprise-application/pull/165/files#diff-617d9ef893b63896e1931d35e236841a7c51e877ea315fe676c7ce4d62c2ad8eL17 |
Collaborator
Author
|
Thanks @apeabody removed the unused 'env' variable, and rebased. |
apeabody
changed the title
Collaborator
Author
|
/gcbrun |
apeabody
reviewed
Jun 12, 2024
yliaog
force-pushed
the
db
branch
3 times, most recently
from
d0f7488 to
05466e4
Compare
Collaborator
Author
|
/gcbrun |
Collaborator
|
In @yliaog - Looks like that is occurring as part of https://github.com/GoogleCloudPlatform/bank-of-anthos/blob/main/src/ledger/ledger-db/initdb/1_create_transactions.sh |
yliaog
force-pushed
the
db
branch
3 times, most recently
from
b95b5f6 to
7daa767
Compare
Collaborator
Author
|
/gcbrun |
Collaborator
Author
|
/gcbrun |
gtsorbo
approved these changes
Aug 5, 2024
apeabody
approved these changes
Aug 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.