Major change to FlxTilemap/FlxTiles Improve collision, debug drawing, add various features (#3158)

* drawDebug boundingBox helpers

* allow tile instances to determine overlap

* simplify createTile

* make overlapsObject dynamic

* cc

* add orient + forEachOverlappingTile

* add separateObjects and similar helpers, revert overlapsWithCallback changes

* doc

* deprecate overrides

* fix deprecation warning

* add isOverlappingTile and docs to base

* add since

* cc

* doc

* remove new public helpers

* extract legacy code to new func

* cc

* add legacyCollision to coverage

* separate tests

* cleanup computeOverlap funcs

* add separate, computeOverlap tests

* check diagonal against walls

* check immovable, recursively in collision

* add other orient helpers

* add overloaded setTile/getTile methods + tests

* soft deprecation

* small cleanup

* better backwards compatibility

* add since

* more since

* more since

* dd getRowAt, getColumnAt, rowExists and columnExists

* D'oh!

* D'OH!

* processOverlaps -> objectOverlapsTiles + tests

* small changes

* test literal edge case

* more small stuff

* D'OH!!

Author: Geokureli

flixel/FlxObject.hx

@@ -212,15 +212,18 @@ class FlxRect implements IFlxPooled
 	}
 
 	/**
-	 * Checks to see if some FlxRect object overlaps this FlxRect object.
+	 * Checks to see if this rectangle overlaps another
 	 *
-	 * @param	Rect	The rectangle being tested.
-	 * @return	Whether or not the two rectangles overlap.
+	 * @param   rect  The other rectangle
+	 * @return  Whether the two rectangles overlap
 	 */
-	public inline function overlaps(Rect:FlxRect):Bool
+	public inline function overlaps(rect:FlxRect):Bool
 	{
-		var result = (Rect.x + Rect.width > x) && (Rect.x < x + width) && (Rect.y + Rect.height > y) && (Rect.y < y + height);
-		Rect.putWeak();
+		final result = rect.right > left
+			&& rect.left < right
+			&& rect.bottom > top
+			&& rect.top < bottom;
+		rect.putWeak();
 		return result;
 	}
 

flixel/math/FlxRect.hx

@@ -617,10 +617,8 @@ class FlxTypedPathfinderData<Tilemap:FlxBaseTilemap<FlxObject>>
 
 	public function hasValidStartEnd()
 	{
-		return startIndex >= 0
-			&& endIndex >= 0
-			&& startIndex < map.totalTiles
-			&& endIndex < map.totalTiles;
+		return map.tileExists(startIndex)
+			&& map.tileExists(endIndex);
 	}
 
 	public function destroy()
@@ -647,15 +645,15 @@ class FlxTypedPathfinderData<Tilemap:FlxBaseTilemap<FlxObject>>
 	 */
 	inline function getX(tile:Int)
 	{
-		return tile % map.widthInTiles;
+		return map.getColumn(tile);
 	}
 
 	/**
 	 * Helper for converting a tile index to a Y index.
 	 */
 	inline function getY(tile:Int)
 	{
-		return Std.int(tile / map.widthInTiles);
+		return map.getRow(tile);
 	}
 
 	/**
@@ -664,7 +662,7 @@ class FlxTypedPathfinderData<Tilemap:FlxBaseTilemap<FlxObject>>
 	inline function getTileCollisionsByIndex(tile:Int)
 	{
 		#if debug numChecks++; #end
-		return map.getTileCollisions(map.getTileByIndex(tile));
+		return map.getTileData(tile).allowCollisions;
 	}
 }