Added tests for comparing unsigned integer arrays to negative integer arrays and Python scalars

Author: ndgrigorian

dpctl/tests/elementwise/test_greater.py

@@ -263,3 +263,21 @@ def __sycl_usm_array_interface__(self):
     c = Canary()
     with pytest.raises(ValueError):
         dpt.greater(a, c)
+
+
+def test_greater_mixed_integer_kinds():
+    get_queue_or_skip()
+
+    x1 = dpt.flip(dpt.arange(-9, 1, dtype="i8"))
+    x2 = dpt.arange(10, dtype="u8")
+
+    # u8 - i8
+    res = dpt.greater(x2, x1)
+    assert dpt.all(res[1:])
+    assert not res[0]
+    # i8 - u8
+    assert not dpt.any(dpt.greater(x1, x2))
+
+    # Python scalar
+    assert dpt.all(dpt.greater(x2, -1))
+    assert not dpt.any(dpt.greater(-1, x2))

dpctl/tests/elementwise/test_greater_equal.py

@@ -261,3 +261,22 @@ def __sycl_usm_array_interface__(self):
     c = Canary()
     with pytest.raises(ValueError):
         dpt.greater_equal(a, c)
+
+
+def test_greater_equal_mixed_integer_kinds():
+    get_queue_or_skip()
+
+    x1 = dpt.flip(dpt.arange(-9, 1, dtype="i8"))
+    x2 = dpt.arange(10, dtype="u8")
+
+    # u8 - i8
+    res = dpt.greater_equal(x2, x1)
+    assert dpt.all(res)
+    # i8 - u8
+    res = dpt.greater_equal(x1, x2)
+    assert not dpt.any(res[1:])
+    assert res[0]
+
+    # Python scalar
+    assert dpt.all(dpt.greater_equal(x2, -1))
+    assert not dpt.any(dpt.greater_equal(-1, x2))

dpctl/tests/elementwise/test_less.py

@@ -263,3 +263,21 @@ def __sycl_usm_array_interface__(self):
     c = Canary()
     with pytest.raises(ValueError):
         dpt.less(a, c)
+
+
+def test_less_mixed_integer_kinds():
+    get_queue_or_skip()
+
+    x1 = dpt.flip(dpt.arange(-9, 1, dtype="i8"))
+    x2 = dpt.arange(10, dtype="u8")
+
+    # u8 - i8
+    assert not dpt.any(dpt.less(x2, x1))
+    # i8 - u8
+    res = dpt.less(x1, x2)
+    assert not res[0]
+    assert dpt.all(res[1:])
+
+    # Python scalar
+    assert not dpt.any(dpt.less(x2, -1))
+    assert dpt.all(dpt.less(-1, x2))

dpctl/tests/elementwise/test_less_equal.py

@@ -262,3 +262,21 @@ def __sycl_usm_array_interface__(self):
     c = Canary()
     with pytest.raises(ValueError):
         dpt.less_equal(a, c)
+
+
+def test_less_equal_mixed_integer_kinds():
+    get_queue_or_skip()
+
+    x1 = dpt.flip(dpt.arange(-9, 1, dtype="i8"))
+    x2 = dpt.arange(10, dtype="u8")
+
+    # u8 - i8
+    res = dpt.less_equal(x2, x1)
+    assert res[0]
+    assert not dpt.any(res[1:])
+    # i8 - u8
+    assert dpt.all(dpt.less_equal(x1, x2))
+
+    # Python scalar
+    assert not dpt.any(dpt.less_equal(x2, -1))
+    assert dpt.all(dpt.less_equal(-1, x2))

dpctl/tests/test_usm_ndarray_operators.py

@@ -124,3 +124,19 @@ def test_mat_ops(namespace):
     M.__matmul__(M)
     M.__imatmul__(M)
     M.__rmatmul__(M)
+
+
+@pytest.mark.parametrize("namespace", [dpt, Dummy()])
+def test_comp_ops(namespace):
+    try:
+        X = dpt.ones(1, dtype="u8")
+    except dpctl.SyclDeviceCreationError:
+        pytest.skip("No SYCL devices available")
+    X._set_namespace(namespace)
+    assert X.__array_namespace__() is namespace
+    assert X.__gt__(-1)
+    assert X.__ge__(-1)
+    assert not X.__lt__(-1)
+    assert not X.__le__(-1)
+    assert not X.__eq__(-1)
+    assert X.__ne__(-1)