clean up uneeded comments in tests

Author: thedonmon

src/Transports/NATS/Wolverine.Nats.Tests/MultiTenancyTests.cs

@@ -87,8 +87,6 @@ public void generates_wildcard_subscription_pattern()
     public void normalizes_slashes_in_tenant_id()
     {
         var mapper = new DefaultTenantSubjectMapper();
-        
-        // Tenant IDs with slashes get normalized to dots
         mapper.MapSubject("orders", "org/team").ShouldBe("org.team.orders");
     }
 
@@ -319,14 +317,12 @@ public async Task InitializeAsync()
         _output.WriteLine($"Using NATS URL: {_natsUrl}");
         _output.WriteLine($"Base subject: {_baseSubject}");
 
-        // Check if NATS is available
         if (!await IsNatsAvailable(_natsUrl))
         {
             _output.WriteLine("NATS not available, skipping test");
             return;
         }
-        
-        // Create sender host with multi-tenancy enabled
+
         _sender = await Host.CreateDefaultBuilder()
             .ConfigureLogging(logging => logging.AddXunitLogging(_output))
             .UseWolverine(opts =>
@@ -343,8 +339,6 @@ public async Task InitializeAsync()
             })
             .StartAsync();
 
-        // Create receiver host that listens for messages
-        // The receiver uses wildcard subscription to receive all tenant messages
         _receiver = await Host.CreateDefaultBuilder()
             .ConfigureLogging(logging => logging.AddXunitLogging(_output))
             .UseWolverine(opts =>
@@ -388,18 +382,15 @@ public async Task messages_are_routed_to_tenant_specific_subjects()
 
         _output.WriteLine($"Sending message {msg1.Id} with tenant1");
 
-        // Send message with tenant1 and track across both hosts
         var session = await _sender
             .TrackActivity()
             .AlsoTrack(_receiver)
             .Timeout(30.Seconds())
             .SendMessageAndWaitAsync(msg1, new DeliveryOptions { TenantId = "tenant1" });
 
-        // Verify message was sent
         var sentMessage = session.Sent.SingleMessage<TenantTestMessage>();
         sentMessage.Id.ShouldBe(msg1.Id);
 
-        // Verify message was received with correct tenant context
         var receivedEnvelope = session.Received.SingleEnvelope<TenantTestMessage>();
         receivedEnvelope.TenantId.ShouldBe("tenant1");
         receivedEnvelope.Message.ShouldBeOfType<TenantTestMessage>().Id.ShouldBe(msg1.Id);
@@ -420,7 +411,6 @@ public async Task different_tenants_route_to_different_subjects()
         _output.WriteLine($"Sending message {msg1.Id} with tenant1");
         _output.WriteLine($"Sending message {msg2.Id} with tenant2");
 
-        // Send message for tenant1
         var session1 = await _sender
             .TrackActivity()
             .AlsoTrack(_receiver)
@@ -431,7 +421,6 @@ public async Task different_tenants_route_to_different_subjects()
         received1.TenantId.ShouldBe("tenant1");
         received1.Message.ShouldBeOfType<TenantTestMessage>().Id.ShouldBe(msg1.Id);
 
-        // Send message for tenant2
         var session2 = await _sender
             .TrackActivity()
             .AlsoTrack(_receiver)
@@ -455,7 +444,6 @@ public async Task fallback_to_default_sends_to_base_subject()
         var msgWithTenant = new TenantTestMessage(Guid.NewGuid(), "With tenant");
         var msgWithoutTenant = new TenantTestMessage(Guid.NewGuid(), "Without tenant");
 
-        // Send message with tenant
         var session1 = await _sender
             .TrackActivity()
             .AlsoTrack(_receiver)
@@ -465,15 +453,13 @@ public async Task fallback_to_default_sends_to_base_subject()
         var tenantReceived = session1.Received.SingleEnvelope<TenantTestMessage>();
         tenantReceived.TenantId.ShouldBe("tenant1");
 
-        // Send message without tenant (should fallback to default)
         var session2 = await _sender
             .TrackActivity()
             .AlsoTrack(_receiver)
             .Timeout(30.Seconds())
             .SendMessageAndWaitAsync(msgWithoutTenant);
 
         var defaultReceived = session2.Received.SingleEnvelope<TenantTestMessage>();
-        // Without tenant, should receive on base subject without tenant extraction
         defaultReceived.TenantId.ShouldBeNull();
     }
 
@@ -521,7 +507,6 @@ public async Task InitializeAsync()
         _natsUrl = Environment.GetEnvironmentVariable("NATS_URL") ?? "nats://localhost:4222";
         _baseSubject = $"test.required.{Guid.NewGuid():N}";
 
-        // Check if NATS is available
         if (!await IsNatsAvailable(_natsUrl))
         {
             _output.WriteLine("NATS not available, skipping test");
@@ -625,7 +610,6 @@ public class TenantTestMessageHandler
 {
     public void Handle(TenantTestMessage message)
     {
-        // Message is handled - the test verifies via tracking
     }
 }
 

src/Transports/NATS/Wolverine.Nats.Tests/NatsIntegrationTestCollection.cs

@@ -2,14 +2,5 @@
 
 namespace Wolverine.Nats.Tests;
 
-/// <summary>
-/// Test collection for NATS integration tests that require a running NATS server.
-/// These tests will be skipped if no NATS server is available at localhost:4222.
-/// </summary>
-[CollectionDefinition("NATS Integration Tests", DisableParallelization = true)]
-public class NatsIntegrationTestCollection
-{
-    // This class has no code, and is never instantiated. 
-    // Its purpose is just to be the place to apply [CollectionDefinition] 
-    // and all the attributes that configure the collection.
-}
+[CollectionDefinition("NATS Integration", DisableParallelization = true)]
+public class NatsIntegrationTestCollection;

src/Transports/NATS/Wolverine.Nats.Tests/NatsTransportComplianceTests.cs

@@ -1,6 +1,3 @@
-// NATS Transport Compliance Tests
-// These tests verify that the NATS transport conforms to Wolverine's transport contract
-
 #if true
 
 using JasperFx.Core;
@@ -25,7 +22,6 @@ public async Task InitializeAsync()
 
         OutboundAddress = new Uri($"nats://subject/{receiverSubject}");
 
-        // Check for NATS availability
         var natsUrl = Environment.GetEnvironmentVariable("NATS_URL") ?? "nats://localhost:4222";
 
         await SenderIs(opts =>
@@ -67,7 +63,6 @@ public async Task InitializeAsync()
 
         OutboundAddress = new Uri($"nats://subject/{receiverSubject}");
 
-        // Check for NATS availability
         var natsUrl = Environment.GetEnvironmentVariable("NATS_URL") ?? "nats://localhost:4222";
 
         await SenderIs(opts =>
@@ -110,7 +105,6 @@ public async Task InitializeAsync()
 
         OutboundAddress = new Uri($"nats://subject/{receiverSubject}");
 
-        // Check for NATS availability
         var natsUrl = Environment.GetEnvironmentVariable("NATS_URL") ?? "nats://localhost:4222";
 
         await SenderIs(opts =>

src/Transports/NATS/Wolverine.Nats.Tests/NatsTransportIntegrationTests.cs

@@ -85,17 +85,14 @@ public async Task send_message_to_and_receive_through_nats()
         if (_sender == null || _receiver == null)
             return; // Skip if NATS not available
 
-        // Arrange
         var message = new TestMessage(Guid.NewGuid(), "Hello NATS!");
 
-        // Act
         var tracked = await _sender
             .TrackActivity()
             .AlsoTrack(_receiver)
             .Timeout(30.Seconds())
             .SendMessageAndWaitAsync(message);
 
-        // Assert
         tracked.Sent.SingleMessage<TestMessage>().Should().BeEquivalentTo(message);
 
         tracked.Received.SingleMessage<TestMessage>().Should().BeEquivalentTo(message);
@@ -107,15 +104,13 @@ public async Task can_send_and_receive_multiple_messages()
         if (_sender == null || _receiver == null)
             return;
 
-        // Arrange
         var messages = new[]
         {
             new TestMessage(Guid.NewGuid(), "Message 1"),
             new TestMessage(Guid.NewGuid(), "Message 2"),
             new TestMessage(Guid.NewGuid(), "Message 3")
         };
 
-        // Act & Assert
         foreach (var message in messages)
         {
             var tracked = await _sender
@@ -172,14 +167,12 @@ public void server_version_is_detected_and_scheduled_send_support_is_determined(
         var runtime = _sender.Services.GetRequiredService<IWolverineRuntime>();
         var transport = runtime.Options.Transports.GetOrCreate<NatsTransport>();
 
-        // Verify connection has server info
         transport.Connection.ServerInfo.Should().NotBeNull();
         transport.Connection.ServerInfo!.Version.Should().NotBeNullOrEmpty();
 
         _output.WriteLine($"NATS Server Version: {transport.Connection.ServerInfo.Version}");
         _output.WriteLine($"ServerSupportsScheduledSend: {transport.ServerSupportsScheduledSend}");
 
-        // Parse version and verify our logic
         var versionString = transport.Connection.ServerInfo.Version.Split('-')[0];
         if (Version.TryParse(versionString, out var serverVersion))
         {
@@ -218,6 +211,5 @@ public class TestMessageHandler
 {
     public void Handle(TestMessage message)
     {
-        // Handler is required for Wolverine's message tracking to register the message as processed
     }
 }

src/Transports/NATS/Wolverine.Nats.Tests/NoParallelization.cs

@@ -1,4 +1,3 @@
 using Xunit;
 
-// Disable parallelization for NATS tests to avoid subject conflicts
 [assembly: CollectionBehavior(DisableTestParallelization = true)]

src/Transports/NATS/Wolverine.Nats.Tests/RequestReplyTests.cs

@@ -23,10 +23,8 @@ public RequestReplyTests(ITestOutputHelper output)
 
     public async Task InitializeAsync()
     {
-        // Use NATS_URL environment variable or default to local Docker port
         var natsUrl = Environment.GetEnvironmentVariable("NATS_URL") ?? "nats://localhost:4222";
-        
-        // Skip tests if NATS server is not available
+
         if (!await IsNatsServerAvailable(natsUrl))
         {
             _output.WriteLine($"NATS server not available at {natsUrl}. Skipping integration tests.");