Merge pull request ranaroussi#2794 from Jaypatel1511/fix/chart-none-guard

Fix TypeError when data['chart'] is None in history.py (ranaroussi#2670)

Author: ValueRaider

tests/test_prices.py

@@ -472,6 +472,14 @@ def test_transient_error_detection(self):
         self.assertFalse(_is_transient_error(YFPricesMissingError('INVALID', '')))
         self.assertFalse(_is_transient_error(KeyError("key")))
 
+    def test_invalid_ticker_raises_prices_missing_not_type_error(self):
+        # Regression for #2670: when Yahoo returns {"chart": null},
+        # history() must raise YFPricesMissingError not TypeError.
+        from yfinance.exceptions import YFPricesMissingError
+        dat = yf.Ticker("TICKER_DOES_NOT_EXIST_XYZ", session=self.session)
+        with self.assertRaises(YFPricesMissingError):
+            dat.history(period="1mo", raise_errors=True)
+
 
 if __name__ == '__main__':
     unittest.main()

yfinance/scrapers/history.py

@@ -271,11 +271,11 @@ def history(self, period=period_default, interval="1d",
             _price_data_debug += f"(Yahoo status_code = {data['status_code']})"
             _exception = YFPricesMissingError(self.ticker, _price_data_debug)
             fail = True
-        elif "chart" in data and data["chart"]["error"]:
+        elif "chart" in data and data["chart"] and data["chart"]["error"]:
             _price_data_debug += ' (Yahoo error = "' + data["chart"]["error"]["description"] + '")'
             _exception = YFPricesMissingError(self.ticker, _price_data_debug)
             fail = True
-        elif "chart" not in data or data["chart"]["result"] is None or not data["chart"]["result"] or not data["chart"]["result"][0]["indicators"]["quote"][0]:
+        elif "chart" not in data or not data["chart"] or data["chart"]["result"] is None or not data["chart"]["result"] or not data["chart"]["result"][0]["indicators"]["quote"][0]:
             _exception = YFPricesMissingError(self.ticker, _price_data_debug)
             fail = True
         elif period and period not in self._history_metadata['validRanges'] and not utils.is_valid_period_format(period):