Skip to content

Commit 04a99e8

Browse files
c-dilkstongtongcao
authored andcommitted
ci: small fixes after #632 (#656)
1 parent cc7b7e8 commit 04a99e8

3 files changed

Lines changed: 7 additions & 7 deletions

File tree

.github/issue_release.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
---
2-
title: Release build failed for tag ${{ env.TAG_NAME }}
2+
title: Release build failed for tag {{ env.TAG_NAME }}
33
---
44
Workflow Run: {{ env.REPO_URL }}/actions/runs/{{ env.RUN_ID }}

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ jobs:
9393
test_coatjava:
9494
needs: [ build ]
9595
strategy:
96-
fail-fast: false
96+
fail-fast: true
9797
matrix:
9898
runner:
9999
- ubuntu-latest

docs/dev_notes.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
Deploying a new version requires a new version number, named `$VERSION` in this
66
document.
77
- the release build will have version `$VERSION`
8-
- the git repository will have version `${VERSION}-SNAPSHOT`
8+
- the `git` repository will have version `${VERSION}-SNAPSHOT`
99
- note that this is **not** conventional, since typically `-SNAPSHOT` is used for _upcoming_ releases
1010

1111
### General Procedure
@@ -14,12 +14,12 @@ document.
1414
1. make sure you have no local changes (`git status`)
1515
1. `./deploy-coatjava.sh -v $VERSION`
1616
1. `git push` -> open PR -> review PR -> merge
17-
1. make git tag and release
17+
1. make `git` tag and release
1818

1919
> [!NOTE]
20-
> Should `deploy-coatjava.sh` fail midway, your repository may be left in a transient state; here's how to revert:
21-
> 1. `git switch -` to switch back to `development` branch
22-
> 1. `libexec/version-bump.sh $ORIGINAL_VERSION` and be sure to include the `-SNAPSHOT`; alternatively, 'git reset --hard'
20+
> Should `deploy-coatjava.sh` fail midway, your `git` repository may no longer be in the recommended initial state; here's how to revert:
21+
> 1. `git switch development` to switch back to `development` branch
22+
> 1. `libexec/version-bump.sh $ORIGINAL_VERSION` and be sure to include the `-SNAPSHOT`; alternatively, `git reset --hard`
2323
> 1. `git branch -D version/$VERSION` to delete the created version-bump branch
2424
2525
**Legend:**

0 commit comments

Comments
 (0)