Skip to content

Commit 22d7ec9

Browse files
committed
fix: exclude maven metadata and jacoco from shaded JAR
Excluding maven metadata fixes the following warning from `deployDistribution.sh`: ``` [WARNING] Artifact org.jlab.coat:coat-libs JAR (about to be installed/deployed) contains Maven Plugin metadata for conflicting coordinates: org.jacoco:jacoco-maven-plugin. Your JAR contains rogue Maven Plugin metadata. Possible causes may be: shaded into this JAR some Maven Plugin or some rogue resource. ``` Excluding `jacoco` since only used here for coverage testing
1 parent 5951e68 commit 22d7ec9

2 files changed

Lines changed: 5 additions & 6 deletions

File tree

common-tools/coat-lib/pom.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -225,9 +225,14 @@
225225
<filter>
226226
<artifact>*:*</artifact>
227227
<excludes>
228+
<!-- signature and certificate files -->
228229
<exclude>META-INF/*.SF</exclude>
229230
<exclude>META-INF/*.DSA</exclude>
230231
<exclude>META-INF/*.RSA</exclude>
232+
<!-- maven metadata about dependencies -->
233+
<exclude>META-INF/maven/**</exclude>
234+
<!-- jacoco -->
235+
<exclude>org/jacoco/**</exclude>
231236
</excludes>
232237
</filter>
233238
</filters>

parent/pom.xml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -193,12 +193,6 @@
193193
<execution>
194194
<goals>
195195
<goal>prepare-agent</goal>
196-
</goals>
197-
</execution>
198-
<execution>
199-
<id>report</id>
200-
<phase>prepare-package</phase>
201-
<goals>
202196
<goal>report</goal>
203197
</goals>
204198
</execution>

0 commit comments

Comments
 (0)