Reflection: always compute JVM signature of built-in functions manually

This fixes "KotlinReflectionInternalError: Unknown origin" when
computing JVM signatures of functions which have no origin (neither Java
element, nor `@kotlin.Metadata`, nor `.kotlin_builtins`). Besides
`Enum.values/valueOf` and `Cloneable.clone` handled previously, this
also includes `invoke` of function types, which are synthesized by the
compiler during compilation.

The idea of this code was probably to make sure that all known cases of
functions without origin would be listed in the `isKnownBuiltInFunction`
function, because some built-ins might have a different JVM signature
than what is computed by the naive algorithm. However, it seems safer to
try to compute the JVM signature anyway than failing early.

The code in KT-83608 started to fail in 2.3.0 because of the bug fix
made in KT-79206. Previously, classifier for suspend function types was
incorrectly null, and it did not occur to me that some code might've
relied on this wrong behavior.

RCA: see above.

 #KT-42199 Fixed
 #KT-83608 Fixed

(cherry picked from commit 9e2049c)

Author: udalov

analysis/low-level-api-fir/tests-gen/org/jetbrains/kotlin/analysis/low/level/api/fir/diagnostic/compiler/based/LLBlackBoxTestGenerated.java

@@ -0,0 +1,25 @@
+// TARGET_BACKEND: JVM
+// WITH_REFLECT
+
+import kotlin.reflect.KClass
+import kotlin.test.assertEquals
+import kotlin.test.assertNull
+
+fun interface FunInterface : () -> Int
+fun suspendFunction(): suspend () -> Int = null!!
+
+private fun check(expectedInvoke: String, klass: KClass<*>) {
+    val members = klass.members
+    assertEquals(setOf("equals", "hashCode", "toString", "invoke"), members.map { it.name }.toSet())
+    assertEquals(expectedInvoke, members.single { it.name == "invoke" }.toString())
+}
+
+fun box(): String {
+    check("fun () -> R.invoke(): R", Function0::class)
+    check("fun (P1) -> R.invoke(P1): R", Function1::class)
+    check("fun FunInterface.invoke(): kotlin.Int", FunInterface::class)
+
+    val suspendFun = ::suspendFunction.returnType.classifier
+    check("fun (P1) -> R.invoke(P1): R", suspendFun as KClass<*>)
+    return "OK"
+}

analysis/low-level-api-fir/tests-gen/org/jetbrains/kotlin/analysis/low/level/api/fir/diagnostic/compiler/based/LLReversedBlackBoxTestGenerated.java

@@ -27,4 +27,4 @@ fun createNewPlugin(): SimpleRibCoroutineWorker {
 fun main() {
     foo(FooWorker())
     bar(FooWorker())
-}
+}

compiler/testData/codegen/box/reflection/builtins/functionClassMembers.kt

@@ -27,4 +27,4 @@ fun createNewPlugin(): SimpleRibCoroutineWorker<MyInterface> {
 fun main() {
     foo<MyInterface>(FooWorker())
     bar<MyInterface>(FooWorker())
-}
+}

compiler/testData/ir/irText/expressions/funInterface/noConversionForSubtype.kt

@@ -26,5 +26,5 @@ internal fun createFunctionKmClass(arity: Int): KmClass = KmClass().apply {
         }))
     })
 
-    // TODO (KT-80710): `invoke` function (note that even though it's created in the old reflection, it causes a failure KT-42199.)
+    // TODO (KT-80710): `invoke` function.
 }

compiler/testData/ir/irText/expressions/funInterface/noConversionForSubtypeGeneric.kt

@@ -219,11 +219,7 @@ internal object RuntimeTypeMapper {
             }
         }
 
-        if (isKnownBuiltInFunction(function)) {
-            return mapJvmFunctionSignature(function)
-        }
-
-        throw KotlinReflectionInternalError("Unknown origin of $function (${function.javaClass})")
+        return mapJvmFunctionSignature(function)
     }
 
     fun mapPropertySignature(possiblyOverriddenProperty: PropertyDescriptor): JvmPropertySignature {
@@ -254,14 +250,6 @@ internal object RuntimeTypeMapper {
         )
     }
 
-    private fun isKnownBuiltInFunction(descriptor: FunctionDescriptor): Boolean {
-        if (DescriptorFactory.isEnumValueOfMethod(descriptor) || DescriptorFactory.isEnumValuesMethod(descriptor)) return true
-
-        if (descriptor.name == CloneableClassScope.CLONE_NAME && descriptor.valueParameters.isEmpty()) return true
-
-        return false
-    }
-
     private fun mapJvmFunctionSignature(descriptor: FunctionDescriptor): JvmFunctionSignature.KotlinFunction =
         JvmFunctionSignature.KotlinFunction(
             JvmMemberSignature.Method(mapName(descriptor), descriptor.computeJvmDescriptor(withName = false))