Make jl_assume, jl_assume_aligned, jl_unreachable asserts in debug (#61015)

When JL_NDEBUG is undefined, we should use these as assertions.
Suggested by @topolarity in
#60031 (comment).

---------

Co-authored-by: Cody Tapscott <84105208+topolarity@users.noreply.github.com>

Author: xal-0

src/julia_internal.h

@@ -2021,10 +2021,14 @@ struct _jl_image_fptrs_t;
 JL_DLLEXPORT void jl_write_coverage_data(const char*);
 void jl_write_malloc_log(void);
 
-#if jl_has_builtin(__builtin_unreachable) || defined(_COMPILER_GCC_) || defined(_COMPILER_INTEL_)
-#  define jl_unreachable() __builtin_unreachable()
+#ifdef JL_NDEBUG
+# if jl_has_builtin(__builtin_unreachable) || defined(_COMPILER_GCC_) || defined(_COMPILER_INTEL_)
+#   define jl_unreachable() __builtin_unreachable()
+# else
+#   define jl_unreachable() ((void)jl_assume(0))
+# endif
 #else
-#  define jl_unreachable() ((void)jl_assume(0))
+# define jl_unreachable() assert(0 && "unreachable")
 #endif
 
 extern uv_mutex_t symtab_lock;

src/support/dtypes.h

@@ -3,6 +3,7 @@
 #ifndef JL_DTYPES_H
 #define JL_DTYPES_H
 
+#include <assert.h>
 #include <stddef.h>
 #include <stddef.h> // double include of stddef.h fixes #3421
 #include <stdint.h>
@@ -142,52 +143,87 @@ typedef intptr_t ssize_t;
 #  define JL_ATTRIBUTE_ALIGN_PTRSIZE(x)
 #endif
 
-#ifdef __has_builtin
+#if defined(__has_builtin)
 #  define jl_has_builtin(x) __has_builtin(x)
 #else
 #  define jl_has_builtin(x) 0
 #endif
 
-#if jl_has_builtin(__builtin_assume)
-#define jl_assume(cond) (__extension__ ({               \
-                __typeof__(cond) cond_ = (cond);        \
-                __builtin_assume(!!(cond_));            \
-                cond_;                                  \
-            }))
-#elif defined(__GNUC__)
+#ifdef JL_NDEBUG
+#  if jl_has_builtin(__builtin_assume)
+#    define jl_assume(cond)                     \
+       (__extension__({                         \
+           __typeof__(cond) cond_ = (cond);     \
+           __builtin_assume(!!(cond_));         \
+           cond_;                               \
+       }))
+#  elif defined(__GNUC__)
 static inline void jl_assume_(int cond)
 {
     if (!cond) {
         __builtin_unreachable();
     }
 }
-#define jl_assume(cond) (__extension__ ({               \
-                __typeof__(cond) cond_ = (cond);        \
-                jl_assume_(!!(cond_));                  \
-                cond_;                                  \
-            }))
-#else
-#define jl_assume(cond) (cond)
-#endif
-
-#if jl_has_builtin(__builtin_assume_aligned) || defined(_COMPILER_GCC_)
-#define jl_assume_aligned(ptr, align) __builtin_assume_aligned(ptr, align)
-#elif defined(__GNUC__)
-#define jl_assume_aligned(ptr, align) (__extension__ ({         \
-                __typeof__(ptr) ptr_ = (ptr);                   \
-                jl_assume(((uintptr_t)ptr) % (align) == 0);     \
-                ptr_;                                           \
-            }))
-#elif defined(__cplusplus)
+#    define jl_assume(cond)                     \
+       (__extension__({                         \
+           __typeof__(cond) cond_ = (cond);     \
+           jl_assume_(!!(cond_));               \
+           cond_;                               \
+       }))
+#  else
+#    define jl_assume(cond) (cond)
+#  endif
+#  if jl_has_builtin(__builtin_assume_aligned) || defined(_COMPILER_GCC_)
+#    define jl_assume_aligned(ptr, align) __builtin_assume_aligned(ptr, align)
+#  elif defined(__GNUC__)
+#    define jl_assume_aligned(ptr, align)               \
+       (__extension__({                                 \
+           __typeof__(ptr) ptr_ = (ptr);                \
+           jl_assume(((uintptr_t)ptr_) % (align) == 0); \
+           ptr_;                                        \
+       }))
+#  elif defined(__cplusplus)
 template<typename T>
 static inline T
 jl_assume_aligned(T ptr, unsigned align)
 {
     (void)jl_assume(((uintptr_t)ptr) % align == 0);
     return ptr;
 }
+#  else
+#    define jl_assume_aligned(ptr, align) (ptr)
+#  endif
 #else
-#define jl_assume_aligned(ptr, align) (ptr)
+#  if defined(__GNUC__)
+#    define jl_assume(cond)                     \
+       (__extension__({                         \
+           __typeof__(cond) cond_ = (cond);     \
+           assert(!!(cond_));                   \
+           cond_;                               \
+       }))
+#    define jl_assume_aligned(ptr, align)               \
+       (__extension__({                                 \
+           __typeof__(ptr) ptr_ = (ptr);                \
+           assert(((uintptr_t)ptr_) % (align) == 0);    \
+           ptr_;                                        \
+       }))
+#  elif defined(__cplusplus)
+#    define jl_assume(cond)                     \
+       (([&]() {                                \
+           auto cond_ = (cond);                 \
+           assert(!!(cond_));                   \
+           return cond_;                        \
+       })())
+#    define jl_assume_aligned(ptr, align)               \
+       (([&]() {                                        \
+           auto ptr_ = (ptr);                           \
+           assert(((uintptr_t)ptr_) % (align) == 0);    \
+           return ptr_;                                 \
+       })())
+#  else
+#    define jl_assume(cond) (cond)
+#    define jl_assume_aligned(ptr, align) (ptr)
+#  endif
 #endif
 
 typedef int bool_t;