Skip to content

Commit 5ee0816

Browse files
authored
Logging: define isless between Integer and LogLevel (#60330)
1 parent 3efd5e7 commit 5ee0816

2 files changed

Lines changed: 9 additions & 0 deletions

File tree

base/logging/logging.jl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,8 @@ end
129129
LogLevel(level::LogLevel) = level
130130

131131
isless(a::LogLevel, b::LogLevel) = isless(a.level, b.level)
132+
isless(a::LogLevel, b::Integer) = isless(a.level, b)
133+
isless(a::Integer, b::LogLevel) = isless(a, b.level)
132134
+(level::LogLevel, inc::Integer) = LogLevel(level.level+inc)
133135
-(level::LogLevel, inc::Integer) = LogLevel(level.level-inc)
134136
convert(::Type{LogLevel}, level::Integer) = LogLevel(level)

stdlib/Logging/test/runtests.jl

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,13 @@ macro customlog(exs...) Base.CoreLogging.logmsg_code((Base.CoreLogging.@_sourcei
1919
@test :handle_message in names(Logging, all=true) # non-exported public function
2020
end
2121

22+
@testset "LogLevel compatibility with integers" begin
23+
@test Logging.Debug + 1000 == Logging.Info
24+
@test Logging.Warn - 1000 == Logging.Info
25+
@test Logging.Info < 500
26+
@test 500 < Logging.Warn
27+
end
28+
2229
@testset "ConsoleLogger" begin
2330
# First pass log limiting
2431
@test min_enabled_level(ConsoleLogger(devnull, Logging.Debug)) == Logging.Debug

0 commit comments

Comments
 (0)