RFC: deprecate showall#22847
Merged
Merged
Conversation
JeffBezanson
added
deprecation
Member
|
I know BenchmarkTools uses this. |
Member
|
Does it have to? |
Member
|
Probably not, I'm in favour of the deprecation but thought I would mention a place where it is actually used. |
Contributor
|
What happens with |
Sacha0
approved these changes
Jul 18, 2017
Member
Author
|
The behavior of |
tkelman
reviewed
Jul 18, 2017
| * The method `String(io::IOBuffer)` is deprecated to `String(take!(copy(io)))` ([#21438]). | ||
|
|
||
| * The function `showall` is deprecated. Showing entire values is the default, unless an | ||
| `IOContext` specifying `:limit=>false` is in use ([#22847]). |
Contributor
There was a problem hiding this comment.
unless specifying :limit=>true ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function has become pretty useless, since showing everything is basically the default.