Support filter for SkipMissing-wrapped arrays#31235
Merged
Merged
Conversation
ararslan
added
arrays
ararslan
commented
Mar 2, 2019
quinnj
approved these changes
Mar 2, 2019
ararslan
force-pushed
the
aa/filter-skipmissing
branch
from
6b4394d to
96b3a39
Compare
nalimilan
reviewed
Mar 3, 2019
Member
nalimilan
left a comment
nalimilan
left a comment
There was a problem hiding this comment.
Looks fine, but maybe this should go through triage?
See discussion in issue 31188.
ararslan
force-pushed
the
aa/filter-skipmissing
branch
from
96b3a39 to
ad218bc
Compare
JeffBezanson
approved these changes
Mar 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See discussion in #31188. This makes
filter(f, skipmissing(x))eagerly return an array similar to the wrapped array but with missing values and!f(xi)elements removed.