Skip to content

Generate and install a pkg-config file.#142

Merged
stevengj merged 5 commits intoJuliaStrings:masterfrom
tlsa:tlsa/pkgconfig-file
Nov 1, 2018
Merged

Generate and install a pkg-config file.#142
stevengj merged 5 commits intoJuliaStrings:masterfrom
tlsa:tlsa/pkgconfig-file

Conversation

@tlsa
Copy link
Contributor

@tlsa tlsa commented Aug 23, 2018

This adds a pkg-config file for libutf8proc.

Fixes issue #105.

tlsa added 3 commits August 23, 2018 21:35
This splits the prefix out from these variables, so that
the same variables can be used to construct the pkg-config
file.
@tlsa
Copy link
Contributor Author

tlsa commented Sep 12, 2018

@stevengj Does this look reasonable?

@ararslan ararslan requested a review from stevengj September 12, 2018 17:54
This splits the prefix out from these variables, so that
the same variables can be used to construct the pkg-config
file.
@tlsa
Copy link
Contributor Author

tlsa commented Sep 13, 2018

@stevengj Oh, good point. I still think it's worth ensuring the pkgconfig files stay in sync though, so I've reverted the previous change, and done it like this 53fb330 instead.

@tlsa
Copy link
Contributor Author

tlsa commented Sep 24, 2018

@stevengj Is this OK now?

@stevengj
Copy link
Member

stevengj commented Nov 1, 2018

LGTM.

@stevengj stevengj merged commit 5dcd382 into JuliaStrings:master Nov 1, 2018
@tlsa tlsa deleted the tlsa/pkgconfig-file branch March 28, 2019 19:52
@stevengj stevengj mentioned this pull request Mar 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants