test: migrate to PHPUnit 9 (#532)

Co-authored-by: Christopher Georg <christopher.georg@sr-travel.de>

Author: Chris53897

composer.json

@@ -21,7 +21,7 @@
         "psr/log": "^2.0||^3.0"
     },
     "require-dev": {
-        "phpunit/phpunit": "^8.5",
+        "phpunit/phpunit": "^9.6.29",
         "phpstan/phpstan": "^1.0.0",
         "phpstan/phpstan-phpunit": "^1.0.0",
         "friendsofphp/php-cs-fixer": "^3.0",

tests/Knp/Snappy/AbstractGeneratorTest.php

@@ -20,7 +20,6 @@ public function testAddOption(): void
         $this->assertEquals([], $media->getOptions());
 
         $r = new ReflectionMethod($media, 'addOption');
-        $r->setAccessible(true);
         $r->invokeArgs($media, ['foo', 'bar']);
 
         $this->assertEquals(['foo' => 'bar'], $media->getOptions(), '->addOption() adds an option');
@@ -54,7 +53,6 @@ public function testAddOptions(): void
         $this->assertEquals([], $media->getOptions());
 
         $r = new ReflectionMethod($media, 'addOptions');
-        $r->setAccessible(true);
         $r->invokeArgs($media, [['foo' => 'bar', 'baz' => 'bat']]);
 
         $this->assertEquals(
@@ -106,7 +104,6 @@ public function testSetOption(): void
         $logger->expects($this->once())->method('debug');
 
         $r = new ReflectionMethod($media, 'addOption');
-        $r->setAccessible(true);
         $r->invokeArgs($media, ['foo', 'bar']);
 
         $media->setOption('foo', 'abc');
@@ -145,7 +142,6 @@ public function testSetOptions(): void
         $logger->expects($this->exactly(4))->method('debug');
 
         $r = new ReflectionMethod($media, 'addOptions');
-        $r->setAccessible(true);
         $r->invokeArgs($media, [['foo' => 'bar', 'baz' => 'bat']]);
 
         $media->setOptions(['foo' => 'abc', 'baz' => 'def']);
@@ -506,11 +502,9 @@ public function testMergeOptions(): void
         $originalOptions = ['foo' => 'bar', 'baz' => 'bat'];
 
         $addOptions = new ReflectionMethod($media, 'addOptions');
-        $addOptions->setAccessible(true);
         $addOptions->invokeArgs($media, [$originalOptions]);
 
         $r = new ReflectionMethod($media, 'mergeOptions');
-        $r->setAccessible(true);
 
         $mergedOptions = $r->invokeArgs($media, [['foo' => 'ban']]);
 
@@ -559,7 +553,6 @@ public function testBuildCommand(string $binary, string $url, string $path, arra
         $media = $this->getMockForAbstractClass(AbstractGenerator::class, [], '', false);
 
         $r = new ReflectionMethod($media, 'buildCommand');
-        $r->setAccessible(true);
 
         $this->assertEquals($expected, $r->invokeArgs($media, [$binary, $url, $path, $options]));
     }
@@ -656,7 +649,6 @@ public function testCheckOutput(): void
         ;
 
         $r = new ReflectionMethod($media, 'checkOutput');
-        $r->setAccessible(true);
 
         $message = '->checkOutput() checks both file existence and size';
 
@@ -687,7 +679,6 @@ public function testCheckOutputWhenTheFileDoesNotExist(): void
         ;
 
         $r = new ReflectionMethod($media, 'checkOutput');
-        $r->setAccessible(true);
 
         $message = '->checkOutput() throws an InvalidArgumentException when the file does not exist';
 
@@ -725,7 +716,6 @@ public function testCheckOutputWhenTheFileIsEmpty(): void
         ;
 
         $r = new ReflectionMethod($media, 'checkOutput');
-        $r->setAccessible(true);
 
         $message = '->checkOutput() throws an InvalidArgumentException when the file is empty';
 
@@ -746,7 +736,6 @@ public function testCheckProcessStatus(): void
         ;
 
         $r = new ReflectionMethod($media, 'checkProcessStatus');
-        $r->setAccessible(true);
 
         try {
             $r->invokeArgs($media, [0, '', '', 'the command']);
@@ -778,7 +767,6 @@ public function testIsAssociativeArray(array $array, bool $isAssociativeArray):
         $generator = $this->getMockForAbstractClass(AbstractGenerator::class, [], '', false);
 
         $r = new ReflectionMethod($generator, 'isAssociativeArray');
-        $r->setAccessible(true);
         $this->assertEquals($isAssociativeArray, $r->invokeArgs($generator, [$array]));
     }
 
@@ -807,7 +795,6 @@ public function testItThrowsTheProperExceptionWhenFileExistsAndNotOverwritting()
             ->will($this->returnValue(true))
         ;
         $r = new ReflectionMethod($media, 'prepareOutput');
-        $r->setAccessible(true);
 
         $r->invokeArgs($media, ['', false]);
     }
@@ -867,15 +854,12 @@ public function testCleanupEmptyTemporaryFiles(): void
         ;
 
         $create = new ReflectionMethod($generator, 'createTemporaryFile');
-        $create->setAccessible(true);
         $create->invoke($generator, null, null);
 
         $files = new ReflectionProperty($generator, 'temporaryFiles');
-        $files->setAccessible(true);
         $this->assertCount(1, $files->getValue($generator));
 
         $remove = new ReflectionMethod($generator, 'removeTemporaryFiles');
-        $remove->setAccessible(true);
         $remove->invoke($generator);
     }
 
@@ -896,15 +880,12 @@ public function testleanupTemporaryFiles(): void
         ;
 
         $create = new ReflectionMethod($generator, 'createTemporaryFile');
-        $create->setAccessible(true);
         $create->invoke($generator, '<html/>', 'html');
 
         $files = new ReflectionProperty($generator, 'temporaryFiles');
-        $files->setAccessible(true);
         $this->assertCount(1, $files->getValue($generator));
 
         $remove = new ReflectionMethod($generator, 'removeTemporaryFiles');
-        $remove->setAccessible(true);
         $remove->invoke($generator);
     }
 

tests/Knp/Snappy/PdfTest.php

@@ -57,7 +57,7 @@ public function testThatSomethingUsingTmpFolder(): void
         $testObject->setTemporaryFolder(__DIR__);
 
         $testObject->getOutputFromHtml('<html></html>', ['footer-html' => 'footer']);
-        $this->assertRegExp('/emptyBinary --lowquality --footer-html ' . $q . '.*' . $q . ' ' . $q . '.*' . $q . ' ' . $q . '.*' . $q . '/', $testObject->getLastCommand());
+        $this->assertMatchesRegularExpression('/emptyBinary --lowquality --footer-html ' . $q . '.*' . $q . ' ' . $q . '.*' . $q . ' ' . $q . '.*' . $q . '/', $testObject->getLastCommand());
     }
 
     public function testThatSomethingUsingNonexistentTmpFolder(): void
@@ -76,14 +76,13 @@ public function testRemovesLocalFilesOnError(): void
     {
         $pdf = new PdfSpy();
         $method = new ReflectionMethod($pdf, 'createTemporaryFile');
-        $method->setAccessible(true);
         $method->invoke($pdf, 'test', $pdf->getDefaultExtension());
         $this->assertEquals(1, \count($pdf->temporaryFiles));
         $this->expectException(RuntimeException::class);
 
         throw new RuntimeException('test error.');
         // @phpstan-ignore-next-line See https://github.com/phpstan/phpstan/issues/7799
-        $this->assertFileNotExists(\reset($pdf->temporaryFiles));
+        $this->assertFileDoesNotExist(\reset($pdf->temporaryFiles));
     }
 
     /**
@@ -93,7 +92,7 @@ public function testOptions(array $options, string $expectedRegex): void
     {
         $testObject = new PdfSpy();
         $testObject->getOutputFromHtml('<html></html>', $options);
-        $this->assertRegExp($expectedRegex, $testObject->getLastCommand());
+        $this->assertMatchesRegularExpression($expectedRegex, $testObject->getLastCommand());
     }
 
     public function dataOptions(): array
@@ -142,12 +141,11 @@ public function testRemovesLocalFilesOnDestruct(): void
     {
         $pdf = new PdfSpy();
         $method = new ReflectionMethod($pdf, 'createTemporaryFile');
-        $method->setAccessible(true);
         $method->invoke($pdf, 'test', $pdf->getDefaultExtension());
-        $this->assertEquals(1, \count($pdf->temporaryFiles));
+        $this->assertCount(1, $pdf->temporaryFiles);
         $this->assertFileExists(\reset($pdf->temporaryFiles));
         $pdf->__destruct();
-        $this->assertFileNotExists(\reset($pdf->temporaryFiles));
+        $this->assertFileDoesNotExist(\reset($pdf->temporaryFiles));
     }
 }