add test

Author: jackkav

packages/insomnia-smoke-test/tests/smoke/pre-request-script.test.ts

@@ -27,3 +27,35 @@ test('can cancel pre-request script', async ({ app, page }) => {
   await page.getByRole('button', { name: 'Cancel Request' }).click();
   await page.click('text=Request was cancelled');
 });
+
+test('handle hidden browser window getting closed', async ({ app, page }) => {
+  test.slow(process.platform === 'darwin' || process.platform === 'win32', 'Slow app start on these platforms');
+
+  const text = await loadFixture('pre-request-collection.yaml');
+  await app.evaluate(async ({ clipboard }, text) => clipboard.writeText(text), text);
+
+  await page.getByRole('button', { name: 'Create in project' }).click();
+  await page.getByRole('menuitemradio', { name: 'Import' }).click();
+  await page.locator('[data-test-id="import-from-clipboard"]').click();
+  await page.getByRole('button', { name: 'Scan' }).click();
+  await page.getByRole('dialog').getByRole('button', { name: 'Import' }).click();
+
+  await page.getByText('Pre-request Scripts').click();
+
+  await page.getByLabel('Request Collection').getByTestId('Long running task').press('Enter');
+  await page.getByTestId('request-pane').getByRole('button', { name: 'Send' }).click();
+
+  await page.getByTestId('settings-button').click();
+  await page.getByLabel('Request timeout (ms)').fill('1');
+  await page.getByRole('button', { name: '' }).click();
+  await page.getByRole('button', { name: 'Send' }).click();
+
+  await page.getByText('Timeout: Pre-request script took too long').click();
+  await page.getByRole('tab', { name: 'Timeline' }).click();
+  await page.getByRole('tab', { name: 'Preview ' }).click();
+  const windows = await app.windows();
+  const hiddenWindow = windows[1];
+  hiddenWindow.close();
+  await page.getByRole('button', { name: 'Send' }).click();
+  await page.getByText('Timeout: Hidden browser window is not responding').click();
+});

packages/insomnia/src/hidden-window.ts

@@ -10,7 +10,7 @@ window.bridge.onmessage(async (data, callback) => {
     const timeout = data.context.timeout || 5000;
     const timeoutPromise = new Promise(resolve => {
       setTimeout(() => {
-        resolve({ error: 'Timeout: Operation took too long' });
+        resolve({ error: 'Timeout: Pre-request script took too long' });
       }, timeout);
     });
     const result = await Promise.race([timeoutPromise, runPreRequestScript(data)]);

packages/insomnia/src/network/network.ts

@@ -94,7 +94,6 @@ export const tryToExecutePreRequestScript = async (
     const timeout = settings.timeout || 5000;
     const timeoutPromise = new Promise((_, reject) => {
       setTimeout(() => {
-        cancelRequestById(request._id);
         reject(new Error('Timeout: Hidden browser window is not responding'));
         // Add one extra second to ensure the hidden browser window has had a chance to return its timeout
         // TODO: restart the hidden browser window